try to keep more information in errors [168639183]

Fixed

Feature Request

Status Update

No update yet.

Description

yb...@google.com

created issue #1

Sep 15, 2020 08:14PM

KSP models errors in 1 singleton class which means they have no information about what couldn't be resolved. Keeping that information in room is possible but complicates the code right now. For now, we'll use a singleton as well but probably worth improving it if KSP does not add support.

https://source.corp.google.com/aosp-androidx/room/compiler-processing/src/main/java/androidx/room/compiler/processing/ksp/KSTypeExt.kt;l=1?q=KSTypeEx&sq=package:android

https://source.corp.google.com/aosp-androidx/room/compiler-processing/src/test/java/androidx/room/compiler/processing/ksp/KspTypeTest.kt;l=75?q=ksptypetest&ct=os&sq=package:android

Comments

ap...@google.com <ap...@google.com> #2Sep 16, 2020 04:24PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit be1af0e7e2aa21e3e4698235213613182c82e644
Author: Yigit Boyar <yboyar@google.com>
Date: Tue Sep 15 13:18:36 2020

Update KSP to 20200914

Cleaned up some code for fixed issues.

Stopped extracting a reasonable name from errors when we have
access to KSName. Might bring back later but right now it adds
complexity that we don't need. (

b/168639183

)

Added checks to ensure KSTypeReference/KSTypeArgument .type is
not nullable. It will later change in KSP API and having it now
simplifies our logic.

Bug: 168639183
Bug: 160322705
Test: existing tests
Change-Id: I66cd4bfe2cd68e0a752f3ee9b98b7d4c2efb6c82

M buildSrc/src/main/kotlin/androidx/build/dependencies/Dependencies.kt
M room/compiler-processing/src/main/java/androidx/room/compiler/processing/ksp/KSTypeExt.kt
M room/compiler-processing/src/main/java/androidx/room/compiler/processing/ksp/KspProcessingEnv.kt
M room/compiler-processing/src/main/java/androidx/room/compiler/processing/ksp/KspRawType.kt
M room/compiler-processing/src/main/java/androidx/room/compiler/processing/ksp/KspType.kt
M room/compiler-processing/src/main/java/androidx/room/compiler/processing/ksp/KspTypeElement.kt
M room/compiler-processing/src/test/java/androidx/room/compiler/processing/ksp/KSTypeExtTest.kt
M room/compiler-processing/src/test/java/androidx/room/compiler/processing/ksp/KspTypeTest.kt

https://android-review.googlesource.com/1427138

da...@google.com <da...@google.com> May 1, 2023 06:46PM

Status: Won't Fix (Obsolete)

da...@google.com <da...@google.com> #3Jan 16, 2025 11:16PM

Status: Assigned (reopened)

KSP added more info to error types, reopening so we can take advantage of it and expose it in xprocessing error types instead of the default error.NonexistentClass that comes from KAPT

ap...@google.com <ap...@google.com> #4Jan 23, 2025 04:04PM

Project: platform/frameworks/support
Branch: androidx-main
Author: bcorso <bcorso@google.com>
Link: https://android-review.googlesource.com/3453246

Add proper error type names in KSP.

Expand for full commit details

Add proper error type names in KSP. 
 
This feature was added recently to KSP. 
 
Bug: 168639183 
Test: XTypeTest.kt 
Change-Id: I51ffa528364ba2ec6c19b2e5ba0096fda6ac21c7

Files:

M room/room-compiler-processing/src/main/java/androidx/room/compiler/processing/ksp/KSTypeJavaPoetExt.kt
M room/room-compiler-processing/src/main/java/androidx/room/compiler/processing/ksp/KSTypeKotlinPoetExt.kt
M room/room-compiler-processing/src/main/java/androidx/room/compiler/processing/ksp/KspTypeElement.kt
M room/room-compiler-processing/src/test/java/androidx/room/compiler/processing/XTypeTest.kt
M room/room-compiler-processing/src/test/java/androidx/room/compiler/processing/ksp/KSTypeExtTest.kt
M room/room-compiler-processing/src/test/java/androidx/room/compiler/processing/ksp/KspTypeTest.kt

Hash: d484495be76324a7a6001058cc6c062789ad2146
Date: Sat Jan 18 21:25:04 2025

da...@google.com <da...@google.com> Jan 23, 2025 06:13PM

Marked as fixed.

na...@google.com <na...@google.com> #5Jan 29, 2025 06:11PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.room:room-compiler-processing:2.7.0-alpha13

Issue 168639183