Fixed
Status Update
Comments
ap...@google.com <ap...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-master-dev
commit bc058ca6c9625bbd3c85bd2da7bbb11376ab6760
Author: Nader Jawad <njawad@google.com>
Date: Wed Sep 16 21:32:49 2020
Address API council feedback on compose
graphics APIs
Relnote: "--Updated scale and rotation
transformation APIs to consume a single
Offset parameter to represent the pivot
coordinate instead of separate float
parameters for the x/y coordinates in
DrawScope and DrawTransform
--Removed Rect.expandToInclude and Rect.join
methods
--Updated Radius documentation to say oval
in addition to elliptical
--Added documentation to indicate the
public constructor for the inline Radius
class is not to be called directly but instead
Radius objects should be instantiated through
their function constructors
--Removed RoundRect APIs to query topRight,
bottomRight, bottomCenter, etc.
--Deprecated Rect.shift in favor of Rect.translate
--Removed RoundRect.grow and Rect.shrink APIs
--Renamed RoundRect.outerRect to Rect.boundingRect
--Removed RoundRect.middleRect/tallMiddleRect/wideMiddleRect
and Rect.isStadium methods
--Renamed RoundRect.longestSide to RoundRect.maxDimension
--Renamed RoundRect.shortestSide to RoundRect.minDimension
--Changed RoundRect.center to be a property instead of a function
--Updated RoundRect constructor to consume Radius properties
instead of individual parameters for x/y radius values
--Removed Size APIs that assumed it was a Rectangle with
origin at 0,0
--Added a destructing API to Radius
--Migrated various RoundRect extension functions to be
properties instead"
Bug: 168762961
Test: re-ran compose tests and added unit tests to newly added
APIs
Change-Id: I8f5c738d1629b2cabd1b6e9fc8e8241dd06cfe2c
M compose/animation/animation/integration-tests/animation-demos/src/main/java/androidx/compose/animation/demos/RepeatedRotationDemo.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Border.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/ripple/RippleAnimation.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/ripple/RippleIndication.kt
M compose/ui/ui-geometry/api/current.txt
M compose/ui/ui-geometry/api/public_plus_experimental_current.txt
M compose/ui/ui-geometry/api/restricted_current.txt
M compose/ui/ui-geometry/src/commonMain/kotlin/androidx/compose/ui/geometry/Radius.kt
M compose/ui/ui-geometry/src/commonMain/kotlin/androidx/compose/ui/geometry/Rect.kt
M compose/ui/ui-geometry/src/commonMain/kotlin/androidx/compose/ui/geometry/RoundRect.kt
M compose/ui/ui-geometry/src/commonMain/kotlin/androidx/compose/ui/geometry/Size.kt
M compose/ui/ui-geometry/src/test/kotlin/androidx/compose/ui/geometry/RadiusTest.kt
M compose/ui/ui-geometry/src/test/kotlin/androidx/compose/ui/geometry/RoundRectTest.kt
M compose/ui/ui-graphics/api/current.txt
M compose/ui/ui-graphics/api/public_plus_experimental_current.txt
M compose/ui/ui-graphics/api/restricted_current.txt
M compose/ui/ui-graphics/samples/src/main/java/androidx/compose/ui/graphics/samples/DrawScopeSample.kt
M compose/ui/ui-graphics/src/androidAndroidTest/kotlin/androidx/compose/ui/graphics/drawscope/DrawScopeTest.kt
M compose/ui/ui-graphics/src/androidMain/kotlin/androidx/compose/ui/graphics/AndroidPath.kt
M compose/ui/ui-graphics/src/commonMain/kotlin/androidx/compose/ui/graphics/Outline.kt
M compose/ui/ui-graphics/src/commonMain/kotlin/androidx/compose/ui/graphics/drawscope/DrawScope.kt
M compose/ui/ui-graphics/src/commonMain/kotlin/androidx/compose/ui/graphics/drawscope/DrawTransform.kt
M compose/ui/ui-graphics/src/desktopMain/kotlin/androidx/compose/ui/graphics/Rects.kt
M compose/ui/ui-unit/src/test/kotlin/androidx/compose/ui/unit/PxTest.kt
M compose/ui/ui/integration-tests/ui-demos/src/main/java/androidx/compose/ui/demos/DeclarativeGraphicsDemo.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/OutlineResolver.kt
https://android-review.googlesource.com/1429548
Branch: androidx-master-dev
commit bc058ca6c9625bbd3c85bd2da7bbb11376ab6760
Author: Nader Jawad <njawad@google.com>
Date: Wed Sep 16 21:32:49 2020
Address API council feedback on compose
graphics APIs
Relnote: "--Updated scale and rotation
transformation APIs to consume a single
Offset parameter to represent the pivot
coordinate instead of separate float
parameters for the x/y coordinates in
DrawScope and DrawTransform
--Removed Rect.expandToInclude and Rect.join
methods
--Updated Radius documentation to say oval
in addition to elliptical
--Added documentation to indicate the
public constructor for the inline Radius
class is not to be called directly but instead
Radius objects should be instantiated through
their function constructors
--Removed RoundRect APIs to query topRight,
bottomRight, bottomCenter, etc.
--Deprecated Rect.shift in favor of Rect.translate
--Removed RoundRect.grow and Rect.shrink APIs
--Renamed RoundRect.outerRect to Rect.boundingRect
--Removed RoundRect.middleRect/tallMiddleRect/wideMiddleRect
and Rect.isStadium methods
--Renamed RoundRect.longestSide to RoundRect.maxDimension
--Renamed RoundRect.shortestSide to RoundRect.minDimension
--Changed RoundRect.center to be a property instead of a function
--Updated RoundRect constructor to consume Radius properties
instead of individual parameters for x/y radius values
--Removed Size APIs that assumed it was a Rectangle with
origin at 0,0
--Added a destructing API to Radius
--Migrated various RoundRect extension functions to be
properties instead"
Bug: 168762961
Test: re-ran compose tests and added unit tests to newly added
APIs
Change-Id: I8f5c738d1629b2cabd1b6e9fc8e8241dd06cfe2c
M compose/animation/animation/integration-tests/animation-demos/src/main/java/androidx/compose/animation/demos/RepeatedRotationDemo.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Border.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/ripple/RippleAnimation.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/ripple/RippleIndication.kt
M compose/ui/ui-geometry/api/current.txt
M compose/ui/ui-geometry/api/public_plus_experimental_current.txt
M compose/ui/ui-geometry/api/restricted_current.txt
M compose/ui/ui-geometry/src/commonMain/kotlin/androidx/compose/ui/geometry/Radius.kt
M compose/ui/ui-geometry/src/commonMain/kotlin/androidx/compose/ui/geometry/Rect.kt
M compose/ui/ui-geometry/src/commonMain/kotlin/androidx/compose/ui/geometry/RoundRect.kt
M compose/ui/ui-geometry/src/commonMain/kotlin/androidx/compose/ui/geometry/Size.kt
M compose/ui/ui-geometry/src/test/kotlin/androidx/compose/ui/geometry/RadiusTest.kt
M compose/ui/ui-geometry/src/test/kotlin/androidx/compose/ui/geometry/RoundRectTest.kt
M compose/ui/ui-graphics/api/current.txt
M compose/ui/ui-graphics/api/public_plus_experimental_current.txt
M compose/ui/ui-graphics/api/restricted_current.txt
M compose/ui/ui-graphics/samples/src/main/java/androidx/compose/ui/graphics/samples/DrawScopeSample.kt
M compose/ui/ui-graphics/src/androidAndroidTest/kotlin/androidx/compose/ui/graphics/drawscope/DrawScopeTest.kt
M compose/ui/ui-graphics/src/androidMain/kotlin/androidx/compose/ui/graphics/AndroidPath.kt
M compose/ui/ui-graphics/src/commonMain/kotlin/androidx/compose/ui/graphics/Outline.kt
M compose/ui/ui-graphics/src/commonMain/kotlin/androidx/compose/ui/graphics/drawscope/DrawScope.kt
M compose/ui/ui-graphics/src/commonMain/kotlin/androidx/compose/ui/graphics/drawscope/DrawTransform.kt
M compose/ui/ui-graphics/src/desktopMain/kotlin/androidx/compose/ui/graphics/Rects.kt
M compose/ui/ui-unit/src/test/kotlin/androidx/compose/ui/unit/PxTest.kt
M compose/ui/ui/integration-tests/ui-demos/src/main/java/androidx/compose/ui/demos/DeclarativeGraphicsDemo.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/OutlineResolver.kt
ap...@google.com <ap...@google.com> #3
Project: platform/frameworks/support
Branch: androidx-master-dev
commit b0365371788aa77b6fca19408d97514c2e2bdee9
Author: Nader Jawad <njawad@google.com>
Date: Tue Oct 13 16:04:00 2020
Renamed Radius to CornerRadius
Relnote: "Renamed Radius API to
CornerRadius to better express
how it is used throughout Compose.
Updated documentation to indicate
that negative corner radii are clamped
to zero."
Fixes: 168762961
Test: Re-ran compose tests
Change-Id: I130c7e1baadaf1b2f8e6c32f1af0d3702e2cee50
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/shape/RoundedCornerShapeTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Border.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/shape/RoundedCornerShape.kt
M compose/material/material/integration-tests/material-demos/src/main/java/androidx/compose/material/demos/ColorPickerDemo.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Checkbox.kt
M compose/ui/ui-geometry/api/current.txt
M compose/ui/ui-geometry/api/public_plus_experimental_current.txt
M compose/ui/ui-geometry/api/restricted_current.txt
M compose/ui/ui-geometry/src/commonMain/kotlin/androidx/compose/ui/geometry/CornerRadius.kt
M compose/ui/ui-geometry/src/commonMain/kotlin/androidx/compose/ui/geometry/RoundRect.kt
M compose/ui/ui-geometry/src/test/kotlin/androidx/compose/ui/geometry/CornerRadiusTest.kt
M compose/ui/ui-geometry/src/test/kotlin/androidx/compose/ui/geometry/RoundRectTest.kt
M compose/ui/ui-graphics/api/current.txt
M compose/ui/ui-graphics/api/public_plus_experimental_current.txt
M compose/ui/ui-graphics/api/restricted_current.txt
M compose/ui/ui-graphics/src/androidMain/kotlin/androidx/compose/ui/graphics/AndroidPath.kt
M compose/ui/ui-graphics/src/commonMain/kotlin/androidx/compose/ui/graphics/Outline.kt
M compose/ui/ui-graphics/src/commonMain/kotlin/androidx/compose/ui/graphics/drawscope/CanvasDrawScope.kt
M compose/ui/ui-graphics/src/commonMain/kotlin/androidx/compose/ui/graphics/drawscope/DrawScope.kt
M compose/ui/ui-graphics/src/desktopMain/kotlin/androidx/compose/ui/graphics/Rects.kt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/draw/ClipDrawTest.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/OutlineResolver.kt
https://android-review.googlesource.com/1459304
Branch: androidx-master-dev
commit b0365371788aa77b6fca19408d97514c2e2bdee9
Author: Nader Jawad <njawad@google.com>
Date: Tue Oct 13 16:04:00 2020
Renamed Radius to CornerRadius
Relnote: "Renamed Radius API to
CornerRadius to better express
how it is used throughout Compose.
Updated documentation to indicate
that negative corner radii are clamped
to zero."
Fixes: 168762961
Test: Re-ran compose tests
Change-Id: I130c7e1baadaf1b2f8e6c32f1af0d3702e2cee50
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/shape/RoundedCornerShapeTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Border.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/shape/RoundedCornerShape.kt
M compose/material/material/integration-tests/material-demos/src/main/java/androidx/compose/material/demos/ColorPickerDemo.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Checkbox.kt
M compose/ui/ui-geometry/api/current.txt
M compose/ui/ui-geometry/api/public_plus_experimental_current.txt
M compose/ui/ui-geometry/api/restricted_current.txt
M compose/ui/ui-geometry/src/commonMain/kotlin/androidx/compose/ui/geometry/CornerRadius.kt
M compose/ui/ui-geometry/src/commonMain/kotlin/androidx/compose/ui/geometry/RoundRect.kt
M compose/ui/ui-geometry/src/test/kotlin/androidx/compose/ui/geometry/CornerRadiusTest.kt
M compose/ui/ui-geometry/src/test/kotlin/androidx/compose/ui/geometry/RoundRectTest.kt
M compose/ui/ui-graphics/api/current.txt
M compose/ui/ui-graphics/api/public_plus_experimental_current.txt
M compose/ui/ui-graphics/api/restricted_current.txt
M compose/ui/ui-graphics/src/androidMain/kotlin/androidx/compose/ui/graphics/AndroidPath.kt
M compose/ui/ui-graphics/src/commonMain/kotlin/androidx/compose/ui/graphics/Outline.kt
M compose/ui/ui-graphics/src/commonMain/kotlin/androidx/compose/ui/graphics/drawscope/CanvasDrawScope.kt
M compose/ui/ui-graphics/src/commonMain/kotlin/androidx/compose/ui/graphics/drawscope/DrawScope.kt
M compose/ui/ui-graphics/src/desktopMain/kotlin/androidx/compose/ui/graphics/Rects.kt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/draw/ClipDrawTest.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/OutlineResolver.kt
Description
--Updated scale and rotation transformation APIs to consume a single Offset parameter to represent the pivot coordinate instead of separate float parameters for the x/y coordinates in DrawScope and DrawTransform
--Removed Rect.expandToInclude and Rect.join methods
--Updated Radius documentation to say oval in addition to elliptical
--Added documentation to indicate the public constructor for the inline Radius class is not to be called directly but instead Radius objects should be instantiated through their function constructors
--Removed RoundRect APIs to query topRight, bottomRight, bottomCenter, etc.
--Deprecated Rect.shift in favor of Rect.translate
--Removed RoundRect.grow and Rect.shrink APIs
--Renamed RoundRect.outerRect to Rect.boundingRect
--Removed RoundRect.middleRect/tallMiddleRect/wideMiddleRect and Rect.isStadium methods
--Renamed RoundRect.longestSide to RoundRect.maxDimension
--Renamed RoundRect.shortestSide to RoundRect.minDimension
--Changed RoundRect.center to be a property instead of a function
--Updated RoundRect constructor to consume Radius properties instead of individual parameters for x/y radius values
--Removed Size APIs that assumed it was a Rectangle with origin at 0,0 --Added a destructing API to Radius
--Migrated various RoundRect extension functions to be properties instead
--Rename Radius to CornerRadius
--Document behavior of negative radii