Nullable MutableLiveData gives an error when set to null [169249668]

Fixed

Bug

Status Update

No update yet.

Description

sp...@gmail.com

created issue #1

Sep 24, 2020 01:40PM

Component used:

implementation "androidx.lifecycle:lifecycle-viewmodel-ktx:$lifecycle_version"
implementation "androidx.lifecycle:lifecycle-runtime-ktx:$lifecycle_version"
implementation "androidx.lifecycle:lifecycle-livedata-ktx:$lifecycle_version"

Version used: 2.2.0 and 2.3.0-alpha07

Devices/Android versions reproduced on: N/A

ViewModels with more than one MutableLiveData get their nullability wrong.

Example:

class ExampleViewModel : ViewModel() {

    val data1 = MutableLiveData<Int>()

    val data2 = MutableLiveData<Int?>()

    fun funct() {
        data1.value = 1
        data2.value = null
    }
}

This gives the error Error: Cannot set non-nullable LiveData value to null [NullSafeMutableLiveData]

Comments

sp...@gmail.com <sp...@gmail.com> #2Sep 24, 2020 01:41PM

Since this is happening in Tink, rather than in the AndroidX library, it would be best to open an issue with that project, as there isn't an easy way for us to fix this.

se...@google.com <se...@google.com> Sep 24, 2020 02:43PM

Reassigned to jb...@google.com.

la...@gmail.com <la...@gmail.com> #3Jan 5, 2021 05:33AM

@2 I don't know what "Tink" is, but here, created:

https://github.com/google/tink/issues/534

Would this mean that this bug report should be written there as well:

https://issuetracker.google.com/issues/176215143
?

ma...@gmail.com <ma...@gmail.com> #4Mar 4, 2021 02:38PM

Tink is the library that does the heavy lifting in Jetpack Security.

And yes, potentially raising that issue with the Tink team directly could help.

sp...@gmail.com <sp...@gmail.com> #5Mar 4, 2021 02:57PM

@4 Well why didn't Google offer it there? Crashes are far more important than warning logs...
Here, created it there too:

https://github.com/google/tink/issues/535

[Deleted User] <[Deleted User]> #6Mar 9, 2021 02:45PM

Anyone here solved the issue? I have implemented the jetpack security and got the same crashes.

ap...@google.com <ap...@google.com> #7Mar 11, 2021 07:06PM

same warning

jb...@google.com <jb...@google.com> #8Mar 11, 2021 10:23PM

same logs for me

sp...@gmail.com <sp...@gmail.com> #9Mar 11, 2021 11:23PM

same warning for me

jb...@google.com <jb...@google.com> Mar 11, 2021 11:46PM

Marked as fixed.

go...@gmail.com <go...@gmail.com> #10Apr 21, 2021 10:11PM

Does anyone find any solution to it? I am also facing the same warning.

n....@tinkoff.ru <n....@tinkoff.ru> #11May 7, 2021 08:49AM

an...@gmail.com <an...@gmail.com> #12May 11, 2021 12:46PM

cu...@gmail.com <cu...@gmail.com> #13May 12, 2021 06:51AM

cu...@gmail.com <cu...@gmail.com> #14May 12, 2021 07:19AM

jo...@gmail.com <jo...@gmail.com> #15Jun 15, 2021 08:24PM

ya...@gmail.com <ya...@gmail.com> #16Jun 29, 2021 02:48PM

Project: platform/frameworks/support
Branch: androidx-main

commit a505a060ec741478e4096e8d160e136de18e8f39
Author: Daniel Angell <danielangell@google.com>
Date: Thu Oct 13 12:14:15 2022

Upgrade tink to 1.7.0 in security-crypto

Changed some calls into Tink to avoid deprecation warnings.

Bug: 185219606 (and likely others)
Test: Ran the security-crypto test suite
Change-Id: I7b1dcb3bf3f5d018a93ac3b06280724559f63ded

M security/security-crypto/build.gradle
M security/security-crypto/src/main/java/androidx/security/crypto/EncryptedFile.java
M security/security-crypto/src/main/java/androidx/security/crypto/EncryptedSharedPreferences.java

https://android-review.googlesource.com/2255035

iv...@gmail.com <iv...@gmail.com> #17Jul 7, 2021 05:59PM

It's not just fixed. It's also finally available.
i wonder what about the rare crashes though.

js...@gmail.com <js...@gmail.com> #18Aug 12, 2021 05:18PM

I'm pretty new on this project and I haven't dug deep into all of the strange behavior reported. But having read many of the bug reports my initial guess is crashes on initialization are related to encrypted files that got restored from a backup. If you back up all of an app's files - including EncryptedSharedPreferences - and then restore after moving to a new device, factory restoring a device, or perhaps even uninstalling and reinstalling an app, you will crash and it might not be clear why. The recommended way to use the security jetpack library lends to these kinds of errors. The files get encrypted with a key that won't be available inside of a backup copy. So decryption will always fail if that key isn't there when restoring from a backup.

sp...@gmail.com <sp...@gmail.com> #19Aug 13, 2021 01:50PM

@18 Sadly not related to backup:

https://issuetracker.google.com/issues/176215143#comment8

But even if it did, it should have been automatically handled by the library , and as long as it's not, be mentioned on the docs with an explanation of what should be done about it.

ad...@ade.se <ad...@ade.se> #20Sep 1, 2021 08:52AM

and as long as it's not, be mentioned on the docs with an explanation of what should be done about it.

I have at least added a warning to the docs for now.

I'll look into the bug you linked.