AGP fails to build libraries targeting java 1.7 [169252018]

Fixed

Bug

Status Update

No update yet.

Description

au...@google.com

created issue #1

Sep 23, 2020 05:54PM

Checkout androidx-studio-integration branch
Run ./frameworks/support/busytown/androidx-studio-integration.sh

> Task :core:core:compileReleaseJavaWithJavac FAILED
warning: -parameters is not supported for target value 1.7. Use 1.8 or later.
error: warnings found and -Werror specified

Comments

ga...@google.com <ga...@google.com> Sep 23, 2020 05:55PM

Assigned to hu...@google.com.

cm...@google.com <cm...@google.com> Sep 23, 2020 06:01PM

Reassigned to hu...@google.com.

au...@google.com <au...@google.com> #2Sep 23, 2020 06:01PM

Note, this is normally a warning, but we run with -Werror

ga...@google.com <ga...@google.com> #3Sep 23, 2020 06:06PM

To reproduce, create a default project in AS and to app/build.gradle

android {
    compileOptions {
        sourceCompatibility JavaVersion.VERSION_1_7
        targetCompatibility JavaVersion.VERSION_1_7
    }
}

tasks.withType(JavaCompile) {
    options.compilerArgs << "-Werror"
}

and run JAVA_HOME=<JDK_11> ./gradlew clean :app:comDJWJ.

je...@google.com <je...@google.com> #4Sep 23, 2020 11:00PM

Isn't it coming from the javac compiler itself. I do not believe jdk11 supports generating jdk7 bytecode but I might be wrong.

au...@google.com <au...@google.com> #5Sep 23, 2020 11:05PM

It's been working for almost a year for us.

jdk11/linux-x86/bin/javac -source 1.7 -target 1.7 Test.java

this compiles just fine.

Message last modified on Sep 23, 2020 11:05PM

au...@google.com <au...@google.com> #6Sep 23, 2020 11:08PM

It seems very likely it is that starts using -parameter calls to javac

https://googleplex-android-review.git.corp.google.com/c/platform/tools/base/+/7297703/

it seems that this argument is not supported when targeting 1.7, which a lot of AGP clients still do.

je...@google.com <je...@google.com> #7Sep 24, 2020 04:40AM

indeed, good finding.

On Wed, Sep 23, 2020 at 4:09 PM aurimas <buganizer-system+aurimas@google.com>
wrote:

- Show quoted text -

hu...@google.com <hu...@google.com> #8Sep 24, 2020 02:11PM

Marked as fixed.

Thanks for catching this bug! We have fixed this issue in AGP 4.2.0-beta01 (maybe also AGP 4.2.0-alpha13 if my cherrypick request is approved): https://android.googlesource.com/platform/tools/base/+/dbc225ea8b7d620cf1df819342db519f0537e323

We are now also treating javac warnings as errors in our tests to prevent similar issues.

@Jerome: Isn't it coming from the javac compiler itself. I do not believe jdk11 supports generating jdk7 bytecode but I might be wrong.

Looks like JDK 11 deprecates (but still supports) targeting Java 6, as detected by this test CompileSdkAndLanguageLevelTest.kt#63