Flaky test: DerivedSnapshotStateTests.multipleSnapshotsAreIsolatedAndCanBeApplied [169406779]

Fixed

Bug

Status Update

No update yet.

Description

go...@jakewharton.com

created issue #1

Sep 26, 2020 03:30AM

Failed twice locally. Usually passes.

Occurs on SHA c78636d53846380c505c62a5ce3511ccb7d52f66 of frameworks/support which is the latest as of the time of this bug report.

androidx.compose.runtime.snapshots.DerivedSnapshotStateTests > multipleSnapshotsAreIsolatedAndCanBeApplied FAILED
    java.lang.IllegalStateException: Reading a state that was created after the snapshot was taken or in a snapshot that has not yet been applied
        at androidx.compose.runtime.snapshots.SnapshotKt.readError(Snapshot.kt:1525)
        at androidx.compose.runtime.snapshots.SnapshotKt.readable(Snapshot.kt:1521)
        at androidx.compose.runtime.DerivedSnapshotState.value(DerivedState.kt:61)
        at androidx.compose.runtime.DerivedSnapshotState.getValue(DerivedState.kt:90)
        at androidx.compose.runtime.snapshots.DerivedSnapshotStateTests.multipleSnapshotsAreIsolatedAndCanBeApplied(DerivedSnapshotStateTests.kt:163)

Comments

cl...@google.com <cl...@google.com> Sep 28, 2020 10:21AM

Assigned to ch...@google.com.

ap...@google.com <ap...@google.com> #2Jan 26, 2021 05:11PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 932f4806b2824d047cffda31dcea89a8c526c49c
Author: Jelle Fresen <jellefresen@google.com>
Date: Tue Jul 14 18:29:17 2020

Use MonotonicFrameClock as AnimationClockObservable

Introduces an AnimationClockObservable that takes a MonotonicFrameClock,
so you can use a MonotonicFrameClock in the current animation APIs.

Moved one ScrollableTest to MonotonicFrameClock as a proof of concept.

Bug: 161247083
Test: ./gradlew compose:foundation:foundation:cC \
-Pandroid.testInstrumentationRunnerArguments.class=\
androidx.compose.foundation.ScrollableTest#scrollable_horizontalScroll
Relnote: "Added MonotonicFrameAnimationClock that enables you to use a
MonotonicFrameClock as an AnimationClockObservable to bridge the gap
between the new coroutines based clocks and APIs that still use the old
callback based clocks.

The MonotonicFrameClock equivalent of ManualAnimationClock is now
ManualFrameClock."

Change-Id: I111c7b7182a1495f95eab1bb808d3acd6af82447

M compose/compose-dispatch/api/current.txt
M compose/compose-dispatch/api/public_plus_experimental_current.txt
M compose/compose-dispatch/api/restricted_current.txt
M compose/compose-dispatch/src/commonMain/kotlin/androidx/compose/runtime/dispatch/BroadcastFrameClock.kt
M compose/compose-runtime/src/commonMain/kotlin/androidx/compose/runtime/Recomposer.kt
M ui/ui-animation-core/api/current.txt
M ui/ui-animation-core/api/public_plus_experimental_current.txt
M ui/ui-animation-core/api/restricted_current.txt
M ui/ui-animation-core/build.gradle
A ui/ui-animation-core/src/commonMain/kotlin/androidx/compose/animation/core/ManualFrameClock.kt
A ui/ui-animation-core/src/commonMain/kotlin/androidx/compose/animation/core/MonotonicFrameAnimationClock.kt
M ui/ui-foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/ScrollableTest.kt

https://android-review.googlesource.com/1362577

Issue 169406779

Description

Issue summary

Comments

cl...@google.com <cl...@google.com> Sep 28, 2020 10:21AM

ap...@google.com <ap...@google.com> #2Jan 26, 2021 05:11PM

Add comment

Issue metadata