Expose onScrollStarted/onScrollStopped listeners in verticalScroll modifier [169509805]

Fixed

Bug

Status Update

No update yet.

Description

ya...@gmail.com

created issue #1

Sep 28, 2020 02:45PM

Component used: ScrollableColumn/verticalScroll modifier

Version used: alpha-03

Devices/Android versions reproduced on: Irrelevant

The scrollable modifier has onScrollStarted/onScrollStopped parameters, but the verticalScroll/horizontalScroll modifiers are not exposing those. Some type visibility like state.scrollableController make it impossible to use scrollable manually.

Would also be nice to have those on ScrollableColumn/ScrollableRow I guess.

Use case: I'd like to receive the event where the user stopped scrolling, and use the velocity to trigger a snap behavior.

I have the following page:

Stack {
    val collapsingToolbarExpandedSize = ...
    ScrollableColumn(){
       Spacer(modifier = Modifier.height(collapsingToolbarSize))
    }
    CollapsingToolbar {
          ....
    }
}

I want to be able to trigger a smooth scroll to a certain value (0 or collapsingToolbarSize) to snap the toolbar state.

Maybe there is a different way of doing this. I tried using the rawDragGestureFilter, but the onStop was always receiving a value of 0 for the offset. Maybe this is a bug?

Thanks.

Comments

so...@google.com <so...@google.com> Sep 28, 2020 03:46PM

Assigned to ma...@google.com.

ma...@google.com <ma...@google.com> #2Sep 28, 2020 05:14PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019

Change the way to detect mismatch between POJO and query

This fixes cursor mismatch warnings with expandProjection.

Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8

M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt

https://android-review.googlesource.com/1123258

https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1

ya...@gmail.com <ya...@gmail.com> #3Sep 28, 2020 09:06PM

The following changes were cherrypicked through Coastguard (

https://android-build.googleplex.com/coastguard/)
Release Track: (

https://android-build.googleplex.com/coastguard/dashboard/6093116828680192/#/cherrypickHistory/all)
Created: 2019-10-14 17:23:42.610596+00:00
Changes: aosp/1123258

ap...@google.com <ap...@google.com> #4Oct 13, 2020 04:16PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020

Re-factor how errors are dismissed when query is re-written

This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (

b/140759491

).
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.

This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.

Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f

M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt

https://android-review.googlesource.com/1288456

ma...@google.com <ma...@google.com> #5Oct 19, 2020 01:27PM

As I mentioned above, I exposed InteractionState on the scrollable containers (and their states), so you are now able to understand whether fling or drag is happening and distinguish between them. This thought doesn't solve your issue, as you need to wait for a proper nested scrolling support, unfortunately.

Closing this as the main feature request of exposing ongoing scroll/fling is completed, please, follow the rest of the work here: b/162408885

Issue 169509805