Expose onScrollStarted/onScrollStopped listeners in verticalScroll modifier [169509805]

Fixed

Bug

Status Update

No update yet.

Description

ya...@gmail.com

created issue #1

Sep 28, 2020 02:45PM

Component used: ScrollableColumn/verticalScroll modifier

Version used: alpha-03

Devices/Android versions reproduced on: Irrelevant

The scrollable modifier has onScrollStarted/onScrollStopped parameters, but the verticalScroll/horizontalScroll modifiers are not exposing those. Some type visibility like state.scrollableController make it impossible to use scrollable manually.

Would also be nice to have those on ScrollableColumn/ScrollableRow I guess.

Use case: I'd like to receive the event where the user stopped scrolling, and use the velocity to trigger a snap behavior.

I have the following page:

Stack {
    val collapsingToolbarExpandedSize = ...
    ScrollableColumn(){
       Spacer(modifier = Modifier.height(collapsingToolbarSize))
    }
    CollapsingToolbar {
          ....
    }
}

I want to be able to trigger a smooth scroll to a certain value (0 or collapsingToolbarSize) to snap the toolbar state.

Maybe there is a different way of doing this. I tried using the rawDragGestureFilter, but the onStop was always receiving a value of 0 for the offset. Maybe this is a bug?

Thanks.

Comments

so...@google.com <so...@google.com> Sep 28, 2020 03:46PM

Assigned to ma...@google.com.

ma...@google.com <ma...@google.com> #2Sep 28, 2020 05:14PM

Project: platform/frameworks/support
Branch: androidx-main

commit cb1afd67dacbf14cd22206c6f5b543dbf18cec1f
Author: Tony Mak <tonymak@google.com>
Date: Thu Jan 06 14:52:58 2022

Deprecate all the APIs in textclassifier

Bug: 210509084

Test: Check api/current.txt and ensure all classes are deprecated

Relnote: "Deprecate all the APIs in the textclassifier module"

Change-Id: Idc18063196531c0e926162fefeadf2dc5f559da1

M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextSelection.java
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextLinks.java
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextClassificationSessionId.java
M textclassifier/textclassifier/api/public_plus_experimental_current.txt
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextClassification.java
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextClassificationManager.java
M textclassifier/textclassifier/api/current.txt
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextClassificationContext.java
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextLinksParams.java
M textclassifier/textclassifier/api/restricted_current.txt
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/ConversationAction.java
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextClassifier.java
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/ConversationActions.java
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/ExtrasUtils.java

https://android-review.googlesource.com/1938773

ya...@gmail.com <ya...@gmail.com> #3Sep 28, 2020 09:06PM

Is there any update when the alpha04 will be available? We need it to target api 31 because of the PendingIntent mutability flags missing in alpha03.

ap...@google.com <ap...@google.com> #4Oct 13, 2020 04:16PM

Marked as fixed.

I'll schedule it for the next release. Note that alpha04 is a complete turn-down of the library where all APIs are marked as Deprecated, so you'll also want to start removing your usages of the library.

ma...@google.com <ma...@google.com> #5Oct 19, 2020 01:27PM

Project: platform/frameworks/support
Branch: androidx-main

commit 19ed7e69823a09f3c63f8c8cdf339af8ca1645ab
Author: Alan Viverette <alanv@google.com>
Date: Mon Mar 14 15:18:16 2022

Bump textclassifier for final release and turn-down

Bug: 210509084
Change-Id: Ib8b2386903bb49baa3211f7de7fe1587fdda1483
Test: ./gradlew checkApi

M libraryversions.toml

https://android-review.googlesource.com/2024823

Issue 169509805