androidx.navigation.dynamicfeatures.fragment.ui.AbstractProgressFragment navigate multiple time [169636207]

Fixed

Bug

Status Update

No update yet.

Description

pq...@gmail.com

created issue #1

Sep 30, 2020 04:14AM

Component used: androidx.navigation:navigation-dynamic-features-fragment

Version used:2.3.0 Devices/Android versions reproduced on: all devices/android versions

override fun onResume() { super.onResume() if (navigated) { findNavController().popBackStack() return } var monitor = installViewModel.installMonitor if (monitor == null) { Log.i(TAG, "onResume: monitor is null, navigating") navigate() monitor = installViewModel.installMonitor } if (monitor != null) { Log.i(TAG, "onResume: monitor is now not null, observing") monitor.status.observe(this, StateObserver(monitor)) } }

Any time onResume() is called, monitor.status observed. When dynamic feature module is installed, each StateObserver will call navigate() and destination activity/fragment will be navigated multiple time

Comments

jb...@google.com <jb...@google.com> Oct 2, 2020 07:20PM

Assigned to be...@google.com.

be...@google.com <be...@google.com> #2Oct 5, 2020 03:18PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

ap...@google.com <ap...@google.com> #3Nov 4, 2020 06:40PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 29c5aee2bf2685e3bc2a0e38ca0290408aa65b11
Author: Ben Weiss <benweiss@google.com>
Date: Tue Nov 03 14:41:39 2020

Move install monitor observation to onViewCreated

Bug: 169636207
Test: Existing tests pass

Change-Id: Ia0c1d903066a5206de5b862eb2a0d9e0899c690b

M navigation/navigation-dynamic-features-fragment/src/main/java/androidx/navigation/dynamicfeatures/fragment/ui/AbstractProgressFragment.kt

https://android-review.googlesource.com/1486056

il...@google.com <il...@google.com> #4Nov 4, 2020 07:14PM

Marked as fixed.

This has been fixed and will be available in an upcoming Navigation 2.3.2 release.

b9...@gmail.com <b9...@gmail.com> #5Dec 14, 2020 05:37PM

#4 I think this fix break the behavior of DefaultProgressFragment, it doesn't call super.onViewCreated() so that the installation won't execute.

be...@google.com <be...@google.com> #6Dec 14, 2020 05:58PM

onViewCreated on Fragment is a GNDN function, so no need to override it.

Can you provide more information as to how your installation won't execute?

b9...@gmail.com <b9...@gmail.com> #7Dec 14, 2020 07:28PM

Move install monitor observation to onViewCreated

DefaultProgressFragment won't execute super(AbstractProgressFragment)'s onViewCreated(). So after this change, DefaultProgressFragment can't monitor the installation progress.

b9...@gmail.com <b9...@gmail.com> #8Dec 14, 2020 07:33PM

TL;DR

Call super.onViewCreated(view, savedInstanceState) in DefaultProgressFragment will solve this issue.

ap...@google.com <ap...@google.com> #9Dec 15, 2020 05:32PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 524a4f074b688975041f6ddd9db9eb31a88410e8
Author: Ben Weiss <benweiss@google.com>
Date: Tue Dec 15 12:26:06 2020

Add missing onViewCreated call

DefaultProgressFragment did not call super.onViewCreated which
could lead to installation progress not completing.

Bug: 169636207
Test: N/A
RelNote: Fix stuck installation progress
Change-Id: Ib27a77bc4572fc69cea38d738255c987449d6137

M navigation/navigation-dynamic-features-fragment/src/main/java/androidx/navigation/dynamicfeatures/fragment/ui/DefaultProgressFragment.kt

https://android-review.googlesource.com/1529306

b9...@gmail.com <b9...@gmail.com> #10Feb 4, 2021 04:07PM

Why this fix doesn't included in 2.3.3?

il...@google.com <il...@google.com> #11Feb 10, 2021 01:03AM

Re #10, yes, you're right this didn't make it into Navigation 2.3.3. Sorry about that. We'll look at doing a Navigation 2.3.4 with this fix.

b9...@gmail.com <b9...@gmail.com> #12Mar 6, 2021 03:47PM

#11 Still no 2.3.4 released.

za...@gmail.com <za...@gmail.com> #13Jul 4, 2022 02:51PM

I believe I'm facing another issue because of this fix:

When navigating to an activity that belongs to a dynamic module, the AbstractProgressFragment is not removed from the back stack. The line that's supposed to do it was moved from onResume to onViewCreated:

if (navigated) {
    findNavController().popBackStack()
    return
}

And onViewCreated is not called since we're coming back from another activity.

Moving that block back to the onResume method should solve the problem. In the meantime (as a workaround), I guess we can do as follows:

class CustomProgressFragment : AbstractProgressFragment() {

    private var navigated = false

    override fun onResume() {
        super.onResume()
        // Workaround:
        // AbstractProgressFragment is not being removed from the back stack when returning from another activity
        if (navigated) findNavController().popBackStack()
    }

    override fun onInstalled() {
        testing = true
    }
   
   ...
   ...
}

za...@gmail.com <za...@gmail.com> #14Jul 4, 2022 02:54PM

Update: Regarding the workaround I mentioned, this is the correct implementation of the onInstalled method

    override fun onInstalled() {
        navigated = true
    }

il...@google.com <il...@google.com> #15Jul 13, 2022 11:18PM

Re comment#13 - please file a separate bug with a sample project that reproduces your issue. onViewCreated() is indeed called when you return to the AbstractProgressFragment from another fragment, which is the only thing your newly loaded graph should have as its start destination. You...don't happen to have a start destination that is an activity destination? You shouldn't be using Dynamic Navigation at all in that case (as the system will auto-download the module your activity is in upon request).