Rename Color.Unset to Color.Unspecified [169797763]

Fixed

Bug

Status Update

No update yet.

Description

nj...@google.com

created issue #1

Sep 30, 2020 10:51PM

As part of API council feedback, we intend to standardize on Unspecified naming convention for constants of data/inline classes. We should rename Color.Unset to Color.Unspecified to match this pattern.

Comments

si...@google.com <si...@google.com> #2Sep 30, 2020 10:54PM

Project: platform/frameworks/support
Branch: androidx-main

commit 9082f62682f853ad5251a1c79dde9eccba7abdd9
Author: Max Alfonso-Ying <maxying@google.com>
Date: Thu Apr 18 00:34:40 2024

[M2 text field] Apply background to decoration box

...instead of to the BasicTextField, so changing the
backgroundColor will properly change the decoration
box's background color.

Fixes:

b/307694651

Test: added unit tests
Relnote: "Fix backgroundColor not applying to
TextFieldDecorationBox and OutlinedTextFieldDecorationBox.
Decoration boxes now accept a `shape` parameter."
Change-Id: I371c26718597cb36ac537e9412ce476532afb40d

M compose/material/material/api/current.txt
M compose/material/material/api/restricted_current.txt
M compose/material/material/integration-tests/material-demos/src/main/java/androidx/compose/material/demos/TextFieldDecorationBoxDemos.kt
M compose/material/material/src/androidInstrumentedTest/kotlin/androidx/compose/material/textfield/TextFieldDecorationBoxTest.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/OutlinedTextField.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/TextField.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/TextFieldDefaults.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/TextFieldImpl.kt

https://android-review.googlesource.com/3046833

nj...@google.com <nj...@google.com> #3Oct 1, 2020 01:27AM

Siyamed should we file separate issues to track other fields that should be renamed to Unspecified for each instance?

no...@google.com <no...@google.com> #4Oct 3, 2020 12:01AM

Drive by. I filed a ticket for TextUnit after the API council meeting: b/169704897

ap...@google.com <ap...@google.com> #5Oct 7, 2020 11:09PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit cd46cc34028f844feeb03578bc665db4c7394c14
Author: Nader Jawad <njawad@google.com>
Date: Wed Sep 30 19:03:45 2020

Rename Color.Unset to Color.Unspecified

Relnote: "As part of the standardization
of sentinel values for inline classes,
rename Color.Unset to Color.Unspecified
for consistency with other inline classes"

Fixes: 169797763
Test: re-ran compose tests
Change-Id: I9761102e79ade32812984466c020f2715065ac85

M compose/foundation/foundation-text/src/commonMain/kotlin/androidx/compose/foundation/text/CoreTextField.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/TextFieldCursorTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/BaseTextField.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Text.kt
M compose/material/material/integration-tests/material-demos/src/main/java/androidx/compose/material/demos/ColorPickerDemo.kt
M compose/material/material/integration-tests/material-demos/src/main/java/androidx/compose/material/demos/MaterialTextField.kt
M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/AlertDialogTest.kt
M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/MenuTest.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Colors.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/OutlinedTextField.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/ripple/RippleIndication.kt
M compose/ui/ui-graphics/api/current.txt
M compose/ui/ui-graphics/api/public_plus_experimental_current.txt
M compose/ui/ui-graphics/api/restricted_current.txt
M compose/ui/ui-graphics/src/commonMain/kotlin/androidx/compose/ui/graphics/Color.kt
M compose/ui/ui-graphics/src/commonMain/kotlin/androidx/compose/ui/graphics/colorspace/ColorSpaces.kt
M compose/ui/ui-graphics/src/test/java/androidx/compose/ui/graphics/ColorTest.kt
M compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/platform/AndroidParagraph.kt
M compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/platform/extensions/SpannableExtensions.kt
M compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/platform/extensions/TextPaintExtensions.kt
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/MultiParagraph.kt
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/Paragraph.kt
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/SpanStyle.kt
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/TextStyle.kt
M compose/ui/ui-text/src/desktopMain/kotlin/androidx/compose/ui/text/platform/DesktopParagraph.kt
M compose/ui/ui-text/src/test/java/androidx/compose/ui/text/SpanStyleTest.kt
M compose/ui/ui-text/src/test/java/androidx/compose/ui/text/TextStyleTest.kt
M ui/ui-tooling/src/androidTest/java/androidx/ui/tooling/inspector/ParameterFactoryTest.kt
M ui/ui-tooling/src/main/java/androidx/ui/tooling/inspector/ParameterFactory.kt

https://android-review.googlesource.com/1443616

Issue 169797763

Description

Issue summary

Comments

si...@google.com <si...@google.com> #2Sep 30, 2020 10:54PM

nj...@google.com <nj...@google.com> #3Oct 1, 2020 01:27AM

no...@google.com <no...@google.com> #4Oct 3, 2020 12:01AM

ap...@google.com <ap...@google.com> #5Oct 7, 2020 11:09PM

Add comment

Issue metadata