When using a Compose view in a Bubble, the wrong coordinates are registered for touch events [169874631]

Fixed

Bug

Status Update

No update yet.

Description

la...@gmail.com

created issue #1

Oct 1, 2020 11:23PM

Jetpack Compose release version: 1.0.0-alpha03

Android Studio Build: 4.2 Canary 12

Steps to Reproduce:

Use the following fragment in an activity that's launched in a bubble.

class BubbleFragment : Fragment() {
    override fun onCreateView(
        inflater: LayoutInflater,
        container: ViewGroup?,
        savedInstanceState: Bundle?
    ): View? {
        return ComposeView(requireContext()).apply {
            setContent {
                MaterialTheme {
                    BubbleContent()
                }
            }
        }
    }
}

@Composable
fun BubbleContent() {
    ScrollableColumn(
        modifier = Modifier
            .fillMaxWidth()
    ) {
        Spacer(modifier = Modifier.preferredHeight(16.dp))
        for (i in 0 until 50) {
            Spacer(modifier = Modifier.preferredHeight(16.dp))
            Button(
                onClick = {},
                modifier = Modifier
                    .padding(horizontal = 16.dp)
                    .preferredHeight(36.dp)
            ) {
                Text(
                    "Button $i"
                )
            }
        }
    }
}

Send a bubble.
Tap the button with label "Button 0".
Observe that the button with label "Button 2" gets the touch events.

Expected: The button with label "Button 0" gets the touch events.

It looks like there is a missing coordinating adjustment when a Compose view is shown in a bubble.

Comments

an...@google.com <an...@google.com> Oct 2, 2020 02:48PM

Assigned to sh...@google.com.

sh...@google.com <sh...@google.com> #2Oct 15, 2020 09:58PM

Our decision was:

We will investigate if it is possible to unify EditorValue and TextField value. (keeping the name TextfieldValue)

la...@gmail.com <la...@gmail.com> #3Oct 17, 2020 05:51AM

Correction: current structure is:

CoreTextField(EditorValue, (EditorValue) -> Unit) (in ui.text) TextField(TextFieldValue, (TextFieldValue) -> Unit) (in ui.foundation) FilledTextField(TextFieldValue, (TextFieldValue) -> Unit) (in ui.material) FilledTextField(String, (String) -> Unit) (in ui.material)

We have decided to investigate if it is possible to unify EditorValue and TextField value. (keeping the name TextfieldValue) at comment#2

I tried to see the side effects of such a change, and implemented a change that has two steps:

Use TextFieldValue in CoreTextField/TextField/FilledTextField. Deprecated older functions. aosp/1326149
Use TextFieldValue in ui-text-core, and lower layers of editing (below CoreTextField). aosp/1326150

Based on these changes what I see is:

The change is costly, and changes a lot of API surface
foundation.TextField uses TextFieldValue which does not have composition. I agree with Nona and Anastasia that app developers will not need composition information. However on the other hand foundation.TextField uses EditorValue.composition. When we move TextFieldValue to CoreTextField we need to add TextFieldValue.composition which in turn is accepted or returned to the developers. I believe the previous layering for TextFieldValue and EditorValue is correct. We can think more about the restructuring however I am not sure if it would make big changes in the API
- i.e. Rename EditorValue as CoreTextFieldValue
- i.e. Extend TextFieldValue from CoreTextFieldValue, or reuse CoreTextFieldValue in TextFieldValue etc, but somehow hide composition from TextFieldValue

Looking at the CLs my suggestion would be not making such a change, and at most renaming EditorValue and making in sync with TextFieldValue. (CoreTextFieldValue? TextInputValue? CoreInputFieldValue) (Note: We also had a discussion of changing TextField to InputField (and therefore CoreTextField to CoreInputField)

Message last modified on Oct 17, 2020 05:53AM

BubbleCompose.zip

518 KB

Download

la...@gmail.com <la...@gmail.com> #4Dec 6, 2020 12:40AM

When

@Deprecated
data class Data1 {}

@Deprecated
@Composable fun Fun1{value=Data1}

Lint on server doesn't like it

it gave me error:

w: /buildbot/src/android/androidx-master-dev/frameworks/support/ui/ui-text/src/main/java/androidx/ui/text/CoreTextField.kt: (52, 26): 'EditorValue' is deprecated. Use androidx.ui.input.TextFieldValue instead
w: /buildbot/src/android/androidx-master-dev/frameworks/support/ui/ui-text/src/main/java/androidx/ui/text/CoreTextField.kt: (58, 12): 'EditorValue' is deprecated. Use androidx.ui.input.TextFieldValue instead
w: /buildbot/src/android/androidx-master-dev/frameworks/support/ui/ui-text/src/main/java/androidx/ui/text/CoreTextField.kt: (60, 21): 'EditorValue' is deprecated. Use androidx.ui.input.TextFieldValue instead
w: /buildbot/src/android/androidx-master-dev/frameworks/support/ui/ui-text/src/main/java/androidx/ui/text/CoreTextField.kt: (88, 13): 'EditorValue' is deprecated. Use androidx.ui.input.TextFieldValue instead

Therefore I tried by not deprecating Data1 but only the composable.

so...@google.com <so...@google.com> Dec 7, 2020 11:51AM

Reassigned to mo...@google.com.

mo...@google.com <mo...@google.com> #5Jan 11, 2021 09:32PM

I first created changes that I took a two step approach:

change ui-text and ui-text-core, while using deprecated composable in ui-foundation.
change ui-foundation and ui-material to start using new object

Because of the problem mentioned in the previous comment, I abandoned those attempts:

Created one CL that contains all the change

https://android-review.googlesource.com/c/platform/frameworks/support/+/1328513

mo...@google.com <mo...@google.com> #6Jan 15, 2021 09:34PM

Reassigned to mo...@google.com.

CL is ready to go, marking as fixed.

la...@gmail.com <la...@gmail.com> #7Jan 15, 2021 10:10PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c2e5559d05db4329d7e0d3e92e53508194bf5d8d
Author: Siyamed Sinir <siyamed@google.com>
Date: Tue Jun 09 09:37:23 2020

Use TextFieldValue in all TextFields

Test: ./gradlew ui:ui-material:test
Test: ./gradlew ui:ui-material:cAT
Test: ./gradlew ui:ui-foundation:test
Test: ./gradlew ui:ui-foundation:cAT
Test: ./gradlew ui:ui-text:test
Test: ./gradlew ui:ui-text:cAT
Test: ./gradlew ui:ui-text-core:test
Test: ./gradlew ui:ui-text-core:cAT
Test: ./gradlew ui:ui-core:test
Test: ./gradlew ui:ui-core:cAT
Test: Manual test in the Demo app.

RelNote: "androidx.ui.foundation.TextFieldValue and
androidx.ui.input.EditorValue is deprecated. TextField,
FilledTextField and CoreTextField composables that uses
that type is also deprecated. Please use
androidx.ui.input.TextFieldValue instead"

Bug: 155211005
Change-Id: I4066d1f4d2e3e3514753aa3495680292dc55f89d

M compose/compose-runtime/samples/src/main/java/androidx/compose/samples/ModelSamples.kt
M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/input/EditProcessorBenchmark.kt
M ui/integration-tests/demos/src/main/java/androidx/ui/demos/DemoApp.kt
M ui/integration-tests/demos/src/main/java/androidx/ui/demos/DemoFilter.kt
M ui/ui-core/integration-tests/ui-core-demos/src/main/java/androidx/ui/core/demos/PopupDemo.kt
M ui/ui-core/integration-tests/ui-core-demos/src/main/java/androidx/ui/core/demos/autofill/ExplicitAutofillTypesDemo.kt
M ui/ui-core/src/androidTest/java/androidx/ui/input/RecordingInputConnectionTest.kt
M ui/ui-core/src/main/java/androidx/ui/input/InputState.kt
M ui/ui-core/src/main/java/androidx/ui/input/RecordingInputConnection.kt
M ui/ui-core/src/main/java/androidx/ui/input/TextInputServiceAndroid.kt
M ui/ui-core/src/test/java/androidx/ui/input/RecordingInputConnectionUpdateTextFieldValueTest.kt
M ui/ui-core/src/test/java/androidx/ui/input/TextInputServiceAndroidTest.kt
M ui/ui-desktop/src/jvmMain/kotlin/androidx/ui/desktop/DesktopPlatformInput.kt
M ui/ui-foundation/api/0.1.0-dev14.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev14.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev14.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/samples/src/main/java/androidx/ui/foundation/samples/TextFieldSample.kt
M ui/ui-foundation/src/androidTest/java/androidx/ui/foundation/SoftwareKeyboardTest.kt
M ui/ui-foundation/src/androidTest/java/androidx/ui/foundation/TextFieldFocusTest.kt
M ui/ui-foundation/src/androidTest/java/androidx/ui/foundation/TextFieldOnValueChangeTextFieldValueTest.kt
M ui/ui-foundation/src/androidTest/java/androidx/ui/foundation/TextFieldTest.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/TextField.kt
M ui/ui-layout/src/androidTest/java/androidx/ui/layout/test/TextLayoutDirectionModifierTest.kt
M ui/ui-material/api/0.1.0-dev14.txt
M ui/ui-material/api/current.txt
M ui/ui-material/api/public_plus_experimental_0.1.0-dev14.txt
M ui/ui-material/api/public_plus_experimental_current.txt
M ui/ui-material/api/restricted_0.1.0-dev14.txt
M ui/ui-material/api/restricted_current.txt
M ui/ui-material/samples/src/main/java/androidx/ui/material/samples/TextFieldSamples.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/FilledTextFieldTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextField.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/TextInputServiceForTests.kt
M ui/ui-text-core/api/0.1.0-dev14.txt
M ui/ui-text-core/api/current.txt
M ui/ui-text-core/api/public_plus_experimental_0.1.0-dev14.txt
M ui/ui-text-core/api/public_plus_experimental_current.txt
M ui/ui-text-core/api/restricted_0.1.0-dev14.txt
M ui/ui-text-core/api/restricted_current.txt
M ui/ui-text-core/build.gradle
M ui/ui-text-core/src/commonMain/kotlin/androidx/ui/input/EditProcessor.kt
D ui/ui-text-core/src/commonMain/kotlin/androidx/ui/input/EditorValue.kt
A ui/ui-text-core/src/commonMain/kotlin/androidx/ui/input/TextFieldValue.kt
M ui/ui-text-core/src/commonMain/kotlin/androidx/ui/input/TextInputService.kt
M ui/ui-text-core/src/test/java/androidx/ui/input/EditProcessorTest.kt
M ui/ui-text-core/src/test/java/androidx/ui/text/TextInputServiceTest.kt
M ui/ui-text/api/0.1.0-dev14.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev14.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev14.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/integration-tests/ui-text-compose-demos/src/main/java/androidx/ui/text/demos/ComposeInputField.kt
M ui/ui-text/integration-tests/ui-text-compose-demos/src/main/java/androidx/ui/text/demos/ComposeInputFieldFocusTransition.kt
M ui/ui-text/integration-tests/ui-text-compose-demos/src/main/java/androidx/ui/text/demos/ComposeInputFieldTrickyUseCase.kt
M ui/ui-text/integration-tests/ui-text-compose-demos/src/main/java/androidx/ui/text/demos/ComposeVariousInputField.kt
M ui/ui-text/integration-tests/ui-text-compose-demos/src/main/java/androidx/ui/text/demos/TailFollowingTextField.kt
M ui/ui-text/integration-tests/ui-text-compose-demos/src/main/java/androidx/ui/text/demos/TextFieldWIthScroller.kt
M ui/ui-text/src/androidTest/java/androidx/ui/text/TextFieldDelegateIntegrationTest.kt
M ui/ui-text/src/main/java/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/main/java/androidx/ui/text/TextFieldDelegate.kt
M ui/ui-text/src/test/java/androidx/ui/text/TextFieldDelegateTest.kt

https://android-review.googlesource.com/1328513

mo...@google.com <mo...@google.com> #8Jan 15, 2021 10:51PM

FYI: this caused far too many work. I regret pushing the change in.

tc...@google.com <tc...@google.com> #9Jan 21, 2021 07:43PM

This feature/bug is targeting an iteration that has already passed. Can you please update the status or move it to a future iteration? Thank you!

mo...@google.com <mo...@google.com> #10Jan 21, 2021 11:13PM

Marked as fixed.

I've tested this with alpha-10 and it appears to be working, so I will close this as Obsolete.

mo...@google.com <mo...@google.com> #11Jan 21, 2021 11:13PM

Realized that it isn't obsolete as much as fixed, so used fixed instead.

la...@gmail.com <la...@gmail.com> #12Jan 22, 2021 05:54AM

Unfortunately, this is still not fixed in the latest attached BubbleCompose.zip. Android Studio 2020.3.1 Canary 4 Jetpack Compose 1.0.0-alpha-10 Android Emulator Revision 3, API 30

BubbleCompose.zip

816 KB

Download

mo...@google.com <mo...@google.com> #13Jan 22, 2021 04:37PM

Status: Assigned (reopened)

I'm trying this on physical hardware and not seeing any issues. I'll try the emulator.

mo...@google.com <mo...@google.com> #14Jan 22, 2021 05:04PM

I am able to reproduce this on the emulator.

mo...@google.com <mo...@google.com> #15Jan 22, 2021 07:18PM

This is the same bug as another that we've seen elsewhere. The global position of the window is not being updated when it is needed.

tc...@google.com <tc...@google.com> #16Feb 5, 2021 10:02PM

Hello! This feature/bug is targeting an iteration that has already passed. Can you please update the status or hotlist accordingly? Thanks!

ap...@google.com <ap...@google.com> #17Feb 11, 2021 12:41AM

Project: platform/frameworks/support
Branch: androidx-main

commit f1cab8853ca8a98c99f5c475f15e445965134d60
Author: George Mount <mount@google.com>
Date: Fri Jan 22 23:38:32 2021

Change pointer input dependency on screen position.

Bug: 169874631
Bug: 175142755
Bug: 168920689
Bug: 169438847

* Changed hit testing so that it works relative to its
position rather than the global position. This
removes the walk-up for every modifier in the hit
test path.
* Removed all dependencies on global LayoutCoordinates
methods and removed those methods.
* Fixed problem where an AndroidComposeView that itself
was transformed could have its input mangled. For
example, if the AndroidComposeView was rotated, then
pointer input would previously only recognize the
offset and not the rotation, so pointer input would
be wrong about its position.
* Wrote a test to verify transforms to/from window
coordinates.
* Added tests to verify the coordinates in window are correct when view moved/rotated or window is moved

Relnote: Removed deprecated LayoutCoordinates methods, use function instead of the property for positionInParent and boundsInParent

Test: new tests. Ran all android pointer input tests.

Change-Id: I580edba74283600c3aafba6130a7af806df7d6c5

M compose/foundation/foundation-layout/src/androidAndroidTest/kotlin/androidx/compose/foundation/layout/AlignmentLineTest.kt
M compose/foundation/foundation-layout/src/androidAndroidTest/kotlin/androidx/compose/foundation/layout/BoxTest.kt
M compose/foundation/foundation-layout/src/androidAndroidTest/kotlin/androidx/compose/foundation/layout/RowColumnTest.kt
M compose/foundation/foundation-layout/src/androidAndroidTest/kotlin/androidx/compose/foundation/layout/SizeTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text/selection/SelectionContainerFocusTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text/selection/TextSelectionColorsScreenshotTest.kt
M compose/foundation/foundation/src/test/kotlin/androidx/compose/foundation/text/TextFieldDelegateTest.kt
M compose/foundation/foundation/src/test/kotlin/androidx/compose/foundation/text/selection/MockCoordinates.kt
M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/BottomSheetScaffoldTest.kt
M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/MaterialTextSelectionColorsScreenshotTest.kt
M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/ScaffoldTest.kt
M compose/ui/ui-test/src/androidMain/kotlin/androidx/compose/ui/test/AndroidAssertions.android.kt
M compose/ui/ui-test/src/androidMain/kotlin/androidx/compose/ui/test/AndroidInputDispatcher.android.kt
M compose/ui/ui-test/src/commonMain/kotlin/androidx/compose/ui/test/Actions.kt
M compose/ui/ui-test/src/commonMain/kotlin/androidx/compose/ui/test/GestureScope.kt
M compose/ui/ui-test/src/commonMain/kotlin/androidx/compose/ui/test/Output.kt
M compose/ui/ui/api/current.txt
M compose/ui/ui/api/public_plus_experimental_current.txt
M compose/ui/ui/api/restricted_current.txt
M compose/ui/ui/integration-tests/ui-demos/src/main/java/androidx/compose/ui/demos/autofill/ExplicitAutofillTypesDemo.kt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/AccessibilityIteratorsTest.kt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/AndroidAccessibilityTest.kt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/input/pointer/AndroidPointerInputTest.kt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/input/pointer/HitPathTrackerTest.kt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/input/pointer/MotionEventAdapterTest.kt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/input/pointer/PointerInputEventProcessorTest.kt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/input/pointer/PointerInteropFilterTest.kt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/input/pointer/TestUtils.kt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/layout/OnGloballyPositionedTest.kt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/node/ModelReadsTest.kt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/window/PopupDismissTest.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/input/pointer/MotionEventAdapter.android.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/AccessibilityIterators.android.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/AndroidComposeView.android.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/AndroidComposeViewAccessibilityDelegateCompat.android.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/input/pointer/HitPathTracker.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/input/pointer/InternalPointerInput.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/input/pointer/PointerEvent.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/input/pointer/PointerInputEventProcessor.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/layout/LayoutCoordinates.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/DelegatingLayoutNodeWrapper.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/InnerPlaceable.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/LayoutNode.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/LayoutNodeWrapper.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/Owner.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/PointerInputDelegatingWrapper.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/semantics/SemanticsNode.kt
M compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/input/pointer/PointerInputEvent.desktop.kt
M compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/platform/DesktopOwner.desktop.kt
M compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/platform/DesktopOwners.desktop.kt
M compose/ui/ui/src/test/kotlin/androidx/compose/ui/node/LayoutNodeTest.kt

https://android-review.googlesource.com/1562116

an...@google.com <an...@google.com> Feb 11, 2021 12:52AM

Marked as fixed.

la...@gmail.com <la...@gmail.com> #18Feb 25, 2021 11:44PM

Hi,

What is the target release for this fix? After upgrading to the latest versions, I can still repro the issue (please cf. the newly attached BubbleCompose.zip).

Android Studio 2020.3.1 Canary 8 Jetpack Compose 1.0.0-beta01 Android Emulator 30.5.0, API 30

BubbleCompose.zip

904 KB

Download

mo...@google.com <mo...@google.com> #19Feb 25, 2021 11:48PM

Status: Assigned (reopened)

This should be fixed in beta.

la...@gmail.com <la...@gmail.com> #20Mar 16, 2021 06:29PM

Hi, I can still repro the issue with the Feb 25 BubbleCompose.zip, after upgrading to Android Studio 2020.3.1 Canary 10, Jetpack Compose 1.0.0-beta02, Android Emulator 30.5.2, API 30

mo...@google.com <mo...@google.com> #21Apr 1, 2021 11:25PM

I'm able to reproduce this with the Feb 25 BubbleCompose.zip

mo...@google.com <mo...@google.com> #22Apr 2, 2021 08:36PM

The source of the bug appears to be that getLocationOnScreen() is returning (0, 0) for the window containing the bubble contents. I think I'll have to work around the bug.

ap...@google.com <ap...@google.com> #23Apr 13, 2021 05:21PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 03b281a865ebeba81087864dbccc4476ec071dc4
Author: George Mount <mount@google.com>
Date: Fri Apr 02 23:53:03 2021

Fix problem with pointer input having a bad position.

Fixes: 169874631

In some circumstances, getLocationOnScreen() can return an invalid
result during pointer input dispatching. This CL uses the motion
event's raw position and position in the view to determine the
window position. It also calculates the view matrix once and caches
it so that it won't have to be calculated multiple times during
pointer input dispatch.

Test: ran breaking application.
Change-Id: Ic99fc8b4628b92d79f76da6e46363cebbd95ee4f

M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/input/pointer/AndroidPointerInputTest.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/input/pointer/MotionEventAdapter.android.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/AndroidComposeView.android.kt

https://android-review.googlesource.com/1663129

ap...@google.com <ap...@google.com> #24Apr 16, 2021 05:05PM

Project: platform/frameworks/support
Branch: androidx-main

commit 991ec6d090dfc0c088803dfa972e9570e6dbd577
Author: George Mount <mount@google.com>
Date: Wed Apr 14 17:51:56 2021

Fix problem with window having a scroll position.

Fixes: 169804790
Bug: 169874631

It turns out that the problem with

b/169874631

was not an error
in getLocationOnScreen(), but just that the window had a scrolled
content. This CL fixes the problem by properly retrieving the
position, including the scroll position of the window.

Also changed cache check to use animation time instead of
drawing time because the view may not draw on every frame
that can have the position changed.

Test: new tests, bubble test, text handles demo
Change-Id: Id907e4dc5d134debc9260fff8c09ced9e7a7a754

M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/window/PositionInWindowTest.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/AndroidComposeView.android.kt

https://android-review.googlesource.com/1676847

la...@gmail.com <la...@gmail.com> #25Jun 15, 2021 12:35AM

Unfortunately this issue is still not fixed in the BubbleCompose.zip project after bumping to the latest versions.

Compose 1.0.0-beta08 androidx.activity:activity-compose:1.3.0-beta01

mo...@google.com <mo...@google.com> #26Jun 15, 2021 03:12PM

Status: Assigned (reopened)

How does this keep not being fixed?!!?

mo...@google.com <mo...@google.com> #27Jun 15, 2021 07:14PM

I verified that this is broken again. I think that every time I fix this, something else is broken and it gets changed again. It is difficult to get unit tests to identify this particular problem.

mo...@google.com <mo...@google.com> #28Jun 15, 2021 08:34PM

It appears that the fix in comment #23 was right. When I use getLocationOnScreen() for the AndroidComposeView, I'm seeing (0, 0), which is incorrect. This is not a problem with scroll position as getLocationOnScreen() should be considering this.

I'll restore the fix for #23 to see if that fixes the issue (again).

ap...@google.com <ap...@google.com> #29Jun 18, 2021 06:29PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 9a9f6ab21c3f71bc2b20261ecb824bbd34472014
Author: George Mount <mount@google.com>
Date: Wed Jun 16 18:25:04 2021

Use MotionEvent for window position during touch events

Fixes: 169874631

In some special circumstances getLocationOnScreen() does
not properly retrieve the position. We can compensate for
it by using the MotionEvent raw coordinates in comparison
with their positions to determine the real window position.

Test: new test, manual testing using BubbleCompose
Change-Id: I2a19717f0e602b88f5445541fdf59ca82b1aa474

M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/input/pointer/AndroidPointerInputTest.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/AndroidComposeView.android.kt

https://android-review.googlesource.com/1738593

la...@gmail.com <la...@gmail.com> #30Jul 2, 2021 09:41PM

Confirmed fixed in Compose 1.0.0-rc01. Thank you!

Issue 169874631

Description

Issue summary

Comments

an...@google.com <an...@google.com> Oct 2, 2020 02:48PM

sh...@google.com <sh...@google.com> #2Oct 15, 2020 09:58PM

la...@gmail.com <la...@gmail.com> #3Oct 17, 2020 05:51AM

la...@gmail.com <la...@gmail.com> #4Dec 6, 2020 12:40AM

so...@google.com <so...@google.com> Dec 7, 2020 11:51AM

mo...@google.com <mo...@google.com> #5Jan 11, 2021 09:32PM

mo...@google.com <mo...@google.com> #6Jan 15, 2021 09:34PM

la...@gmail.com <la...@gmail.com> #7Jan 15, 2021 10:10PM

mo...@google.com <mo...@google.com> #8Jan 15, 2021 10:51PM

tc...@google.com <tc...@google.com> #9Jan 21, 2021 07:43PM

mo...@google.com <mo...@google.com> #10Jan 21, 2021 11:13PM

mo...@google.com <mo...@google.com> #11Jan 21, 2021 11:13PM

la...@gmail.com <la...@gmail.com> #12Jan 22, 2021 05:54AM

mo...@google.com <mo...@google.com> #13Jan 22, 2021 04:37PM

mo...@google.com <mo...@google.com> #14Jan 22, 2021 05:04PM

mo...@google.com <mo...@google.com> #15Jan 22, 2021 07:18PM

tc...@google.com <tc...@google.com> #16Feb 5, 2021 10:02PM

ap...@google.com <ap...@google.com> #17Feb 11, 2021 12:41AM

an...@google.com <an...@google.com> Feb 11, 2021 12:52AM

la...@gmail.com <la...@gmail.com> #18Feb 25, 2021 11:44PM

mo...@google.com <mo...@google.com> #19Feb 25, 2021 11:48PM

la...@gmail.com <la...@gmail.com> #20Mar 16, 2021 06:29PM

mo...@google.com <mo...@google.com> #21Apr 1, 2021 11:25PM

mo...@google.com <mo...@google.com> #22Apr 2, 2021 08:36PM

ap...@google.com <ap...@google.com> #23Apr 13, 2021 05:21PM

ap...@google.com <ap...@google.com> #24Apr 16, 2021 05:05PM

la...@gmail.com <la...@gmail.com> #25Jun 15, 2021 12:35AM

mo...@google.com <mo...@google.com> #26Jun 15, 2021 03:12PM

mo...@google.com <mo...@google.com> #27Jun 15, 2021 07:14PM

mo...@google.com <mo...@google.com> #28Jun 15, 2021 08:34PM

ap...@google.com <ap...@google.com> #29Jun 18, 2021 06:29PM

la...@gmail.com <la...@gmail.com> #30Jul 2, 2021 09:41PM

Add comment

Issue metadata