Starting a postponed transition instantly cancels the enter transition [170022857]

Fixed

Bug

Status Update

No update yet.

Description

[Deleted User]

created issue #1

Oct 4, 2020 07:31PM

Component used: Fragment
Version used: 1.3.0-beta01
Devices/Android versions reproduced on: Google Pixel 4 XL

There are some key components here:

It only happens if you are using Fragments 1.3
It only happens if you are using androidx.transition 1.4 (not 1.2)
It only happens if you call startPostponedEnterTransition instantly after postponing

The effect is really noticeable when using the MDC transitions since they are currently not handling cancelations gracefully so it leaves the target view with alpha 0.

One fix is to always wait calling startPostponedEnterTransition at least one frame by posting to a handler or using yield() with Coroutines.

You may wonder why I'm calling start instantly and it's because the data is cached:

postponeEnterTransition(500, TimeUnit.MILLISECONDS)
viewLifecycleOwner.lifecycleScope.launch {
    // Imagine that loadData() does not suspend because the data is cached
    val data = loadData()
    setupViews(data)
    // Uncommenting this will mitigate the issue
    // yield()
    startPostponedEnterTransition()
}

broken-with-postpone.mp4

68 KB

Download

working-without-postpone.mp4

294 KB

Download

TestFragmentTransitions.zip

145 KB

Download

Comments

jb...@google.com <jb...@google.com> Oct 5, 2020 06:20PM

Assigned to jb...@google.com.

ap...@google.com <ap...@google.com> #2Nov 20, 2020 08:14PM

Project: platform/frameworks/support
Branch: androidx-main

commit 53d7e9505dce7026e7c92059d42e5de784739106
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Mon Dec 06 16:26:25 2021

Avoid nullable boolean in constraint trackers

Now instead of returning null, trackers work pessimistically,
e.g. BatteryChargingTracker says that battery isn't charging.

It is done in preparation for Kotlin migration, where
this code smell is more apparent.

bug: 209145335
Test: *TrackerTest were updated
Change-Id: Ie1dcbe8961d925784d5633a297307993f3b8a43b

M work/work-runtime/src/androidTest/java/androidx/work/impl/constraints/trackers/ConstraintTrackerTest.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/ConstraintListener.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/constraints/trackers/StorageNotLowTrackerTest.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/constraints/trackers/BatteryChargingTrackerTest.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/trackers/BatteryNotLowTracker.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/controllers/ConstraintController.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/constraints/trackers/BatteryNotLowTrackerTest.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/trackers/BatteryChargingTracker.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/trackers/StorageNotLowTracker.java

https://android-review.googlesource.com/1911432

jb...@google.com <jb...@google.com> #3Nov 20, 2020 09:36PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 37b6a3fbb83456e319412c81f5039ffede5571c1
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Sat Dec 04 17:33:19 2021

Bump room 2.4.0-rc01

bug: 209145335
Test: refactoring
Change-Id: I29efb1b5a2e49ceddae999ed244803889723b080

M work/work-runtime/build.gradle
M work/work-runtime-ktx/build.gradle
M work/work-inspection/build.gradle
M work/work-gcm/build.gradle
M work/work-multiprocess/build.gradle
M work/work-benchmark/build.gradle
M work/work-testing/build.gradle
M work/integration-tests/testapp/build.gradle

https://android-review.googlesource.com/1910055

Issue 170022857

Description

Issue summary

Comments

jb...@google.com <jb...@google.com> Oct 5, 2020 06:20PM

ap...@google.com <ap...@google.com> #2Nov 20, 2020 08:14PM

jb...@google.com <jb...@google.com> #3Nov 20, 2020 09:36PM

Add comment

Issue metadata