Feature Request: Add RxJava2/3 wrappers for DataStore [170311106]

Fixed

Bug

Status Update

No update yet.

Description

ro...@google.com

created issue #1

Oct 7, 2020 04:59PM

Add RxJava Wrappers for DataStore

Comments

ap...@google.com <ap...@google.com> #2Nov 23, 2020 07:13PM

With the change of lifecycle-common to KMP, we might be able to just move this into the right spot (since it'll mirror the same structure as lifecycle-runtime, which does work).

ap...@google.com <ap...@google.com> #3Nov 23, 2020 11:29PM

lifecycle-common even after conversion to KMP is still a jar. We do not want to change that to an AAR as that is a breaking change for consumers, so i dont think we can make it work this project.

ap...@google.com <ap...@google.com> #4Dec 3, 2020 11:31PM

Ah yeah good point.

ap...@google.com <ap...@google.com> #5Dec 4, 2020 06:47AM

Project: platform/frameworks/support
Branch: androidx-main

commit a00e293b59bdbe5746941171fe793b863aaafabe
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Thu Apr 11 15:42:42 2024

Move baseline-prof.txt from Lifecycle common to runtime

* Move `baseline-prof.txt` from `lifecycle-common` to `lifecycle-runtime`;
* Because there are multiple files now in `lifecycle-runtime`, group them inside a `baselineProfiles` folder.
* Rename the files to match what modules they target.

Test: N/A
Fixes: 322382422
Change-Id: Iaced653d78e6fe6c107e389ed76cd3ca37e46347

D lifecycle/lifecycle-common/src/jvmMain/baseline-prof.txt
M lifecycle/lifecycle-runtime/build.gradle
M lifecycle/lifecycle-runtime/src/androidMain/baseline-prof.txt

https://android-review.googlesource.com/3038274

ap...@google.com <ap...@google.com> #6Dec 16, 2020 09:14PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 842f0818490cd3f31806c13bd2c0db681ac67e46
Author: rohitsat13 <rohitsat@google.com>
Date: Fri Dec 11 11:30:24 2020

Split preferencesKey<T> into individual types, e.g. intPreferencesKey, longPreferencesKey, etc.

Test: PreferencesFromJavaTest
Relnote: """ The preferencesKey<T>(name: String): Key<T> method has been removed and replaced with methods specific to each supported type, for example preferencesKey<Int>("int") is now preferencesIntKey("int") """
Bug: 170311106
Change-Id: Ibcfac9cca7c8a3dbf2eaae17bdb8c22a8ce5a9f7

M datastore/datastore-preferences-core/api/current.txt
M datastore/datastore-preferences-core/api/public_plus_experimental_current.txt
M datastore/datastore-preferences-core/api/restricted_current.txt
M datastore/datastore-preferences-core/src/main/java/androidx/datastore/preferences/core/Preferences.kt
A datastore/datastore-preferences-core/src/main/java/androidx/datastore/preferences/core/PreferencesFactory.kt
A datastore/datastore-preferences-core/src/main/java/androidx/datastore/preferences/core/PreferencesKeys.kt
M datastore/datastore-preferences-core/src/main/java/androidx/datastore/preferences/core/PreferencesSerializer.kt
M datastore/datastore-preferences-core/src/test/java/androidx/datastore/preferences/core/PreferenceDataStoreFactoryTest.kt
A datastore/datastore-preferences-core/src/test/java/androidx/datastore/preferences/core/PreferencesFromJavaTest.java
M datastore/datastore-preferences-core/src/test/java/androidx/datastore/preferences/core/PreferencesSerializerTest.kt
M datastore/datastore-preferences-core/src/test/java/androidx/datastore/preferences/core/PreferencesTest.kt
M datastore/datastore-preferences/src/androidTest/java/androidx/datastore/preferences/PreferenceDataStoreFactoryTest.kt
M datastore/datastore-preferences/src/androidTest/java/androidx/datastore/preferences/SharedPreferencesToPreferencesTest.kt
M datastore/datastore-preferences/src/main/java/androidx/datastore/preferences/SharedPreferencesMigration.kt
M datastore/datastore-sampleapp/src/main/java/com/example/datastoresampleapp/PreferencesDataStoreActivity.kt

https://android-review.googlesource.com/1526348

ap...@google.com <ap...@google.com> #7Dec 30, 2020 06:04AM

Project: platform/frameworks/support
Branch: androidx-main

commit 431cd63a24c2b35a543f5b6fda6ec5e088d06b3c
Author: rohitsat13 <rohitsat@google.com>
Date: Mon Dec 21 11:42:56 2020

Added datastore-rxjava3 and datastore-preferences-rxjava3.

I just copied the rxjava2 modules and replaced the imports with rxjava3 imports.

Test: Copied over tests from rxjava2 modules.
Relnote: This change adds the datastore-preferences-rxjava2 and datastore-preferences-rxjava3 modules
Bug: 170311106
Change-Id: If253fe05877f22b956cda2e2be27387ae76c9b33

A datastore/datastore-preferences-rxjava3/api/current.txt
A datastore/datastore-preferences-rxjava3/api/public_plus_experimental_current.txt
A datastore/datastore-preferences-rxjava3/api/res-current.txt
A datastore/datastore-preferences-rxjava3/api/restricted_current.txt
A datastore/datastore-preferences-rxjava3/build.gradle
A datastore/datastore-preferences-rxjava3/src/androidTest/java/androidx/datastore/preferences/rxjava3/RxPreferencesDataStoreBuilderTest.java
A datastore/datastore-preferences-rxjava3/src/main/AndroidManifest.xml
A datastore/datastore-preferences-rxjava3/src/main/java/androidx/datastore/preferences/rxjava3/RxPreferenceDataStoreBuilder.kt
A datastore/datastore-rxjava3/api/current.txt
A datastore/datastore-rxjava3/api/public_plus_experimental_current.txt
A datastore/datastore-rxjava3/api/res-current.txt
A datastore/datastore-rxjava3/api/restricted_current.txt
A datastore/datastore-rxjava3/build.gradle
A datastore/datastore-rxjava3/src/androidTest/AndroidManifest.xml
A datastore/datastore-rxjava3/src/androidTest/java/androidx/datastore/rxjava3/RxDataStoreBuilderTest.java
A datastore/datastore-rxjava3/src/androidTest/java/androidx/datastore/rxjava3/RxSharedPreferencesMigrationTest.java
A datastore/datastore-rxjava3/src/main/AndroidManifest.xml
A datastore/datastore-rxjava3/src/main/java/androidx/datastore/rxjava3/RxDataMigration.java
A datastore/datastore-rxjava3/src/main/java/androidx/datastore/rxjava3/RxDataStore.kt
A datastore/datastore-rxjava3/src/main/java/androidx/datastore/rxjava3/RxDataStoreBuilder.kt
A datastore/datastore-rxjava3/src/main/java/androidx/datastore/rxjava3/RxSharedPreferencesMigration.kt
A datastore/datastore-rxjava3/src/test-common/java/androidx/datastore/rxjava3/TestingSerializer.kt
A datastore/datastore-rxjava3/src/test/java/androidx/datastore/rxjava3/RxDataStoreTest.java
M settings.gradle

https://android-review.googlesource.com/1532596

ap...@google.com <ap...@google.com> #8Dec 30, 2020 06:04AM

Project: platform/frameworks/support
Branch: androidx-main

commit 4767533679a08261b7f5db398ea9b8cab13f4257
Author: rohitsat13 <rohitsat@google.com>
Date: Mon Nov 23 15:53:12 2020

Add datastore-preferences-rxjava2 module so people can build and use Preferences DataStore from java.

Test: Added tests for builder and RxPreferences
RelNote: Added RxPreferences so people can create Preferences keys from java and added RxPreferenceDataStoreBuilder so people can easily construct DataStore<Preferences>.
Bug: 170311106
Change-Id: I6b46555d67bf6bb61800b3fad0a7c27b72183ade

A datastore/datastore-preferences-rxjava2/api/current.txt
A datastore/datastore-preferences-rxjava2/api/public_plus_experimental_current.txt
A datastore/datastore-preferences-rxjava2/api/res-current.txt
A datastore/datastore-preferences-rxjava2/api/restricted_current.txt
A datastore/datastore-preferences-rxjava2/build.gradle
A datastore/datastore-preferences-rxjava2/src/androidTest/java/androidx/datastore/preferences/rxjava2/RxPreferencesDataStoreBuilderTest.java
A datastore/datastore-preferences-rxjava2/src/main/AndroidManifest.xml
A datastore/datastore-preferences-rxjava2/src/main/java/androidx/datastore/preferences/rxjava2/RxPreferenceDataStoreBuilder.kt
D datastore/datastore-rxjava2/src/androidTest/java/androidx/datastore/rxjava2/AssertThrows.kt
M settings.gradle

https://android-review.googlesource.com/1530641

ro...@google.com <ro...@google.com> Jan 6, 2021 11:38PM

Marked as fixed.

ni...@google.com <ni...@google.com> #9Jan 14, 2021 12:59AM

These extensions are now available in 1.0.0-alpha06! https://developer.android.com/jetpack/androidx/releases/datastore#1.0.0-alpha06