AndroidView not receiving proper touch events [170320973]

Fixed

Bug

Status Update

No update yet.

Description

[Deleted User]

created issue #1

Oct 7, 2020 06:48PM

Jetpack Compose release version: 1.0.0-alpha04

I have the following view:

AndroidView(
    viewBlock = { context ->
        // RangeSlider is from Material Design Components
        RangeSlider(context).apply {
            val formatter = DecimalFormat("0.0mm")
            setLabelFormatter { value ->
                formatter.format(value.toDouble() / 10)
            }
            valueFrom = 1f
            valueTo = 100f
            stepSize = 1f
            addOnChangeListener { slider, _, fromUser ->
                if (fromUser) {
                    ...
                }
            }
        }
    },
    update = { slider ->
        slider.setValues(10f, 90f)
    }
)

But when I try to interact with the slider nothing happens. The slider works fine outside of Compose.

When doing some quick debugging (on alpha 3 however) I noticed the touch events that the RangeSlider receives looks something like this:

ACTION_CANCEL
ACTION_DOWN
ACTION_MOVE
ACTION_CANCEL

Which would explain why it wasn't working but I don't know why it doesn't receive the touch events correctly.

Comments

ma...@google.com <ma...@google.com> #2Oct 8, 2020 09:13AM

Assigned to sh...@google.com.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019

Change the way to detect mismatch between POJO and query

This fixes cursor mismatch warnings with expandProjection.

Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8

M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt

https://android-review.googlesource.com/1123258

https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1

sh...@google.com <sh...@google.com> #3Oct 8, 2020 08:44PM

Accepted by sh...@google.com.

The following changes were cherrypicked through Coastguard (

https://android-build.googleplex.com/coastguard/)
Release Track: (

https://android-build.googleplex.com/coastguard/dashboard/6093116828680192/#/cherrypickHistory/all)
Created: 2019-10-14 17:23:42.610596+00:00
Changes: aosp/1123258

ap...@google.com <ap...@google.com> #4Oct 13, 2020 10:14PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020

Re-factor how errors are dismissed when query is re-written

This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (

b/140759491

).
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.

This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.

Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f

M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt

https://android-review.googlesource.com/1288456

Issue 170320973

Description

Issue summary

Comments

ma...@google.com <ma...@google.com> #2Oct 8, 2020 09:13AM

sh...@google.com <sh...@google.com> #3Oct 8, 2020 08:44PM

ap...@google.com <ap...@google.com> #4Oct 13, 2020 10:14PM

Add comment

Issue metadata