Fixed
Status Update
Comments
il...@google.com <il...@google.com>
da...@gmail.com <da...@gmail.com> #2
Project: platform/frameworks/support
Branch: androidx-main
commit 57ca221882695bd6a52549f4d9ea3b812e6fe87c
Author: Simon Schiller <simonschiller@users.noreply.github.com>
Date: Mon Mar 22 16:09:30 2021
[GH] [FragmentStrictMode] Detect <fragment> tag usage
## Proposed Changes
- Detect `<fragment>` tag usage inside XML layouts
## Testing
Test: See `FragmentStrictModeTest#detectFragmentTagUsage`
## Issues Fixed
Fixes: 153738235
This is an imported pull request fromhttps://github.com/androidx/androidx/pull/141 .
Resolves #141
Github-Pr-Head-Sha: 4ea052596e4341b9f11bcf335e2bc38045a91f19
GitOrigin-RevId: 62e7487aa4874eef6bb556490e193717cf937251
Change-Id: Iae48578e85e4e4897f806d7ade2e2a660adf9479
M fragment/fragment/api/public_plus_experimental_current.txt
M fragment/fragment/api/restricted_current.txt
M fragment/fragment/src/androidTest/java/androidx/fragment/app/strictmode/FragmentStrictModeTest.kt
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentLayoutInflaterFactory.java
M fragment/fragment/src/main/java/androidx/fragment/app/strictmode/FragmentStrictMode.java
A fragment/fragment/src/main/java/androidx/fragment/app/strictmode/FragmentTagUsageViolation.java
https://android-review.googlesource.com/1649748
Branch: androidx-main
commit 57ca221882695bd6a52549f4d9ea3b812e6fe87c
Author: Simon Schiller <simonschiller@users.noreply.github.com>
Date: Mon Mar 22 16:09:30 2021
[GH] [FragmentStrictMode] Detect <fragment> tag usage
## Proposed Changes
- Detect `<fragment>` tag usage inside XML layouts
## Testing
Test: See `FragmentStrictModeTest#detectFragmentTagUsage`
## Issues Fixed
Fixes: 153738235
This is an imported pull request from
Resolves #141
Github-Pr-Head-Sha: 4ea052596e4341b9f11bcf335e2bc38045a91f19
GitOrigin-RevId: 62e7487aa4874eef6bb556490e193717cf937251
Change-Id: Iae48578e85e4e4897f806d7ade2e2a660adf9479
M fragment/fragment/api/public_plus_experimental_current.txt
M fragment/fragment/api/restricted_current.txt
M fragment/fragment/src/androidTest/java/androidx/fragment/app/strictmode/FragmentStrictModeTest.kt
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentLayoutInflaterFactory.java
M fragment/fragment/src/main/java/androidx/fragment/app/strictmode/FragmentStrictMode.java
A fragment/fragment/src/main/java/androidx/fragment/app/strictmode/FragmentTagUsageViolation.java
ap...@google.com <ap...@google.com> #3
Project: platform/frameworks/support
Branch: androidx-master-dev
commit e0e7d20aa718593fcc3be260f9cded0a6464ec28
Author: Jeremy Woods <jbwoods@google.com>
Date: Tue Dec 01 08:47:03 2020
Fix improper animations after pop
When combining pop and replace operations in the same fragment
transaction and using the new state manager, the fragment in the
transaction being popped does not have a view and therefore its
animation is ignored.
We should ensure we consider any animations that are available, even if
the fragment has no view.
RelNote: "Combining pop and replace operations in the same fragment
transaction will now show the proper animations"
Test: removingFragmentAnimationChange
Bug: 170328691
Change-Id: Ifd4e49cd9874a9ac0673083c27ef3c9765bbfa04
M fragment/fragment/src/androidTest/java/androidx/fragment/app/FragmentAnimationTest.kt
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentManager.java
https://android-review.googlesource.com/1515043
Branch: androidx-master-dev
commit e0e7d20aa718593fcc3be260f9cded0a6464ec28
Author: Jeremy Woods <jbwoods@google.com>
Date: Tue Dec 01 08:47:03 2020
Fix improper animations after pop
When combining pop and replace operations in the same fragment
transaction and using the new state manager, the fragment in the
transaction being popped does not have a view and therefore its
animation is ignored.
We should ensure we consider any animations that are available, even if
the fragment has no view.
RelNote: "Combining pop and replace operations in the same fragment
transaction will now show the proper animations"
Test: removingFragmentAnimationChange
Bug: 170328691
Change-Id: Ifd4e49cd9874a9ac0673083c27ef3c9765bbfa04
M fragment/fragment/src/androidTest/java/androidx/fragment/app/FragmentAnimationTest.kt
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentManager.java
jb...@google.com <jb...@google.com> #4
This has been fixed internally and will be available in the next Fragment release.
Description
Component used: Fragment Version used: 1.3.0-beta01
The videos attached show the behavior of the app when built using version 1.2.5 and 1.3.0-beta01.
I tried the SNAPSHOT (6890032) version, but the issue is still there.