Authenticators backport is broken on an API 29 Pixel 4 [170406186]

Fixed

Bug

Status Update

No update yet.

Description

ph...@monzo.com

created issue #1

Oct 9, 2020 09:43AM

On an API 29 Pixel 4 androidx.biometric.BiometricManager#canAuthenticate(Authenticators.BIOMETRIC_STRONG) returns BIOMETRIC_STATUS_UNKNOWN. I believe this is because the canAuthenticate(CryptoObject) method only works on Samsung devices - as far as I can tell it has never existed in AOSP.

Some possible solutions (there may well be reasons not to do these things):

Adding non-Samsung devices with strong face unlock to the assume_strong_biometrics_prefixes array, which is currently empty. Devices with fingerprint should be OK because they fall back to canAuthenticateWithFingerprintOrUnknown(), but I haven't actually tested this.
Attempt to create an auth-per-use key pair (setUserAuthenticationValidityDurationSeconds(-1)) in AndroidKeyStore, which fails with the following exception if the user doesn't have strong biometrics available & enrolled (I don't know if this is reliable across OEMs and API versions):

java.security.InvalidAlgorithmParameterException: java.lang.IllegalStateException: At least one biometric must be enrolled to create keys requiring user authentication for every use
        at android.security.keystore.AndroidKeyStoreKeyPairGeneratorSpi.initialize(AndroidKeyStoreKeyPairGeneratorSpi.java:349)
        at java.security.KeyPairGenerator$Delegate.initialize(KeyPairGenerator.java:697)
        at java.security.KeyPairGenerator.initialize(KeyPairGenerator.java:438)
        ...

BUILD INFO

Device type: Pixel 4
OS version: 10 (API 29)
Biometric library version: 1.1.0-beta01

STEPS TO REPRODUCE

Have API 29 Pixel 4 with face unlock turned on.
Call androidx.biometric.BiometricManager#canAuthenticate(Authenticators.BIOMETRIC_STRONG)

EXPECTED RESULTS

Receive BIOMETRIC_SUCCESS.

OBSERVED RESULTS

Receive BIOMETRIC_STATUS_UNKNOWN.

NUMBER OF TIMES YOU WERE ABLE TO REPRODUCE (e.g. 3/10)

10/10

Comments

ph...@monzo.com <ph...@monzo.com> #2Oct 9, 2020 04:01PM

Project: platform/frameworks/support
Branch: androidx-main

commit c46d3e79b2ea8b839358f0215b0a432ef8fad7a2
Author: Clara Fok <clarafok@google.com>
Date: Fri Nov 04 15:23:25 2022

Convert androidx.activity.Cancellable to kotlin

Test: ./gradlew activity:activity:cC
Bug: 257291701
Change-Id: I057f3e54811e7399e40083ef5e3915adc4fa425d

M activity/activity/src/main/java/androidx/activity/Cancellable.kt

https://android-review.googlesource.com/2288554

cu...@google.com <cu...@google.com> Oct 19, 2020 05:15PM

Reassigned to cu...@google.com.

cu...@google.com <cu...@google.com> Oct 21, 2020 12:25AM

Accepted by cu...@google.com.

ap...@google.com <ap...@google.com> #3Oct 21, 2020 08:33PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 7fd8a3206a49baefee8340f0839fcd4de7716788
Author: Clara Fok <clarafok@google.com>
Date: Fri Nov 04 15:13:23 2022

Rename androidx.activity.Cancellable from .java to .kt

Test: n/a
Bug:257291701
Change-Id: I7f2ff8ce79af41c6437fb9a0f1be90e8990495e8

M activity/activity/src/main/java/androidx/activity/Cancellable.kt

https://android-review.googlesource.com/2288553

ph...@monzo.com <ph...@monzo.com> #4Oct 23, 2020 08:17AM

Project: platform/frameworks/support
Branch: androidx-main

commit 4d21e0a45f19ed238ef30756f576930af07449c2
Author: Clara Fok <clarafok@google.com>
Date: Fri Nov 04 13:25:08 2022

Convert ActivityResultCallback to kotlin

Including clean up in test usages of this interface

Test: ./gradlew activity:activity:cC
Bug: 257291701
Relnote: Converted ActvitiyResultCallback to kotlin. Maintains source and binary comptability.
Change-Id: Ifc5e5e1a9a7ed4e281007830fb8d4c74237c63ce

M activity/activity/api/current.txt
M activity/activity/api/public_plus_experimental_current.txt
M activity/activity/api/restricted_current.txt
M activity/activity/src/androidTest/java/androidx/activity/result/ActivityResultRegistryTest.kt
M activity/activity/src/main/java/androidx/activity/result/ActivityResultCallback.kt

https://android-review.googlesource.com/2288334

[Deleted User] <[Deleted User]> #5Dec 20, 2020 02:23PM

Project: platform/frameworks/support
Branch: androidx-main

commit ae5bcbc9174b9767f143bfd9629a69fcd3ed325d
Author: Clara Fok <clarafok@google.com>
Date: Fri Nov 04 13:06:36 2022

Rename ActivityResultCallback from .java to .kt

Test: n/a
Bug: 257291701
Change-Id: I43a8c76cb51e3eee4a1ec2cb6f0128753d85965d

M activity/activity/src/main/java/androidx/activity/result/ActivityResultCallback.kt

https://android-review.googlesource.com/2288333

re...@infinum.com <re...@infinum.com> #6Jan 7, 2021 10:16AM

Project: platform/frameworks/support
Branch: androidx-main

commit 91f60f5adb619fc0a2ddc866c94670a2f046799a
Author: Clara Fok <clarafok@google.com>
Date: Fri Nov 04 16:59:43 2022

Convert OnBackPressedCallback to kotlin

Test: ./gradlew activity:activity:cC
Bug: 257291701
Relnote: OnBackPressedCallback is now in Kotlin
Change-Id: Ide1b056e438b403c9b1888bc7dfedf283f1ff168

M activity/activity/api/current.txt
M activity/activity/api/public_plus_experimental_current.txt
M activity/activity/api/restricted_current.txt
M activity/activity/src/main/java/androidx/activity/OnBackPressedCallback.kt

https://android-review.googlesource.com/2288079

re...@infinum.com <re...@infinum.com> #7Jan 7, 2021 10:18AM

Project: platform/frameworks/support
Branch: androidx-main

commit 324a9ebeb0c23ca0113a925c83a4b90a74c7dc54
Author: Clara Fok <clarafok@google.com>
Date: Fri Nov 04 15:57:01 2022

Rename OnBackPressedCallback from .java to .kt

Test: n/a
Bug: 257291701
Change-Id: I3645ebd21c0ea9c243fad3007bdd3d2472806dcc

M activity/activity/src/main/java/androidx/activity/OnBackPressedCallback.kt

https://android-review.googlesource.com/2288078