Feature Request: MutableVector should implement RandomAccess [170461551]

Fixed

Bug

Status Update

No update yet.

Description

[Deleted User]

created issue #1

Oct 9, 2020 07:20PM

Jetpack Compose release version: 1.0.0-alpha04

We have some internal utils that check for RandomAccess which isn't hit so we allocate an iterator instead. I don't see a reason why MutableVector should not implement `RandomAccess.

Comments

cl...@google.com <cl...@google.com> Oct 12, 2020 04:00PM

Assigned to mo...@google.com.

mo...@google.com <mo...@google.com> #2Oct 12, 2020 06:22PM

Project: platform/frameworks/support
Branch: androidx-main

commit 700259f0afe267dfe78b93db932a3cfd827a119d
Author: Sherry Hu <shuanghu@google.com>
Date: Mon May 10 14:23:09 2021

Add transition motion between fold and unfold.

Bug: 186211031
Test: manual
Change-Id: Id60f07311eca2d94ef91dc28ae45823a475160b4

M slidingpanelayout/slidingpanelayout/build.gradle
M slidingpanelayout/slidingpanelayout/src/androidTest/java/androidx/slidingpanelayout/widget/FoldTest.kt
M slidingpanelayout/slidingpanelayout/src/main/java/androidx/slidingpanelayout/widget/SlidingPaneLayout.java

https://android-review.googlesource.com/1702066

[Deleted User] <[Deleted User]> #3Oct 12, 2020 06:26PM

It wouldn't make any difference by itself since it's just a marker interface but any code that checks for the marker interface would likely switch to a more optimized implementation.

mo...@google.com <mo...@google.com> #4Oct 12, 2020 07:03PM

Accepted by mo...@google.com.

out for review: https://android-review.googlesource.com/c/platform/frameworks/support/+/1457518

I tested, just to be sure and it doesn't affect performance.

ap...@google.com <ap...@google.com> #5Oct 16, 2020 07:13PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit de8d90deb96cce240c9eea7eae2779e22e2748b0
Author: George Mount <mount@google.com>
Date: Mon Oct 12 11:54:37 2020

Have MutableVector implement RandomAccess

Relnote: "MutableVector now implements RandomAccess"
Fixes: 170461551
Test: MutableVectorBenchmark
Change-Id: I85d73f55b19cce31ba70770dbd0dc98cb3a6957a

M compose/runtime/runtime/api/current.txt
M compose/runtime/runtime/api/public_plus_experimental_current.txt
M compose/runtime/runtime/api/restricted_current.txt
M compose/runtime/runtime/src/commonMain/kotlin/androidx/compose/runtime/collection/MutableVector.kt

https://android-review.googlesource.com/1457518

Issue 170461551