hasGlyph performance [170587912]

Fixed

Bug

Status Update

No update yet.

Description

si...@google.com

created issue #1

Oct 12, 2020 02:06AM

We had reports that EmojiProcessor.hasGlyph is rather heavy on API 23+ despite the cache where each emoji is checked for rendering only once for each EmojiCompat instance.

Investigate the culprit.

Comments

si...@google.com <si...@google.com> #2Oct 12, 2020 02:24AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

no...@google.com <no...@google.com> #3Oct 12, 2020 02:40AM

What string are you querying?

There are shortcut of single code point + variation selector. https://source.corp.google.com/android/frameworks/base/libs/hwui/jni/Paint.cpp;rcl=9b83d2dbb65bb6792e6eb26e0cc5a85a7a7e0194;l=448

Also, if there is no glyph in the Typeface, it is always slow path of the query.

I don't know how EmojiCompat uses hasGlyph APIs but if you querying all emojis (let's say over 1000), maybe it would be good to parse cmap/GSUB table by ourselves. You may still need to hasGlyph API for checking the platform capability though.

si...@google.com <si...@google.com> #4Oct 12, 2020 05:47AM

Hi Nonasan,

Here is the benchmark code I used: https://android-review.googlesource.com/c/platform/frameworks/support/+/1456895

I query random emoji.

I don't know how EmojiCompat uses hasGlyph APIs but if you querying all emojis (let's say over 1000), maybe it would be good to parse cmap/GSUB table by ourselves.

This wouldn't work. I am not interested in the EmojiCompat font, but the platform itself. If we knew that there is only NotoEmoji we might be able to check the system font, but I don't think it is a good idea.

ap...@google.com <ap...@google.com> #5Oct 13, 2020 05:03PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 1b3056f484ecb3b82e300362d42327dce145205a
Author: Siyamed Sinir <siyamed@google.com>
Date: Sun Oct 11 19:25:27 2020

Expose GlyphChecker interface

EmojiCompat.Config accepts GlyphChecker in the API.

Test: Added new tests
Test: ./gradlew emoji:test
Test: ./gradlew emoji:connectedAndroidTest

Relnote: "Added new API `EmojiCompat.Config#setGlyphChecker` that enables developers
to provide custom emoji glyph check behavior."

Bug: 170587912
Change-Id: Ibc95e158765d392cb8726e53b0f8cac7961f0373

M emoji/core/api/current.txt
M emoji/core/api/public_plus_experimental_current.txt
M emoji/core/api/restricted_current.txt
M emoji/core/src/androidTest/java/androidx/emoji/text/ConfigTest.java
M emoji/core/src/androidTest/java/androidx/emoji/text/EmojiCompatTest.java
M emoji/core/src/androidTest/java/androidx/emoji/text/TestConfigBuilder.java
M emoji/core/src/main/java/androidx/emoji/text/EmojiCompat.java
M emoji/core/src/main/java/androidx/emoji/text/EmojiProcessor.java

https://android-review.googlesource.com/1456995

si...@google.com <si...@google.com> Oct 13, 2020 05:04PM

Marked as fixed.

se...@google.com <se...@google.com> #6Jul 22, 2021 05:01PM

Leaving closed, but listing another option for developers reading this thread:

hasGlyph is cached in emojicompat per glyph, so one option would be to process a string containing all emoji in a background thread. This would effectively avoid any calls to hasGlyph to render user-defined strings later.

Issue 170587912