hasGlyph performance [170587912]

Fixed

Bug

Status Update

No update yet.

Description

si...@google.com

created issue #1

Oct 12, 2020 02:06AM

We had reports that EmojiProcessor.hasGlyph is rather heavy on API 23+ despite the cache where each emoji is checked for rendering only once for each EmojiCompat instance.

Investigate the culprit.

Comments

si...@google.com <si...@google.com> #2Oct 12, 2020 02:24AM

Hi. Thanks for reporting this. Fixed in this changelist. This should be available in alpha-04

no...@google.com <no...@google.com> #3Oct 12, 2020 02:40AM

Project: platform/frameworks/support
Branch: androidx-main

commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023

fix: tab row crashes when only 1 tab is added

Bug:

b/264018028

Test: Added unit test

Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f

M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt

https://android-review.googlesource.com/2373449

si...@google.com <si...@google.com> #4Oct 12, 2020 05:47AM

deleted

ap...@google.com <ap...@google.com> #5Oct 13, 2020 05:03PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.tv:tv-material:1.0.0-alpha04

si...@google.com <si...@google.com> Oct 13, 2020 05:04PM

Marked as fixed.

se...@google.com <se...@google.com> #6Jul 22, 2021 05:01PM

Leaving closed, but listing another option for developers reading this thread:

hasGlyph is cached in emojicompat per glyph, so one option would be to process a string containing all emoji in a background thread. This would effectively avoid any calls to hasGlyph to render user-defined strings later.

Issue 170587912