IssueTracker

Are you sure this is obsolete? I don't see a maxLength argument on BasicTextField or anything similar.

oh, i actually missed why I created the issue. maxLength is something that can be done via the TextField callback. however the issue was with providing a default text limit to TextField for mainly performance.

Thanks for the ping, I agree with you now.

Thanks! Yes, I agree that workaround works mostly fine (and it is what we are doing now in our own design system library). However, I think the workaround has one issue (aside from performance)... once the user reaches the max length, the workaround ensures that the display won't render any new characters. However, I believe those keystrokes are still being reported to the InputMethodService because I see the keyboard auto-suggestions briefly updating for a split second. Not completely sure the implications of this on keyboards but worth noting.

This issue is also important for accessibility. When the maximum length is reached, Talkback should automatically announce "Maximum length reached" like it does with views.

BasicTextField2 introduces InputTransformation API that has a prefab maxLengthInChars and maxLengthInCodepoints factory functions. These will correctly update the IME whenever the max length is reached. Current BasicTextField holds 3 states including the hoisted one that does the filtering. Before filtering is committed in the next composition, IME for a brief period of time thinks that every key stroke is accepted by the editor. InputTransformation prevents this by executing the callback at the right time.

Also, thanks for pointing out the maxLength a11y node info property. We will take this into account.

I'm closing this issue since we now ship a prefab InputTransformation.maxLength that also applies MaxTextLength semantics.