Fixed
Status Update
No update yet.
Comments
al...@google.com
bulk comment, fyi: we have added icebox to all the tickets because it was suggested by blintz in order to prevent auto-close tickets. we want to keep our Compose tickets to remain opened.
see
see
al...@google.com
im...@google.com
Related to
al...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 3e74e5ef9d8e4ab6c599c95fcc510fae230c2470
Author: Zach Klippenstein <klippenstein@google.com>
Date: Wed Dec 07 19:54:49 2022
Introduce marquee modifier.
Unlike my first attempt at this, aosp/1931284, this time I tried to copy
the simplicity and behavior of the platform behavior as closely as
possible, with the simplest implementation possible.
However, like with that first attempt, this modifier can be used on
anything, not just text.
The modifier uses defaults that match the behavior of the platform, with
limited customization options for repitition count, speed, delay, and
spacing. This should solve all of the use cases of the platform feature,
and if we need to build something more complex we can do that later.
This implementation does not support content that accepts pointer events
or other input. I checked the platform implementation and it also
doesn't handle this well (e.g. if the text has a clickable link in it,
the link is only clickable at certain points in the animation and not
where it's rendered).
Fixes:
Test: BasicMarqueeTest
Relnote: "Introduce experimental `Modifier.basicMarquee()` for displaying
content with a scrolling marquee effect."
Change-Id: I2df44c3343afa8400b0da768a642b77da94c103d
M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/public_plus_experimental_current.txt
M compose/foundation/foundation/api/restricted_current.txt
A compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/BasicMarqueeDemo.kt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/FoundationDemos.kt
M compose/foundation/foundation/samples/build.gradle
A compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/BasicMarqueeSamples.kt
A compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/BasicMarqueeTest.kt
A compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/BasicMarquee.kt
https://android-review.googlesource.com/2334291
Branch: androidx-main
commit 3e74e5ef9d8e4ab6c599c95fcc510fae230c2470
Author: Zach Klippenstein <klippenstein@google.com>
Date: Wed Dec 07 19:54:49 2022
Introduce marquee modifier.
Unlike my first attempt at this, aosp/1931284, this time I tried to copy
the simplicity and behavior of the platform behavior as closely as
possible, with the simplest implementation possible.
However, like with that first attempt, this modifier can be used on
anything, not just text.
The modifier uses defaults that match the behavior of the platform, with
limited customization options for repitition count, speed, delay, and
spacing. This should solve all of the use cases of the platform feature,
and if we need to build something more complex we can do that later.
This implementation does not support content that accepts pointer events
or other input. I checked the platform implementation and it also
doesn't handle this well (e.g. if the text has a clickable link in it,
the link is only clickable at certain points in the animation and not
where it's rendered).
Fixes:
Test: BasicMarqueeTest
Relnote: "Introduce experimental `Modifier.basicMarquee()` for displaying
content with a scrolling marquee effect."
Change-Id: I2df44c3343afa8400b0da768a642b77da94c103d
M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/public_plus_experimental_current.txt
M compose/foundation/foundation/api/restricted_current.txt
A compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/BasicMarqueeDemo.kt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/FoundationDemos.kt
M compose/foundation/foundation/samples/build.gradle
A compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/BasicMarqueeSamples.kt
A compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/BasicMarqueeTest.kt
A compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/BasicMarquee.kt
al...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 7e514a1106d3ddf9d4d583f879bb0c1b34c27b28
Author: Zach Klippenstein <klippenstein@google.com>
Date: Tue Dec 13 07:45:53 2022
Some marquee polish.
Follow-up to aops/2334291.
Cleans up some of the implementation code, and allows some properties to
be updated without recreating the whole modifier instance, addresses
some nits from the initial CL, and adds some tests.
Bug:
Test: BasicMarqueeTest
Relnote: n/a
Change-Id: I5b8091a396f72c5d81f28e4fd846d9452a0e8308
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/BasicMarqueeTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/BasicMarquee.kt
https://android-review.googlesource.com/2348589
Branch: androidx-main
commit 7e514a1106d3ddf9d4d583f879bb0c1b34c27b28
Author: Zach Klippenstein <klippenstein@google.com>
Date: Tue Dec 13 07:45:53 2022
Some marquee polish.
Follow-up to aops/2334291.
Cleans up some of the implementation code, and allows some properties to
be updated without recreating the whole modifier instance, addresses
some nits from the initial CL, and adds some tests.
Bug:
Test: BasicMarqueeTest
Relnote: n/a
Change-Id: I5b8091a396f72c5d81f28e4fd846d9452a0e8308
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/BasicMarqueeTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/BasicMarquee.kt
ap...@google.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.compose.foundation:foundation:1.4.0-alpha04
Description
Our resource API tracking inverts the behavior of AGP by treating the "no public element" case as "all resources are private" when in fact it indicates the legacy "all resources are public" behavior.
The correct way to declare "no public elements" is to define a single
<public />element.Unclear how we're going to handle this for existing libraries where all resources are currently considered public but have never been tracked.