IllegalStateException using Work Version 2.5.0-alpha03 [170924044]

Fixed

Bug

Status Update

No update yet.

Description

da...@gmail.com

created issue #1

Oct 15, 2020 11:16AM

Component used: Work Version 2.5.0-alpha03
Version used: Work Version 2.5.0-alpha03
Devices/Android versions reproduced on: Android 10 and 11

Am getting the following crash report on the Play console since updating to the alpha version yesterday.

java.lang.IllegalStateException:
at android.app.ContextImpl.startServiceCommon (ContextImpl.java:1688)
at android.app.ContextImpl.startService (ContextImpl.java:1633)
at android.content.ContextWrapper.startService (ContextWrapper.java:683)
at androidx.work.impl.Processor.stopForegroundService (Processor.java:312)
at androidx.work.impl.Processor.stopForeground (Processor.java:222)
at androidx.work.impl.WorkerWrapper.resolve (WorkerWrapper.java:446)
at androidx.work.impl.WorkerWrapper.resetPeriodicAndResolve (WorkerWrapper.java:556)
at androidx.work.impl.WorkerWrapper.handleResult (WorkerWrapper.java:461)
at androidx.work.impl.WorkerWrapper.onWorkFinished (WorkerWrapper.java:341)
at androidx.work.impl.WorkerWrapper$2.run (WorkerWrapper.java:318)
at androidx.work.impl.utils.SerialExecutor$Task.run (SerialExecutor.java:91)
at java.util.concurrent.ThreadPoolExecutor.runWorker (ThreadPoolExecutor.java:1167)
at java.util.concurrent.ThreadPoolExecutor$Worker.run (ThreadPoolExecutor.java:641)
at java.lang.Thread.run (Thread.java:919)

Comments

ra...@google.com <ra...@google.com> #2Oct 15, 2020 03:08PM

Can someone please provide an example of Notification.BigPictureStyle().bigPicture(...) working with an animated image? From the description of this issue and the API 31 requirement, I am assuming an Icon must be passed to .bigPicture(). However, what configurations does the Icon need in order to animate?

I have scoured the internet, but am unable to find a single example of this even though Google boldly announced it in their overview of Android 12 features.

Edit: Also requested here

da...@gmail.com <da...@gmail.com> #3Oct 15, 2020 05:24PM

Project: platform/frameworks/support
Branch: androidx-main

commit a2b7f7b7268c8f24b6e3a66bf58017f39c329b68
Author: Alexander Roederer <aroederer@google.com>
Date: Thu Jun 16 17:45:43 2022

Adds support for BigPictureStyle using Icon

Modifies Notification.java to use Icon as the base representation
for BigPicture in BigPictureStyle. Also adds tests to ensure both
Icon and Bitmap representation are functional.

Bug: 215583339
Test: NotificationCompatTest integration tests added
Relnote: Adds support for BigPictureStyle using Icon
Change-Id: Ice26d1400836cdf74af931f0f8ca59c25dd9c3c3

M core/core/api/restricted_current.txt
M core/core/src/main/java/androidx/core/app/NotificationCompat.java
M core/core/api/public_plus_experimental_current.txt
M core/core/src/androidTest/java/androidx/core/app/NotificationCompatTest.java
M core/core/api/current.txt

https://android-review.googlesource.com/2129854

da...@gmail.com <da...@gmail.com> #4Oct 15, 2020 05:26PM

Flag flipped in https://googleplex-android-review.git.corp.google.com/c/platform/frameworks/base/+/21117678. This should be enabled starting in U. On devices running U, Icons passed to bigPicture() that contain animated drawables will animate automatically when appropriate (e.g., when the notification is in heads-up state or expanded, when the image is viewable).

da...@gmail.com <da...@gmail.com> #5Oct 16, 2020 06:28PM

103 crashes reported by 49 users.

Occurring on:
Android 10 (SDK 29)
Android 9 (SDK 28)
Android 11 (SDK 30)
Android 8.0 (SDK 26)

Device distribution:
Samsung Galaxy S20+ - 30.1%
Samsung Galaxy S10+ - 7.8%
Samsung Galaxy S10 - 5.8%
Samsung Galaxy Note10+ - 4.9%
Xiaomi Mi A1 - 3.9%
OnePlus OnePlus6T - 3.9%
OnePlus 7T - 3.9%
crownqltesq - 2.9%
Samsung Galaxy S20 Ultra 5G - 2.9%
crownqlteue - 2.9%
Samsung Galaxy Note9 - 2.9%
OnePlus OnePlus5T - 1.9%
Google Pixel 3 XL - 1.9%
Xiaomi MI 9 - 1.9%
OnePlus OnePlus5 - 1.9%
POCO X3 NFC - 1.0%
Huawei P10 - 1.0%
Samsung Galaxy A70 - 1.0%
OnePlus One - 1.0%
OnePlus 6 - 1.0%
Others - 15.5%

da...@gmail.com <da...@gmail.com> #6Oct 16, 2020 06:29PM

Crash report on Android 11:
java.lang.IllegalStateException:
at android.app.ContextImpl.startServiceCommon (ContextImpl.java:1715)
at android.app.ContextImpl.startService (ContextImpl.java:1670)
at android.content.ContextWrapper.startService (ContextWrapper.java:720)
at androidx.work.impl.Processor.stopForegroundService (Processor.java:312)
at androidx.work.impl.Processor.stopForeground (Processor.java:222)
at androidx.work.impl.WorkerWrapper.resolve (WorkerWrapper.java:446)
at androidx.work.impl.WorkerWrapper.tryCheckForInterruptionAndResolve (WorkerWrapper.java:419)
at androidx.work.impl.WorkerWrapper.onWorkFinished (WorkerWrapper.java:329)
at androidx.work.impl.WorkerWrapper$2.run (WorkerWrapper.java:318)
at androidx.work.impl.utils.SerialExecutor$Task.run (SerialExecutor.java:91)
at java.util.concurrent.ThreadPoolExecutor.runWorker (ThreadPoolExecutor.java:1167)
at java.util.concurrent.ThreadPoolExecutor$Worker.run (ThreadPoolExecutor.java:641)
at java.lang.Thread.run (Thread.java:923)

da...@gmail.com <da...@gmail.com> #7Nov 3, 2020 11:23AM

1,751 crashes from 383 users in my beta channel.

I have reverted back to the 2.4.0 version of the library and the crashes have stopped.

ra...@google.com <ra...@google.com> #8Nov 3, 2020 05:52PM

Assigned to ra...@google.com.

Is there an error message with the exception ?

da...@gmail.com <da...@gmail.com> #9Nov 4, 2020 12:55PM

No, the Play console only contains the following crash information:

This is from a Samsung S20 running Android 10

java.lang.IllegalStateException:
at android.app.ContextImpl.startServiceCommon (ContextImpl.java:1688)
at android.app.ContextImpl.startService (ContextImpl.java:1633)
at android.content.ContextWrapper.startService (ContextWrapper.java:683)
at androidx.work.impl.Processor.stopForegroundService (Processor.java:312)
at androidx.work.impl.Processor.stopForeground (Processor.java:222)
at androidx.work.impl.WorkerWrapper.resolve (WorkerWrapper.java:446)
at androidx.work.impl.WorkerWrapper.resetPeriodicAndResolve (WorkerWrapper.java:556)
at androidx.work.impl.WorkerWrapper.handleResult (WorkerWrapper.java:461)
at androidx.work.impl.WorkerWrapper.onWorkFinished (WorkerWrapper.java:341)
at androidx.work.impl.WorkerWrapper$2.run (WorkerWrapper.java:318)
at androidx.work.impl.utils.SerialExecutor$Task.run (SerialExecutor.java:91)
at java.util.concurrent.ThreadPoolExecutor.runWorker (ThreadPoolExecutor.java:1167)
at java.util.concurrent.ThreadPoolExecutor$Worker.run (ThreadPoolExecutor.java:641)
at java.lang.Thread.run (Thread.java:919)

da...@gmail.com <da...@gmail.com> #10Nov 4, 2020 12:59PM

Actually, I just found it in the local log on my test device:

10-27 05:17:18.804 E/AndroidRuntime(12498): java.lang.IllegalStateException: Not allowed to start service Intent { act=ACTION_STOP_FOREGROUND cmp=com.dvtonder.chronus/androidx.work.impl.foreground.SystemForegroundService }: app is in background uid UidRecord{507c6a5 u0a291 CRE bg:+6h3m58s342ms idle change:cached procs:1 seq(0,0,0)}
10-27 05:17:18.804 E/AndroidRuntime(12498): at android.app.ContextImpl.startServiceCommon(ContextImpl.java:1715)
10-27 05:17:18.804 E/AndroidRuntime(12498): at android.app.ContextImpl.startService(ContextImpl.java:1670)
10-27 05:17:18.804 E/AndroidRuntime(12498): at android.content.ContextWrapper.startService(ContextWrapper.java:720)
10-27 05:17:18.804 E/AndroidRuntime(12498): at androidx.work.impl.Processor.stopForegroundService(SourceFile:312)
10-27 05:17:18.804 E/AndroidRuntime(12498): at androidx.work.impl.Processor.stopForeground(SourceFile:222)
10-27 05:17:18.804 E/AndroidRuntime(12498): at androidx.work.impl.WorkerWrapper.resolve(SourceFile:446)
10-27 05:17:18.804 E/AndroidRuntime(12498): at androidx.work.impl.WorkerWrapper.tryCheckForInterruptionAndResolve(SourceFile:419)
10-27 05:17:18.804 E/AndroidRuntime(12498): at androidx.work.impl.WorkerWrapper.interrupt(SourceFile:375)
10-27 05:17:18.804 E/AndroidRuntime(12498): at androidx.work.impl.Processor.interrupt(SourceFile:331)
10-27 05:17:18.804 E/AndroidRuntime(12498): at androidx.work.impl.Processor.stopWork(SourceFile:188)
10-27 05:17:18.804 E/AndroidRuntime(12498): at androidx.work.impl.utils.StopWorkRunnable.run(SourceFile:73)
10-27 05:17:18.804 E/AndroidRuntime(12498): at androidx.work.impl.utils.SerialExecutor$Task.run(SourceFile:91)
10-27 05:17:18.804 E/AndroidRuntime(12498): at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)
10-27 05:17:18.804 E/AndroidRuntime(12498): at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)
10-27 05:17:18.804 E/AndroidRuntime(12498): at java.lang.Thread.run(Thread.java:923)
--------- beginning of main

ra...@google.com <ra...@google.com> #11Nov 4, 2020 05:38PM

Thanks. That helps !

ap...@google.com <ap...@google.com> #12Nov 6, 2020 12:47AM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 2f84e04876c0454432cb5595c73b1b1c02156331
Author: Rahul Ravikumar <rahulrav@google.com>
Date: Thu Nov 05 15:18:22 2020

Stop foreground service and ignore exceptions.

- There are bugs in the platform that causes an intent dispatch to fail.
This happens because the service and the `uid` is still in the background even
though this intent could have only been delivered _after_ startForeground(...).

Fixes:

b/170924044

Test: Ran integration tests to make sure existing functionality is not broken.
Change-Id: I99dc8e3e334ccbf3a53aa475ae445560278c004a

M work/workmanager/src/main/java/androidx/work/impl/Processor.java

https://android-review.googlesource.com/1489901

da...@gmail.com <da...@gmail.com> #13Nov 11, 2020 07:43PM

Silly question but when can one expect the next alpha or beta of Work to be released? I would like to get the fix for this issue deployed to my users.

ra...@google.com <ra...@google.com> #14Nov 11, 2020 07:50PM

The next beta should have this change. We have a release planned in the first week of December.

ra...@google.com <ra...@google.com> #15Nov 11, 2020 07:51PM

If you won't want to wait, you can always use the SNAPSHOT version from https://androidx.dev