[Feature Request] Allow compose components to inherit their parent's 'absolute elevation' [171031040]

Fixed

Feature Request

Status Update

No update yet.

Description

al...@gmail.com

created issue #1

Oct 16, 2020 04:49PM

In material-components-android, views automatically inherit the elevation of their parent ViewGroups using this utility method: https://github.com/material-components/material-components-android/blob/89a1bf883fa614702bb43d2cfa75a38005a42421/lib/java/com/google/android/material/internal/ViewUtils.java#L259-L271

For example, say you have a MaterialButton (with 4dp elevation) contained inside of a BottomSheet (with 16dp elevation). In dark theme, the MaterialButton will inherit the BottomSheet's elevation, meaning that its elevation overlay will render as if the MaterialButton had 20dp elevation instead of 4dp elevation.

It would be useful if there was a builtin mechanism to support this in Compose. This would make it easier to migrate UIs written with material-components-android to Compose while still maintaining UI consistency.

Comments

al...@gmail.com <al...@gmail.com> #2Oct 18, 2020 10:10PM

There is a report about it in kotlinlang Slack: https://kotlinlang.slack.com/archives/C01D6HTPATV/p1706005056105739

cl...@google.com <cl...@google.com> Oct 19, 2020 10:31AM

Reassigned to an...@google.com.

an...@google.com <an...@google.com> Oct 19, 2020 11:35AM

Reassigned to lp...@google.com.

lp...@google.com <lp...@google.com> #3Oct 19, 2020 02:04PM

Thanks for the report!

al...@gmail.com <al...@gmail.com> #4Oct 19, 2020 05:26PM

The release notes documentation has been edited to clarify this change in behavior for line height.

To support non-standard text sizes, we encourage users to follow the Material design system and use a different type scale rather than changing the font size directly. Alternatively, users can overwrite the line height like so: style = LocalTextStyle.current.copy(lineHeight = TextUnit.Unspecified), or create a custom Typography entirely.

Message last modified on Oct 19, 2020 06:03PM

ch...@google.com <ch...@google.com> #5Oct 19, 2020 05:39PM

deleted

ap...@google.com <ap...@google.com> #6Oct 29, 2020 01:36PM

In my case, I have multiple font sizes in the same Text (using SpanStyle in AnnotatedString). There are legitimate reasons for this. For example, when combining Chinese and English (phonetic) together (for language-learning purposes).

lp...@google.com <lp...@google.com> Oct 29, 2020 01:46PM

Marked as fixed.

al...@gmail.com <al...@gmail.com> #7Oct 29, 2020 02:57PM

Woot thanks Louis!