Api for read-only TextField [171040474]

Fixed

Bug

Status Update

No update yet.

Description

dm...@gmail.com

created issue #1

Oct 16, 2020 04:57PM

Jetpack Compose release version: 1.0.0-alpha05

OutlinedTextField and other text fields should have API to mark them as read-only/noneditable/disabled.

Noneditable field should follow material design guidlines [1] and shouldn't show keyboard when focused.

[1] https://material.io/components/text-fields#input-types

Comments

so...@google.com <so...@google.com> Oct 23, 2020 08:24AM

Status: Duplicate of

166478534

so...@google.com <so...@google.com> #2Nov 5, 2020 05:51PM

Status: Assigned (reopened)

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 23a7d960caf43390a554700d3c56ada189a9d10e
Author: Louis Pullen-Freilich <lpf@google.com>
Date: Mon Aug 10 15:11:36 2020

IconButton / IconToggleButton API scrub

Test: ./gradlew updateApi
Bug:

b/161809385

Bug:

b/161807956

Relnote: "Adds enabled parameter to IconButton, and reorders parameters in IconToggleButton"
Change-Id: I0a9419b1a631cadad451395302ad87b7f9214f96

M ui/ui-material/api/current.txt
M ui/ui-material/api/public_plus_experimental_current.txt
M ui/ui-material/api/restricted_current.txt
M ui/ui-material/src/commonMain/kotlin/androidx/compose/material/IconButton.kt

https://android-review.googlesource.com/1394868

so...@google.com <so...@google.com> #3Nov 5, 2020 06:00PM

Read-only text field requirements:

not editable
focusable
keyboard is not displayed
cursor is not displayed
selection works for copy

si...@google.com <si...@google.com> #4Nov 5, 2020 06:13PM

https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/readonly

si...@google.com <si...@google.com> #5Nov 5, 2020 06:30PM

ap...@google.com <ap...@google.com> #6Dec 24, 2020 07:47PM

Project: platform/frameworks/support
Branch: androidx-main

commit 18d398281228fd3c116553c608f45635fd3488ea
Author: Anastasia Soboleva <soboleva@google.com>
Date: Tue Dec 08 11:01:54 2020

Add support for disabled and read-only text fields

Bug: 171040474
Fixes: 166478534
Test: new tests
Relnote: "Added support for disabled and read-only text fields"
Change-Id: I352791811a7b75189013e1ed73c9834cfa5ce961

M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/public_plus_experimental_current.txt
M compose/foundation/foundation/api/restricted_current.txt
M compose/foundation/foundation/build.gradle
A compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/textfield/InactiveTextFieldTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/textfield/MaxLinesHeightModifierTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/textfield/SoftwareKeyboardTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/textfield/TextFieldCursorTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/textfield/TextFieldDefaultWidthTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/textfield/TextFieldFocusTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/textfield/TextFieldOnValueChangeTextFieldValueTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/textfield/TextFieldScrollTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/textfield/TextFieldTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/BasicTextField.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/CoreTextField.kt
A compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/InactiveTextField.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/MaxLinesHeightModifier.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/TextFieldScroll.kt
M compose/material/material/api/current.txt
M compose/material/material/api/public_plus_experimental_current.txt
M compose/material/material/api/restricted_current.txt
M compose/material/material/integration-tests/material-demos/src/main/java/androidx/compose/material/demos/MaterialTextField.kt
M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/textfield/OutlinedTextFieldScreenshotTest.kt
M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/textfield/TextFieldScreenshotTest.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/OutlinedTextField.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/TextField.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/TextFieldImpl.kt

https://android-review.googlesource.com/1534463

so...@google.com <so...@google.com> #7Dec 24, 2020 07:48PM

aosp/1534463 submitted.

Keeping this bug open to follow-up on scrolling behaviour in read-only text fields.

al...@gmail.com <al...@gmail.com> #8Dec 24, 2020 07:59PM

Amazing thank you for fixing!

so...@google.com <so...@google.com> #9Jan 27, 2021 09:14PM

Marked as fixed.

Marking this as fixed, there is internal bug to track the read-only scrolling behaviour.