Explore representing colors used by a TextField in a TextFieldColors interface [171305338]

Fixed

Bug

Status Update

No update yet.

Description

lp...@google.com

created issue #1

Oct 20, 2020 03:53PM

Following recent changes to other components (such as SwitchColors and ButtonElevation) we use type safe interfaces to represent parameters that change in different states.

Currently the color parameters on TextField are misleading, as they are modified a lot and used in different places, making it hard to customize parts of the text field, such as having a different error color for the cursor and label. Additionally, emphasis is applied internally meaning that there is no way to opt out / change the alpha applied to certain parts of the text field.

We could allow for easier customization and make the API surface more clear with something like:

interface TextFieldColors {
    fun cursorColor(isError: Boolean): Color

    fun labelColor(isError: Boolean): Color

    ...
}

Happy to help discuss this, but I think the first step is figuring out what all the combination of colors that are used in different states / places in the TextField are.

Comments

tc...@google.com <tc...@google.com> #2Feb 5, 2021 10:02PM

Checking with UX team they also want to update the Chip with gradient background as well. Currently specified with the gradient as compositeOver(MaterialTheme.color.surface.copy(0.75f)) for enabled - they want this to change to 1.0f.

ap...@google.com <ap...@google.com> #3Feb 10, 2021 05:20PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit b7674378db62c194c8a8b4fd496631f9a82d9113
Author: John Nichol <jnichol@google.com>
Date: Tue Jun 14 16:21:44 2022

Update the backgrounds behind Wear Chip gradients.

Wear Chips/ToggleChips with gradiant backgrounds are missing a solid background behind the gradient.

Bug: 235937657
RelNote: "We have added a background color (MaterialTheme.color.surface) behind Chip/ToggleChips that have gradient backgrounds in order to ensure that they are properly visible in the unlikely event that a light color is used behind them."
Test: ./gradlew :wear:compose:compose-material:connectedCheck --info --daemon
Change-Id: Ibe1a442812a48a6d39912b4bbf399a2f4b11ae5b

M wear/compose/compose-material/src/commonMain/kotlin/androidx/wear/compose/material/Chip.kt
M wear/compose/compose-material/src/commonMain/kotlin/androidx/wear/compose/material/ToggleChip.kt

https://android-review.googlesource.com/2125159

Issue 171305338

Description

Issue summary

Comments

tc...@google.com <tc...@google.com> #2Feb 5, 2021 10:02PM

ap...@google.com <ap...@google.com> #3Feb 10, 2021 05:20PM

Add comment

Issue metadata