Compose doesn't provide equivalent of android:includeFontPadding [171394808]

Fixed

Feature Request

Status Update

No update yet.

Description

al...@gmail.com

created issue #1

Oct 22, 2020 12:59AM

With traditional views, you can specify in XML on your TextView whether or not you want to include font padding using android:includeFontPadding="false".

It would be nice if Compose provided a means of doing this (because otherwise it makes it difficult to migrate traditional views over to Compose w/o it looking visually different).

Comments

nj...@google.com <nj...@google.com> Oct 22, 2020 01:00AM

Assigned to si...@google.com.

si...@google.com <si...@google.com> Dec 9, 2020 10:10PM

Reassigned to an...@google.com.

si...@google.com <si...@google.com> #2Feb 23, 2021 11:11PM

First of all thanks for this detailed issue.

This issue had been investigated thoroughly when it was first reported internally. The surprising detail in this report is that the issue is not reproducible before 1.7. I will look into this.

The main problem with POBox is the fact that it is deprecated. Since 2021 Sony has been shipping new Xperia devices with Gboard pre-installed. Although we are aware that there is still a considerable amount of users still using POBox, the described behavior is caused by POBox's noncompliant behavior with InputConnection and InputMethodManager documentation. However, this is understandable since TextView implementation was also not respecting the behavior that is expected from Editors.

Ultimately we have decided to enforce the documented behavior with specifically regards to when editors should call InputMethodManager.updateSelection. Also, although unconfirmed, there were traces of possible custom code being included in Sony OEM images that changed how InputMethodManager was notified from TextView. If POBox also depended on something like this, it would be impossible for Compose code to replicate the same unknown behavior.

si...@google.com <si...@google.com> #3Feb 23, 2021 11:13PM

If the investigation takes time, would it be possible to revert the surrounding implementation to 1.6.x equivalent?

Or is that option not available?

Even if the root cause is POBox, from the perspective of the app's customers, it looks like an app bug, so this issue is a blocker against updating Jetpack Compose.

si...@google.com <si...@google.com> #4Feb 23, 2021 11:17PM

Just to be sure, it is dangerous to replace Compose TextField with Android View EditText as a workaround for this issue.

Compose 1.7 has a bug that causes ANR when the focus is on EditText. https://issuetracker.google.com/issues/369354336

Another View-related bug in Compose 1.7 is that an Android View is focused by calling FocusManager.clearFocus(). https://issuetracker.google.com/issues/374031296

Perhaps there is a lack of testing of Compose 1.7 in combination with Android View. There is also a possibility that there are other fatal bugs related to View.

In other words, the only options for apps targeting the Japanese market that require POBox support are to continue using Compose 1.6 or to use EditText in combination with various workarounds.

pa...@gmail.com <pa...@gmail.com> #5Apr 2, 2021 09:45PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Halil Ozercan <halilibo@google.com>
Link: https://android-review.googlesource.com/3317256

Fix POBox keyboard issue

Expand for full commit details

Fix POBox keyboard issue 
 
Fix: 373743376 
Fix: 329209241 
Test: NullableInputConnectionWrapperTest 
Change-Id: I94e0e598274fb88b255f977f9fbd50dfbbb1ecb1

Files:

M compose/ui/ui/src/androidInstrumentedTest/kotlin/androidx/compose/ui/text/input/NullableInputConnectionWrapperTest.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/text/input/NullableInputConnectionWrapper.android.kt

Hash: 57f58c4b80d5d8470b2aca325dfdcd55f235231e
Date: Thu Oct 24 01:25:20 2024

1s...@gmail.com <1s...@gmail.com> #6Jun 13, 2021 01:04PM

Many thanks again for this report. Especially for giving us a huge clue in terms of what could be going wrong. The fix is now merged and I will ask for a cherry-pick into a stable release.

co...@protonmail.com <co...@protonmail.com> #7Jun 14, 2021 04:06PM

Thank you for fixing the issue, I confirmed the fix was released in version 1.8.0-alpha05.
Do you have any concrete plan to cherry-pick the fix into current stable version (1.7.x)? We are currently waiting it.

al...@gmail.com <al...@gmail.com> #8Jun 17, 2021 06:24PM

Yes, this fix is planned to be included in a future 1.7.x release.

ma...@gmail.com <ma...@gmail.com> #9Jul 14, 2021 07:08PM

Thanks for the fix. Sorry to follow up on this. is it possible for you to share specific release version/date for the stable version? We are waiting on this to decide on our direction.

ka...@gmail.com <ka...@gmail.com> #10Jul 19, 2021 02:16PM

to...@gmail.com <to...@gmail.com> #11Jul 22, 2021 09:06AM

ci...@gmail.com <ci...@gmail.com> #12Jul 23, 2021 05:17PM

[Deleted User] <[Deleted User]> #13Jul 26, 2021 04:52AM

dj...@gmail.com <dj...@gmail.com> #14Aug 1, 2021 02:47PM

[Deleted User] <[Deleted User]> #15Aug 3, 2021 05:23AM

Comment has been deleted.

Message last modified on Aug 3, 2021 05:23AM

kr...@gmail.com <kr...@gmail.com> #16Aug 19, 2021 08:50AM

i....@getorca.app <i....@getorca.app> #17Aug 25, 2021 05:11PM

ha...@google.com <ha...@google.com> Aug 25, 2021 08:53PM

Reassigned to ha...@google.com.

sm...@gmail.com <sm...@gmail.com> #18Aug 27, 2021 08:38AM

zh...@gmail.com <zh...@gmail.com> #19Aug 28, 2021 05:04PM

ti...@soufan.com.br <ti...@soufan.com.br> #20Aug 30, 2021 10:52AM

jr...@gmail.com <jr...@gmail.com> #21Sep 7, 2021 05:51PM

su...@gmail.com <su...@gmail.com> #22Sep 15, 2021 07:34PM

Do we have an ETA or any updates for this issue?

iv...@gmail.com <iv...@gmail.com> #23Sep 17, 2021 12:06PM

This is really a Stopper, we jump in to Compose migration and faced this issue

ha...@google.com <ha...@google.com> #24Sep 17, 2021 10:40PM

Updates: Currently we are studying the use cases for includeFontPadding == false. And it would be super helpful if you can share a little bit more about why you want to turned off includeFontPadding.

Here are some cases we are considering:

Vertically align Text with another composable/widget
Making 2 Text composable exactly the same as 2 lines of text.
Vertically centering the text within another composable/widget.

Your suggestions are welcomed. Thanks a lot!

iv...@gmail.com <iv...@gmail.com> #25Sep 18, 2021 05:26PM

Custom font adds a lot of bottom padding and all my composable Texts looks completely different from Figma's design. e.g. Text on the Card -> Instead of having 16dp padding (margin) from bottom of the edge of the card we got 22 dp. (Although with "includeFontPaddings = false" and Android TextView works like a charm)

Message last modified on Sep 18, 2021 05:27PM

ta...@gmail.com <ta...@gmail.com> #26Sep 18, 2021 06:19PM

In my case, there will be margins at the top and bottom.

Originally, there was a problem with Android's handling of Noto Sans CJK Font, and I worked around it by setting "includeFontPaddings = false".

For related discussions, the following may be helpful.

https://github.com/adobe-fonts/source-han-sans/issues/88

noto_sans_jp_example.png

34 KB

View

Download

iv...@gmail.com <iv...@gmail.com> #27Sep 18, 2021 06:54PM

Attached screenshots, in case it helps
CustomFontWithBottomPadding.png - applying custom font adds a lot of bottom padding.
I don't need it, because distance from bottom of the Text to other elements are broken by this

CustomFontWithBottomPadding.png

69 KB

View

Download

DefaultFontNoBottomPadding.png

67 KB

View

Download

[Deleted User] <[Deleted User]> #28Sep 19, 2021 03:56PM

+1

any workable workarounds for now?

Message last modified on Sep 19, 2021 03:56PM

jo...@pucp.pe <jo...@pucp.pe> #29Sep 21, 2021 03:21AM

+1, having Text composables always vertically misaligned is really annoying. Use case: center a Text composable vertically inside a Row when the font it is using adds lots of padding at the bottom.

se...@gmail.com <se...@gmail.com> #30Sep 27, 2021 10:35PM

+1

Any update on this? This is really a dealbreaker for me. I could make a wrapper with TextView, but that really defeats the purpose of using the Jetpack Compose :(

fo...@gmail.com <fo...@gmail.com> #31Oct 7, 2021 09:54AM

+1, Same issue, custom font has to much padding top and bottom. Currently using a wrapped Textview in Compose, but this breaks the preview in Android Studio :(

mx...@gmail.com <mx...@gmail.com> #32Oct 7, 2021 10:34AM

A side note unrelated to the issue itself.

If you are using custom fonts and see too much padding due to Android's incorrect behavior, it might be better to modify the font itself. Here are the steps.

Install fonttools. You can use pip3 install fonttools.
Run ttx -t head font.ttf.
Open font.ttx with a text editor and modify yMin and yMax values. It should be generally safe to change them to be the same as Roboto's values, which are -555 and 2163 respectively.
Run ttx -m font.ttf -b font.ttx and you'll get font#1.ttf.

im...@gmail.com <im...@gmail.com> #33Oct 8, 2021 02:20PM

[Deleted User] <[Deleted User]> #34Oct 10, 2021 10:01AM

lc...@gmail.com <lc...@gmail.com> #35Oct 10, 2021 10:04AM

Please just star the issue, adding a comment with +1 is just going to spam emails to everyone subscribed to this issue. Thank you for understanding.

f....@gmail.com <f....@gmail.com> #36Oct 11, 2021 07:58PM

bo...@gmail.com <bo...@gmail.com> #37Oct 19, 2021 02:13PM

si...@google.com <si...@google.com> Nov 17, 2021 02:43AM

Reassigned to an...@google.com.

jp...@spoton.com <jp...@spoton.com> #38Nov 19, 2021 03:07PM

+1
Workaround that works for my font, it cut's down bottom padding by looking at lines multiplied by lineHeight:

fun Modifier.removeFontPadding(
textStyle: TextStyle
) = layout { measurable, constraints ->
val placeable = measurable.measure(constraints)
val heightWithoutPadding = placeable.height - placeable.height.mod(textStyle.lineHeight.roundToPx())
layout(placeable.width, heightWithoutPadding) {
placeable.placeRelative(0, 0)
}
}

usage:
Text(
modifier = Modifier.removeFontPadding(typography.h5),
text = title,
style = typography.h5,
)

[Deleted User] <[Deleted User]> #39Dec 15, 2021 09:30PM

mi...@gmail.com <mi...@gmail.com> #40Dec 16, 2021 03:29AM

ch...@googlemail.com <ch...@googlemail.com> #41Jan 5, 2022 12:58PM

[Deleted User] <[Deleted User]> #42Jan 9, 2022 06:58PM

Message last modified on Jan 9, 2022 06:59PM

ji...@hotstar.com <ji...@hotstar.com> #43Jan 13, 2022 10:43AM

+1 feel pain for fixing the design paddings T T

si...@gmail.com <si...@gmail.com> #44Jan 13, 2022 10:56AM

I built a component with annotatedStrings and 2 different styles + different sizes + different baselines. Basically, I needed a Superscript text (but aligned with the top and not above the second text, and different 60% of the font size) the second text (Baseline.None). I had some size variations for this component, and for each variation, I had to implement a different Baseline multiplier because it just wasn't aligning properly at the top (because of the font padding).

ag...@gmail.com <ag...@gmail.com> #45Jan 19, 2022 02:44PM

temporary solution:

fun Modifier.baselinePadding(
firstBaselineToTop: Dp,
lastBaselineToBottom: Dp
) = layout { measurable, constraints ->
val placeable = measurable.measure(constraints)

check(placeable[FirstBaseline] != AlignmentLine.Unspecified)
val firstBaseline = placeable[FirstBaseline]

check(placeable[LastBaseline] != AlignmentLine.Unspecified)
val lastBaseline = placeable[LastBaseline]

val lastBaselineToBottomHeight = placeable.height - lastBaseline

val lastBaselineToBottomDelta = lastBaselineToBottom.roundToPx() - lastBaselineToBottomHeight

val totalHeight = placeable.height +
(firstBaselineToTop.roundToPx() - firstBaseline)

val placeableY = totalHeight - placeable.height
layout(placeable.width, totalHeight + lastBaselineToBottomDelta) {
placeable.placeRelative(0, placeableY)
}
}

me...@gmail.com <me...@gmail.com> #46Jan 24, 2022 02:09PM

si...@google.com <si...@google.com> Jan 25, 2022 05:17PM

Reassigned to an...@google.com.

so...@google.com <so...@google.com> Jan 25, 2022 05:59PM

Reassigned to so...@google.com.

[Deleted User] <[Deleted User]> #47Feb 5, 2022 02:45PM

vi...@gmail.com <vi...@gmail.com> #48Feb 11, 2022 09:23AM

gu...@gmail.com <gu...@gmail.com> #49Feb 13, 2022 06:49AM

#24 My use case in particular is to center text around a circle, without android:includeFontPadding it seems to be pushed up or down depending on the excess padding on the top or bottom.

#32 workaround works great. I just modified a Montserrat Regular.otf but instead of the values suggested by #32 I took the ones from the <hhea> tag, ascent for yMax and descent for yMin

si...@google.com <si...@google.com> #50Feb 13, 2022 11:51PM

Reassigned to si...@google.com.

Anastasia, I have an idea and picked up the ticket. Will start discussion soon.

si...@google.com <si...@google.com> #51Feb 14, 2022 04:59AM

Notes: go/compose-include-font-padding-2

ap...@google.com <ap...@google.com> #52Feb 28, 2022 04:42PM

Project: platform/frameworks/support-golden
Branch: androidx-main

commit 6b3a3705892a51e67c63b446ea69a5cf249effd2
Author: Siyamed Sinir <siyamed@google.com>
Date: Sun Feb 27 00:13:24 2022

Update screenshot tests for includeFontPadding

aosp/1992050

Bug: 171394808
Change-Id: Ia680e6bbbee0e2da192465eef234fb763793a8d7

M wear/compose/material/button_disabled_cuttlefish.png
M compose/material/material/actionChip_disabled_cuttlefish.png
M wear/compose/material/compactbutton_ltr_cuttlefish.png
M wear/compose/material/swiped_to_right_50_percent_ltr_cuttlefish.png
M compose/material/material/tabs_lightTheme_defaultColors_cuttlefish.png
M compose/material/material/outlinedTextField_disabled_cuttlefish.png
M compose/material/material/scaffold_bottomAppBar_centerFab_docked_cuttlefish.png
M compose/material3/material3/drawerItem_lightTheme_defaultColors_pressed_cuttlefish.png
M compose/material/material/fab_text_cuttlefish.png
M compose/material/material/filled_textField_singleLine_labelCenteredVetically_cuttlefish.png
M compose/material/material/dialog_stackedButtons_cuttlefish.png
M compose/material3/material3/centerAlignedAppBar_lightTheme_cuttlefish.png
M compose/material/material/fab_textAndIcon_cuttlefish.png
M compose/material/material/outlinedTextField_readOnly_focused_cuttlefish.png
M compose/material/material/tabs_lightTheme_surfaceColors_pressed_cuttlefish.png
M compose/material/material/actionChip_outlined_disabled_cuttlefish.png
M compose/material/material/badge_lightTheme_longContent_tab_cuttlefish.png
M compose/material/material/filterChip_disabled_selected_cuttlefish.png
M compose/material/material/outlined_textField_focused_cuttlefish.png
M compose/material/material/filled_textField_singleLine_withLabel_placeholderAlignedToTop_cuttlefish.png
M wear/compose/material/compactbutton_disabled_cuttlefish.png
M compose/material3/material3/drawerItem_darkTheme_defaultColors_pressed_cuttlefish.png
M compose/material/material/outlined_textField_withInput_cuttlefish.png
M compose/material/material/dialog_onlyText_cuttlefish.png
M compose/material/material/filterChip_disabled_notSelected_cuttlefish.png
M compose/material/material/filterChip_notSelected_cuttlefish.png
M compose/material/material/outlined_textField_focused_errorState_cuttlefish.png
M compose/material3/material3/color_scheme_light_cuttlefish.png
M compose/material3/material3/tabs_lightTheme_pressed_cuttlefish.png
M compose/material/material/outlined_textField_singleLine_withLabel_textAlignedToTop_cuttlefish.png
M compose/material/material/scaffold_bottomAppBar_endFab_floating_ltr_cuttlefish.png
M compose/material3/material3/outlinedCard_darkTheme_cuttlefish.png
M compose/material3/material3/drawerItem_lightTheme_defaultColors_cuttlefish.png
M compose/foundation/foundation/multiStyleText_setFontWeight_cuttlefish.png
M compose/material/material/scaffold_bottomAppBar_centerFab_docked_noCutout_cuttlefish.png
M compose/material3/material3/filled_tonal_button_disabled_light_theme_cuttlefish.png
M compose/material/material/scaffold_bottomAppBar_endFab_docked_ltr_cuttlefish.png
M compose/material/material/filled_textField_not_focused_cuttlefish.png
M compose/material/material/filled_textField_singleLine_withoutLabel_placeholderCenteredVertically_cuttlefish.png
M compose/material/material/textField_readOnly_scrolled_cuttlefish.png
M compose/material3/material3/filled_tonal_button_light_theme_cuttlefish.png
M compose/material/material/scaffold_topAndBottomAppBar_centerFab_docked_cuttlefish.png
M compose/material/material/scaffold_bottomAppBar_cuttlefish.png
M compose/material/material/textField_readOnly_cuttlefish.png
M compose/material3/material3/outlined_button_disabled_light_theme_cuttlefish.png
M compose/material3/material3/snackbar_withDismiss_darkTheme_cuttlefish.png
M compose/material/material/scaffold_topAppBar_endFab_ltr_cuttlefish.png
M compose/foundation/foundation/multiStyleText_setFontStyle_cuttlefish.png
M compose/material3/material3/tabs_darkTheme_cuttlefish.png
M compose/material3/material3/elevatedCard_lightTheme_cuttlefish.png
M wear/compose/material/togglebutton_disabled_cuttlefish.png
M compose/material3/material3/alertDialog_withIcon_lightTheme_cuttlefish.png
M wear/compose/material/button_ltr_cuttlefish.png
M compose/material3/material3/snackbar_darkTheme_cuttlefish.png
M compose/material3/material3/filledCard_lightTheme_cuttlefish.png
M compose/material/material/topAndBottomAppBar_floatingFab_snackbar_cuttlefish.png
M compose/material/material/bottomAppBar_snackbar_cuttlefish.png
M compose/material/material/outlined_textField_multiLine_labelAlignedToTop_cuttlefish.png
M compose/material/material/filterChip_with_leading_icon_selected_cuttlefish.png
M compose/material/material/outlined_textField_focused_rtl_cuttlefish.png
M compose/material/material/outlined_textField_multiLine_withoutLabel_textAlignedToTop_cuttlefish.png
M compose/material3/material3/button_disabled_light_theme_cuttlefish.png
M compose/material/material/leadingIconTabs_darkTheme_defaultColors_cuttlefish.png
M compose/material/material/scaffold_topAndBottomAppBar_endFab_docked_rtl_cuttlefish.png
M compose/material/material/textField_readOnly_focused_cuttlefish.png
M compose/material3/material3/outlinedCard_lightTheme_cuttlefish.png
M compose/material/material/tabs_darkTheme_primaryColors_cuttlefish.png
M compose/material/material/outlinedTextField_textCenterAligned_cuttlefish.png
M compose/material/material/topAppBar_snackbar_cuttlefish.png
M compose/material/material/scaffold_topAndBottomAppBar_endFab_floating_rtl_cuttlefish.png
M compose/material/material/dialog_noTitleOrText_cuttlefish.png
M wear/compose/material/compactbutton_rtl_cuttlefish.png
M compose/material/material/outlined_textField_not_focused_cuttlefish.png
M compose/material3/material3/snackbar_lightTheme_cuttlefish.png
M wear/compose/material/swiped_to_right_50_percent_rtl_cuttlefish.png
M compose/material/material/filterChip_with_leading_icon_disabled_selected_cuttlefish.png
M compose/material/material/button_default_cuttlefish.png
M compose/material/material/tabs_darkTheme_primaryColors_pressed_cuttlefish.png
M compose/material3/material3/elevatedCard_pressed_cuttlefish.png
M compose/material/material/scaffold_topAppBar_centerFab_cuttlefish.png
M compose/material3/material3/snackbar_withAction_lightTheme_cuttlefish.png
M compose/material3/material3/elevatedCard_focused_cuttlefish.png
M compose/material/material/outlinedTextField_readOnly_scrolled_cuttlefish.png
M compose/material3/material3/elevatedCard_darkTheme_cuttlefish.png
M compose/material/material/filled_textField_textColor_defaultContentColor_cuttlefish.png
M compose/material3/material3/elevated_button_disabled_light_theme_cuttlefish.png
M compose/foundation/foundation/text_defaultSelectionColors_cuttlefish.png
M compose/material/material/button_disabled_cuttlefish.png
M compose/material/material/filled_textField_notFocused_errorState_cuttlefish.png
M compose/material/material/actionChip_outlined_cuttlefish.png
M compose/material/material/outlinedTextField_disabled_notScrolled_cuttlefish.png
M compose/material3/material3/color_scheme_dark_cuttlefish.png
M compose/material/material/outlinedTextField_leadingTrailingIcons_cuttlefish.png
M compose/material/material/outlinedTextField_leadingTrailingIcons_error_cuttlefish.png
M compose/material/material/filled_textField_withInput_cuttlefish.png
M compose/material/material/outlinedTextField_readOnly_cuttlefish.png
M compose/material3/material3/filledCard_focus_cuttlefish.png
M compose/material3/material3/outlined_button_light_theme_cuttlefish.png
M compose/material3/material3/color_scheme_light_dynamic_cuttlefish.png
M compose/material/material/outlinedTextField_disabled_notFocusable_cuttlefish.png
M compose/material3/material3/snackbar_withDismiss_lightTheme_cuttlefish.png
M compose/material/material/dialog_titleWithoutTextBaseline_cuttlefish.png
M compose/material3/material3/snackbar_withAction_darkTheme_cuttlefish.png
M compose/material/material/outlinedTextField_lightThemeSelectionColors_cuttlefish.png
M compose/material/material/tabs_lightTheme_surfaceColors_cuttlefish.png
M compose/material/material/filledTextField_lightThemeSelectionColors_cuttlefish.png
M compose/foundation/foundation/textField_defaultSelectionColors_cuttlefish.png
M compose/material/material/dialog_sideBySideButtons_cuttlefish.png
M compose/material3/material3/filledCard_pressed_cuttlefish.png
M compose/material3/material3/button_disabled_dark_theme_cuttlefish.png
M compose/material/material/outlined_textField_multiLine_withLabel_placeholderAlignedToTop_cuttlefish.png
M compose/material/material/scaffold_bottomAppBar_endFab_floating_rtl_cuttlefish.png
M compose/material/material/outlinedTextField_customShape_cuttlefish.png
M compose/material/material/outlined_textField_singleLine_labelCenteredVetically_cuttlefish.png
M compose/material3/material3/fab_extended_text_cuttlefish.png
M compose/material/material/textField_leadingTrailingIcons_cuttlefish.png
M compose/material3/material3/filledCard_darkTheme_cuttlefish.png
M compose/material3/material3/alertDialog_darkTheme_cuttlefish.png
M compose/material/material/filled_textField_singleLine_withLabel_textAlignedToTop_cuttlefish.png
M compose/material/material/outlined_textField_textColor_defaultContentColor_cuttlefish.png
M compose/material/material/tabs_darkTheme_defaultColors_cuttlefish.png
M compose/material/material/topAndBottomAppBar_snackbar_cuttlefish.png
M compose/foundation/foundation/text_customSelectionColors_cuttlefish.png
M compose/material3/material3/outlinedCard_focused_cuttlefish.png
M compose/material3/material3/outlinedCard_pressed_cuttlefish.png
M compose/material3/material3/elevated_button_light_theme_cuttlefish.png
M compose/material/material/dialog_onlyTitle_cuttlefish.png
M compose/material/material/scaffold_bottomAppBar_endFab_docked_rtl_cuttlefish.png
M compose/material/material/outlinedTextField_textAlignedToEnd_cuttlefish.png
M compose/material3/material3/tabs_lightTheme_cuttlefish.png
M compose/material/material/filledTextField_darkThemeSelectionColors_cuttlefish.png
M compose/material/material/textField_disabled_notScrolled_cuttlefish.png
M compose/foundation/foundation/textField_customSelectionColors_cuttlefish.png
M compose/material/material/tabs_lightTheme_defaultColors_pressed_cuttlefish.png
M compose/material/material/snackbar_cuttlefish.png
M compose/material3/material3/filledCard_hover_cuttlefish.png
M compose/material3/material3/tabs_darkTheme_pressed_cuttlefish.png
M compose/material/material/tabs_darkTheme_surfaceColors_cuttlefish.png
M compose/material/material/outlined_textField_multiLine_withoutLabel_placeholderAlignedToTop_cuttlefish.png
M compose/material/material/outlinedTextField_darkThemeSelectionColors_cuttlefish.png
M compose/material/material/scaffold_topAndBottomAppBar_centerFab_floating_cuttlefish.png
M compose/material3/material3/button_dark_theme_cuttlefish.png
M compose/material/material/filled_textField_focused_errorState_cuttlefish.png
M compose/material/material/filterChip_selected_cuttlefish.png
M compose/material/material/textField_leadingTrailingIcons_error_cuttlefish.png
M compose/material/material/scaffold_topAppBar_endFab_rtl_cuttlefish.png
M compose/material3/material3/alertDialog_withIcon_darkTheme_cuttlefish.png
M compose/material3/material3/elevatedCard_hover_cuttlefish.png
M compose/material/material/scaffold_bottomAppBar_centerFab_floating_cuttlefish.png
M compose/material/material/topAndBottomAppBar_dockedFab_snackbar_cuttlefish.png
M compose/material3/material3/centerAlignedAppBar_darkTheme_cuttlefish.png
M compose/material/material/tabs_darkTheme_defaultColors_pressed_cuttlefish.png
M wear/compose/material/button_rtl_cuttlefish.png
M compose/material3/material3/alertDialog_lightTheme_cuttlefish.png
M compose/material/material/outlined_textField_singleLine_withoutLabel_placeholderCenteredVertically_cuttlefish.png
M compose/material3/material3/text_button_light_theme_cuttlefish.png
M compose/material/material/leadingIconTabs_lightTheme_defaultColors_cuttlefish.png
M compose/material/material/outlined_textField_notFocused_errorState_cuttlefish.png
M compose/material/material/scaffold_topAndBottomAppBar_cuttlefish.png
M compose/material/material/outlined_textField_singleLine_withoutLabel_textCenteredVertically_cuttlefish.png
M compose/material/material/actionChip_cuttlefish.png
M compose/foundation/foundation/multiStyleText_setFontFamily_cuttlefish.png
M compose/material3/material3/color_scheme_dark_dynamic_cuttlefish.png
M compose/material/material/tabs_darkTheme_surfaceColors_pressed_cuttlefish.png
M compose/material3/material3/outlinedCard_hover_cuttlefish.png
M compose/material/material/outlined_textField_singleLine_withLabel_placeholderAlignedToTop_cuttlefish.png
M compose/material/material/outlined_textField_multiLine_withLabel_textAlignedToTop_cuttlefish.png
M compose/material3/material3/button_light_theme_cuttlefish.png
M compose/material/material/scaffold_topAndBottomAppBar_endFab_docked_ltr_cuttlefish.png
M compose/material3/material3/fab_extended_text_and_icon_cuttlefish.png
M compose/material3/material3/text_button_disabled_light_theme_cuttlefish.png
M compose/material3/material3/drawerItem_darkTheme_defaultColors_cuttlefish.png
M compose/material/material/scaffold_topAppBar_cuttlefish.png
M compose/material/material/scaffold_topAndBottomAppBar_endFab_floating_ltr_cuttlefish.png

https://android-review.googlesource.com/1993911

ap...@google.com <ap...@google.com> #53Feb 28, 2022 04:42PM

Project: platform/frameworks/support
Branch: androidx-main

commit b3085385b770c834850a133b07e9b28d5a8adc6d
Author: Siyamed Sinir <siyamed@google.com>
Date: Sun Feb 13 15:52:24 2022

Turn off includeFontPadding

This CL turns off includeFontPadding by default. In order to
prevent tall text clip issues, it applies additional padding when
required.

More details at go/compose-include-font-padding-2

Performance: The major change happened in Paragraph construction for
length of 16 and 32. They regressed around 10%. For example length 16
moved from 0.27ms to 0.31ms (Jio Phone Android 11)

Overall this CL
- turn off includeFontPadding
- add additional padding when the text is higher for only the first
and last line
- update LineHeightSpan to not apply line height to first line
- add demos for the new state

RelNote: "Text: includeFontPadding is now turned off by default. The
clipping issues as a result of includeFontPadding=false is handled
and no clipping should occur for tall scripts.

b/171394808

"

Test: ./gradlew :text:text:test
Test: ./gradlew :text:text:cAT
Test: ./gradlew compose:ui:ui-text:test
Test: ./gradlew compose:ui:ui-text:cAT
Test: ./gradlew compose:foundation:foundation:test
Test: ./gradlew compose:foundation:foundation:cAT

Bug: 171394808
Change-Id: I31c84166ae5241fea3f49e8f293dd9d8a5d712cb

A text/text/src/androidTest/java/androidx/compose/ui/text/android/PaintBoundsTest.kt
M text/text/src/main/java/androidx/compose/ui/text/android/SpannedExtensions.kt
M compose/ui/ui-text/api/restricted_current.txt
M text/text/src/androidTest/java/androidx/compose/ui/text/android/TextLayoutSpanTest.kt
M text/text/src/main/java/androidx/compose/ui/text/android/TextLayout.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/textfield/TextFieldCursorTest.kt
M text/text/src/main/java/androidx/compose/ui/text/android/style/LineHeightSpan.kt
M compose/ui/ui-inspection/src/androidTest/java/androidx/compose/ui/inspection/inspector/LayoutInspectorTreeTest.kt
M compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/platform/AndroidParagraphHelper.android.kt
M compose/ui/ui-text/src/androidAndroidTest/kotlin/androidx/compose/ui/text/ParagraphIntegrationTest.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/OutlinedTextField.kt
A text/text/src/main/java/androidx/compose/ui/text/android/PaintExtensions.kt
A compose/ui/ui-test-font/src/font_ttx/tall_font.ttx
A text/text/src/androidTest/java/androidx/compose/ui/text/android/FontPaddingWithCustomFallbackTest.kt
A compose/ui/ui-test-font/src/commonMain/resources/font/tall_font.ttf
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/text/TextDemos.kt
A text/text/src/androidTest/java/androidx/compose/ui/text/android/FontPaddingTest.kt
M compose/ui/ui-text/src/androidAndroidTest/kotlin/androidx/compose/ui/text/ParagraphFillBoundingBoxesTest.kt
M compose/ui/ui-text/src/androidAndroidTest/kotlin/androidx/compose/ui/text/TextTestExtensions.kt
M text/text/src/main/java/androidx/compose/ui/text/android/LayoutCompat.kt
M compose/ui/ui-text/api/public_plus_experimental_current.txt
M compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/platform/AndroidParagraph.android.kt
M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/textfield/OutlinedTextFieldTest.kt
A compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/text/ComposeFontPadding.kt
M compose/ui/ui-inspection/build.gradle
M compose/ui/ui-text/api/current.txt
M compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/platform/extensions/SpannableExtensions.android.kt

https://android-review.googlesource.com/1992050

si...@google.com <si...@google.com> #54Mar 12, 2022 09:32PM

Note: it is reported that the line height related changes cause discrepancy between different script types (i.e. latin & CJK) aosp/2022417

See

Message last modified on Mar 13, 2022 04:02PM

si...@google.com <si...@google.com> Mar 13, 2022 05:56PM

Accepted by si...@google.com.

ap...@google.com <ap...@google.com> #55Mar 21, 2022 06:53PM

Project: platform/frameworks/support
Branch: androidx-main

commit 610346f638983d151c85b0328fa3b3498096543d
Author: Siyamed Sinir <siyamed@google.com>
Date: Sat Mar 19 10:15:06 2022

Fix selection & getLineBottom with top/bottom padding

When includeFontPadding is false TextLayout adds additional padding
around the original Android layout to prevent clipping (aosp/1992050).

In such cases getLineBottom returns the line bottom from the
previously clipped case. This CL adds the bottomPadding to the last
line bottom, and a test for it.

Moreover, when topPadding is set to a non-zero value, selection is
drawn higher than it should be. This CL fixes the selection path
by offsetting it by topPadding to draw in its original location.
However offsetting does not correct the height of the selection for
each line.

Note: SelectionPathHelper is added in the first version of this CL
to illustrate a patch to draw all of selection with the correct
height. However it is not clear if the visual fix is worth the
any performance cost.

Test: New test
Test: ./gradlew :text:text:test
Test: ./gradlew :text:text:cAT
Test: ./gradlew compose:ui:ui-text:test
Test: ./gradlew compose:ui:ui-text:cAT

Bug: 171394808
Change-Id: I22673819a80c9b6ba4d8ad10a2bb020b348c9e27

M text/text/src/androidTest/java/androidx/compose/ui/text/android/FontPaddingWithCustomFallbackTest.kt
M text/text/src/main/java/androidx/compose/ui/text/android/TextLayout.kt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/text/ComposeFontPadding.kt

https://android-review.googlesource.com/2032846

ap...@google.com <ap...@google.com> #56Mar 22, 2022 03:38AM

Project: platform/frameworks/support
Branch: androidx-main

commit 8e2ae729dd4266a6ee955caf2e65135a3cbb99ba
Author: Siyamed Sinir <siyamed@google.com>
Date: Thu Mar 10 08:23:44 2022

Add deprecated includeFontPadding

aosp/1992050 turned off includeFontPadding by default.
This CL adds platform configuration options for TextStyle,
SpanStyle and ParagraphStyle that includes includeFontPadding param.

Other attempts/ideas
* aosp/2020339
* aosp/2025246

RelNote: "Added temporary compatibility configuration for
includeFontPadding in TextStyle/ParagraphStyle. includeFontPadding
can be changed via TextStyle(platformStyle =
PlatformTextStyle(includeFontPadding = true/false)). This is a
temporary configuration option to enable migration and will be
removed."

Test: New tests
Test: ./gradlew compose:ui:ui-text:test
Test: ./gradlew compose:ui:ui-text:cAT
Test: DemoApp
Test: Treehugger
Test: ANDROIDX_PROJECTS=COMPOSE ./gradlew jvmTest desktopTest \
-Pandroidx.compose.multiplatformEnabled=true --no-daemon
Test: ANDROIDX_PROJECTS=COMPOSE ./gradlew \
:compose:desktop:desktop:desktop-samples:run \
-Pandroidx.compose.multiplatformEnabled=true --no-daemon

Bug: 171394808
Change-Id: If47be074f53de9ccf12af114648b21e25722d166

M compose/ui/ui-inspection/src/androidTest/java/androidx/compose/ui/inspection/inspector/ParameterFactoryTest.kt
M compose/ui/ui-text/api/restricted_current.txt
M compose/ui/ui-text/src/androidAndroidTest/kotlin/androidx/compose/ui/text/platform/AndroidParagraphTest.kt
M compose/ui/ui-test-font/src/commonMain/resources/font/sample_font.ttf
M compose/ui/ui-text/src/test/java/androidx/compose/ui/text/TextStyleResolveDefaultsTest.kt
A compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/PlatformTextStyle.kt
M compose/ui/ui-text/src/androidAndroidTest/kotlin/androidx/compose/ui/text/ParagraphIntegrationTest.kt
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/TextStyle.kt
M compose/ui/ui-text/src/test/java/androidx/compose/ui/text/ParagraphStyleTest.kt
M compose/ui/ui-text/src/test/java/androidx/compose/ui/text/TextSpanParagraphStyleTest.kt
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/SpanStyle.kt
M compose/ui/ui-text/src/test/java/androidx/compose/ui/text/SpanStyleTest.kt
A compose/ui/ui-text/src/skikoMain/kotlin/androidx/compose/ui/text/DesktopTextStyle.skiko.kt
A compose/ui/ui-text/src/androidAndroidTest/kotlin/androidx/compose/ui/text/PlatformSpanStyleTest.kt
M compose/ui/ui-test-font/src/font_ttx/sample_font.ttx
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/ParagraphStyle.kt
M compose/ui/ui-text/src/test/java/androidx/compose/ui/text/TextStyleTest.kt
A compose/ui/ui-text/src/androidAndroidTest/kotlin/androidx/compose/ui/text/PlatformTextStyleTest.kt
A compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/AndroidTextStyle.android.kt
A compose/ui/ui-text/src/androidAndroidTest/kotlin/androidx/compose/ui/text/PlatformParagraphStyleTest.kt
M compose/ui/ui-text/api/public_plus_experimental_current.txt
M compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/platform/AndroidParagraph.android.kt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/text/ComposeFontPadding.kt
M compose/ui/ui-text/api/current.txt

https://android-review.googlesource.com/2028663

si...@google.com <si...@google.com> #57Mar 23, 2022 09:07PM

Marked as fixed.

Thanks for all your feedback.

In the current state:

we have turned off includeFontPadding
prevented font clippings that would normally occur, and backported it
Added an experimental/deprecated API to help with transition in case default value does not work for you right now: TextStyle(platformStyle = PlatformTextStyle(includeFontPadding = true/false)

Message last modified on Mar 23, 2022 10:00PM

ap...@google.com <ap...@google.com> #58Mar 28, 2022 05:46PM

Project: platform/frameworks/support
Branch: androidx-main

commit 8263dbf4386be7a8e53dc809f83cb0eb84329d06
Author: Siyamed Sinir <siyamed@google.com>
Date: Sun Mar 27 22:11:27 2022

includeFontPadding line height fix

When we disabled includeFontPadding, because of the differences
between platform versions, we updated LineHeightSpan not to apply
line height to first line. This might be causing small rounding (1px)
differences between the line heights of 1st and the rest of the lines.

This CL updates AndroidParagraphHelper to return to the state before
includeFontPadding changes if includeFontPadding is true.

Finally, canvas.translate is not needed to be called if the
topPadding is 0. This CL updates TextLayout.kt not to translate if
topPadding is 0.

Test: ./gradlew text:text:test
Test: ./gradlew text:text:cAT
Test: ./gradlew compose:ui:ui-text:test
Test: ./gradlew compose:ui:ui-text:cAT
Test: Manual Test in demo app

Bug: 171394808
Bug: 227095468

Change-Id: I112732a542b47b373d6b45992b9758f1bed0b668

M compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/platform/AndroidParagraphHelper.android.kt
M compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/platform/AndroidParagraph.android.kt
M text/text/src/main/java/androidx/compose/ui/text/android/TextLayout.kt

https://android-review.googlesource.com/2043668

ap...@google.com <ap...@google.com> #59Mar 28, 2022 06:55PM

Project: platform/frameworks/support
Branch: androidx-main

commit e752cae9056f9bf8d272f822e64f0e2ec4d0c07d
Author: Siyamed Sinir <siyamed@google.com>
Date: Sun Mar 27 09:06:15 2022

Fix TextStyle.canReuseLayout when platformStyle changes

When platformStyle was added, this function didn't compare
platformStyle.

Test: Added tests
Test: ./gradlew compose:ui:ui-text:test
Test: ./gradlew compose:ui:ui-text:cAT
Test: ./gradlew compose:foundation:foundation:test
Test: ./gradlew compose:foundation:foundation:cAT

Bug: 171394808
Change-Id: Ia5e867dc6419162c9f3db99def86f03e8f4ada9f

M compose/foundation/foundation/src/test/kotlin/androidx/compose/foundation/text/TextLayoutHelperTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/TextLayoutHelper.kt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/text/TextDemos.kt
A compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/text/ComposeReuseLayout.kt

https://android-review.googlesource.com/2045375

ap...@google.com <ap...@google.com> #60Mar 31, 2022 04:53PM

Project: platform/frameworks/support
Branch: androidx-main

commit 5dad3878a8895c328bfb596f44098f3c98789e18
Author: Siyamed Sinir <siyamed@google.com>
Date: Tue Mar 29 07:37:42 2022

Add tests for aosp/2043668

Adds test for first line lineHeight issue fixed in aosp/2043668

Also address open comment for aosp/2045375: add class comment to the
demo screen named ComposeReuseLayout.kt

Test: Added tests
Test: ./gradlew compose:ui:ui-text:test
Test: ./gradlew compose:ui:ui-text:cAT
Test: ./gradlew text:text:test
Test: ./gradlew text:text:cAT

Bug: 171394808
Bug: 227095468
Change-Id: I4562b9abd80ab057b2b5abcf82b81521e5d60a4b

M text/text/src/main/java/androidx/compose/ui/text/android/style/LineHeightSpan.kt
M compose/ui/ui-text/src/androidAndroidTest/kotlin/androidx/compose/ui/text/platform/AndroidParagraphTest.kt
M text/text/src/androidTest/java/androidx/compose/ui/text/android/TextLayoutIntrinsicWidthTest.kt
M compose/ui/ui-text/src/androidAndroidTest/kotlin/androidx/compose/ui/text/ParagraphIntegrationTest.kt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/text/ComposeReuseLayout.kt
M compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/platform/extensions/SpannableExtensions.android.kt

https://android-review.googlesource.com/2047703

ap...@google.com <ap...@google.com> #61Apr 15, 2022 03:20PM

Project: platform/frameworks/support-golden
Branch: androidx-main

commit 51b941b3c03a8dcabf041b6f5bcbcc82c1032460
Author: Siyamed Sinir <siyamed@google.com>
Date: Thu Apr 14 02:01:24 2022

Update screenshot tests for includeFontPadding=true

Related: aosp/2059410

Bug: 171394808

Change-Id: I6195e6a1bd2e803a9de80a862bafcf08cb1d31f6

M wear/compose/material/swiped_to_right_50_percent_ltr_cuttlefish.png
M compose/material/material/tabs_lightTheme_defaultColors_cuttlefish.png
M compose/material3/material3/elevatedCard_disabled_darkTheme_cuttlefish.png
M compose/material3/material3/outlined_textField_singleLine_labelCenteredVetically_cuttlefish.png
M compose/material/material/fab_text_cuttlefish.png
M compose/material3/material3/centerAlignedAppBar_lightTheme_cuttlefish.png
M compose/material3/material3/outlinedTextField_leadingTrailingIcons_error_cuttlefish.png
M compose/material3/material3/outlined_textField_focused_errorState_dark_cuttlefish.png
M compose/material/material/outlinedTextField_readOnly_focused_cuttlefish.png
M compose/material/material/tabs_lightTheme_surfaceColors_pressed_cuttlefish.png
M compose/material/material/outlined_textField_focused_cuttlefish.png
M compose/material/material/outlined_textField_withInput_cuttlefish.png
M compose/material3/material3/drawerItem_darkTheme_defaultColors_pressed_cuttlefish.png
M compose/material/material/filterChip_disabled_notSelected_cuttlefish.png
M compose/material/material/outlined_textField_focused_errorState_cuttlefish.png
M compose/material3/material3/color_scheme_light_cuttlefish.png
M compose/material3/material3/outlined_textField_singleLine_withoutLabel_placeholderCenteredVertically_cuttlefish.png
M compose/material/material/outlined_textField_singleLine_withLabel_textAlignedToTop_cuttlefish.png
M compose/material3/material3/filledCard_disabled_darkTheme_cuttlefish.png
M compose/material/material/scaffold_bottomAppBar_centerFab_docked_noCutout_cuttlefish.png
M compose/material/material/scaffold_bottomAppBar_endFab_docked_ltr_cuttlefish.png
M compose/material3/material3/filled_textField_withInput_cuttlefish.png
M compose/material3/material3/filled_textField_singleLine_withoutLabel_placeholderCenteredVertically_cuttlefish.png
M compose/material/material/filled_textField_not_focused_cuttlefish.png
M compose/material/material/filled_textField_singleLine_withoutLabel_placeholderCenteredVertically_cuttlefish.png
M compose/material3/material3/filled_tonal_button_light_theme_cuttlefish.png
M compose/material/material/scaffold_topAndBottomAppBar_centerFab_docked_cuttlefish.png
M compose/material3/material3/outlinedCard_disabled_darkTheme_cuttlefish.png
M compose/material/material/scaffold_bottomAppBar_cuttlefish.png
M compose/material/material/textField_readOnly_cuttlefish.png
M compose/material3/material3/snackbar_withDismiss_darkTheme_cuttlefish.png
M compose/material/material/scaffold_topAppBar_endFab_ltr_cuttlefish.png
M compose/foundation/foundation/multiStyleText_setFontStyle_cuttlefish.png
M compose/material3/material3/textField_leadingTrailingIcons_cuttlefish.png
M wear/compose/material/togglebutton_disabled_cuttlefish.png
M wear/compose/material/button_ltr_cuttlefish.png
M compose/material3/material3/snackbar_darkTheme_cuttlefish.png
M compose/material3/material3/filledCard_lightTheme_cuttlefish.png
M compose/material3/material3/outlined_textField_not_focused_cuttlefish.png
M compose/material/material/topAndBottomAppBar_floatingFab_snackbar_cuttlefish.png
M compose/material3/material3/filledTextField_darkThemeSelectionColors_cuttlefish.png
M compose/material/material/outlined_textField_focused_rtl_cuttlefish.png
M compose/material/material/leadingIconTabs_darkTheme_defaultColors_cuttlefish.png
M compose/material3/material3/outlinedCard_lightTheme_cuttlefish.png
M compose/material/material/text_darkThemeSelectionColors_cuttlefish.png
M compose/material/material/dialog_noTitleOrText_cuttlefish.png
M wear/compose/material/compactbutton_rtl_cuttlefish.png
M wear/compose/material/swiped_to_right_50_percent_rtl_cuttlefish.png
M compose/material3/material3/outlinedTextField_leadingTrailingIcons_cuttlefish.png
M compose/material3/material3/elevatedCard_pressed_cuttlefish.png
M compose/foundation/foundation/text_defaultSelectionColors_cuttlefish.png
M compose/material/material/filled_textField_notFocused_errorState_cuttlefish.png
M compose/material3/material3/fab_extended_animation_cuttlefish.png
M compose/material/material/outlinedTextField_readOnly_cuttlefish.png
M compose/material3/material3/outlined_button_light_theme_cuttlefish.png
M compose/material/material/outlinedTextField_disabled_notFocusable_cuttlefish.png
M compose/material3/material3/snackbar_withDismiss_lightTheme_cuttlefish.png
M compose/material3/material3/filled_textField_textColor_customTextColor_cuttlefish.png
M compose/material/material/tabs_lightTheme_surfaceColors_cuttlefish.png
M compose/material/material/filledTextField_lightThemeSelectionColors_cuttlefish.png
M compose/material3/material3/filledCard_pressed_cuttlefish.png
M compose/material/material/outlined_textField_multiLine_withLabel_placeholderAlignedToTop_cuttlefish.png
M compose/material3/material3/filled_textField_focused_errorState_cuttlefish.png
M compose/material/material/outlined_textField_singleLine_labelCenteredVetically_cuttlefish.png
M compose/material/material/textField_leadingTrailingIcons_cuttlefish.png
M compose/material3/material3/filledCard_darkTheme_cuttlefish.png
M compose/material3/material3/alertDialog_darkTheme_cuttlefish.png
M compose/material/material/filled_textField_singleLine_withLabel_textAlignedToTop_cuttlefish.png
M compose/material/material/outlined_textField_textColor_defaultContentColor_cuttlefish.png
M compose/material/material/tabs_darkTheme_defaultColors_cuttlefish.png
M compose/material/material/topAndBottomAppBar_snackbar_cuttlefish.png
M compose/material3/material3/outlinedTextField_leadingTrailingIcons_dark_cuttlefish.png
M compose/material3/material3/outlinedCard_pressed_cuttlefish.png
M compose/material3/material3/elevated_button_light_theme_cuttlefish.png
M compose/material/material/dialog_onlyTitle_cuttlefish.png
M compose/material/material/outlinedTextField_textAlignedToEnd_cuttlefish.png
M compose/material/material/filledTextField_darkThemeSelectionColors_cuttlefish.png
M compose/material3/material3/outlined_textField_withInput_dark_cuttlefish.png
M compose/foundation/foundation/textField_customSelectionColors_cuttlefish.png
M compose/material3/material3/outlined_textField_singleLine_withLabel_textAlignedToTop_cuttlefish.png
M compose/material3/material3/filledCard_hover_cuttlefish.png
M compose/material/material/tabs_darkTheme_surfaceColors_cuttlefish.png
M compose/material/material/outlined_textField_multiLine_withoutLabel_placeholderAlignedToTop_cuttlefish.png
M compose/material/material/outlinedTextField_darkThemeSelectionColors_cuttlefish.png
M compose/material/material/scaffold_topAndBottomAppBar_centerFab_floating_cuttlefish.png
M compose/material3/material3/button_dark_theme_cuttlefish.png
M compose/material/material/scaffold_topAppBar_endFab_rtl_cuttlefish.png
M compose/material3/material3/outlinedTextField_readOnly_scrolled_cuttlefish.png
M compose/material3/material3/elevatedCard_hover_cuttlefish.png
M compose/material/material/scaffold_bottomAppBar_centerFab_floating_cuttlefish.png
M compose/material3/material3/filled_textField_not_focused_cuttlefish.png
M compose/material/material/outlined_textField_singleLine_withoutLabel_placeholderCenteredVertically_cuttlefish.png
M compose/material/material/actionChip_cuttlefish.png
M compose/foundation/foundation/multiStyleText_setFontFamily_cuttlefish.png
M compose/material3/material3/filled_textField_singleLine_labelCenteredVetically_cuttlefish.png
M compose/material3/material3/color_scheme_dark_dynamic_cuttlefish.png
M compose/material/material/tabs_darkTheme_surfaceColors_pressed_cuttlefish.png
M compose/material/material/outlined_textField_singleLine_withLabel_placeholderAlignedToTop_cuttlefish.png
M compose/material3/material3/filled_textField_singleLine_withLabel_textAlignedToTop_cuttlefish.png
M compose/material3/material3/drawerItem_darkTheme_defaultColors_cuttlefish.png
M compose/material/material/scaffold_topAndBottomAppBar_endFab_floating_ltr_cuttlefish.png
M compose/material3/material3/filledTextField_lightThemeSelectionColors_cuttlefish.png
M wear/compose/material/button_disabled_cuttlefish.png
M wear/compose/material/compactbutton_ltr_cuttlefish.png
M compose/material/material/actionChip_disabled_cuttlefish.png
M compose/material3/material3/textField_readOnly_focused_cuttlefish.png
M compose/material3/material3/filled_textField_withInput_dark_cuttlefish.png
M compose/material/material/scaffold_bottomAppBar_centerFab_docked_cuttlefish.png
M compose/material/material/outlinedTextField_disabled_cuttlefish.png
M compose/material3/material3/drawerItem_lightTheme_defaultColors_pressed_cuttlefish.png
M compose/material/material/filled_textField_singleLine_labelCenteredVetically_cuttlefish.png
M compose/material3/material3/text_darkThemeSelectionColors_cuttlefish.png
M compose/material/material/dialog_stackedButtons_cuttlefish.png
M compose/material/material/fab_textAndIcon_cuttlefish.png
M compose/material/material/actionChip_outlined_disabled_cuttlefish.png
M compose/material/material/badge_lightTheme_longContent_tab_cuttlefish.png
M compose/material/material/filterChip_disabled_selected_cuttlefish.png
M compose/material/material/filled_textField_singleLine_withLabel_placeholderAlignedToTop_cuttlefish.png
M wear/compose/material/compactbutton_disabled_cuttlefish.png
M compose/material/material/dialog_onlyText_cuttlefish.png
M compose/material/material/filterChip_notSelected_cuttlefish.png
M compose/material3/material3/tabs_lightTheme_pressed_cuttlefish.png
M compose/material/material/scaffold_bottomAppBar_endFab_floating_ltr_cuttlefish.png
M compose/material3/material3/outlined_textField_textColor_customTextColor_cuttlefish.png
M compose/material3/material3/textField_readOnly_scrolled_cuttlefish.png
M compose/material3/material3/outlinedCard_darkTheme_cuttlefish.png
M compose/material3/material3/outlined_textField_withInput_cuttlefish.png
M compose/material3/material3/drawerItem_lightTheme_defaultColors_cuttlefish.png
M compose/material3/material3/outlinedCard_disabled_lightTheme_cuttlefish.png
M compose/material3/material3/text_lightThemeSelectionColors_cuttlefish.png
M compose/foundation/foundation/multiStyleText_setFontWeight_cuttlefish.png
M compose/material3/material3/filled_tonal_button_disabled_light_theme_cuttlefish.png
M compose/material3/material3/textField_readOnly_cuttlefish.png
M compose/material/material/textField_readOnly_scrolled_cuttlefish.png
M compose/material3/material3/outlined_button_disabled_light_theme_cuttlefish.png
M compose/material3/material3/filled_textField_singleLine_withLabel_placeholderAlignedToTop_cuttlefish.png
M compose/material3/material3/tabs_darkTheme_cuttlefish.png
M compose/material3/material3/elevatedCard_lightTheme_cuttlefish.png
M compose/material3/material3/alertDialog_withIcon_lightTheme_cuttlefish.png
M compose/material3/material3/outlined_textField_notFocused_errorState_cuttlefish.png
M compose/material/material/bottomAppBar_snackbar_cuttlefish.png
M compose/material3/material3/outlinedTextField_darkThemeSelectionColors_cuttlefish.png
M compose/material/material/outlined_textField_multiLine_labelAlignedToTop_cuttlefish.png
M compose/material/material/filterChip_with_leading_icon_selected_cuttlefish.png
M compose/material/material/outlined_textField_multiLine_withoutLabel_textAlignedToTop_cuttlefish.png
M compose/material3/material3/button_disabled_light_theme_cuttlefish.png
M compose/material/material/scaffold_topAndBottomAppBar_endFab_docked_rtl_cuttlefish.png
M compose/material/material/textField_readOnly_focused_cuttlefish.png
M compose/material/material/tabs_darkTheme_primaryColors_cuttlefish.png
M compose/material/material/outlinedTextField_textCenterAligned_cuttlefish.png
M compose/material/material/topAppBar_snackbar_cuttlefish.png
M compose/material/material/scaffold_topAndBottomAppBar_endFab_floating_rtl_cuttlefish.png
M compose/material3/material3/snackbar_lightTheme_cuttlefish.png
M compose/material/material/outlined_textField_not_focused_cuttlefish.png
M compose/material3/material3/textField_leadingTrailingIcons_dark_cuttlefish.png
M compose/material/material/filterChip_with_leading_icon_disabled_selected_cuttlefish.png
M compose/material/material/button_default_cuttlefish.png
M compose/material/material/tabs_darkTheme_primaryColors_pressed_cuttlefish.png
M compose/material3/material3/snackbar_withAction_lightTheme_cuttlefish.png
M compose/material/material/scaffold_topAppBar_centerFab_cuttlefish.png
M compose/material3/material3/elevatedCard_focused_cuttlefish.png
M compose/material/material/filled_textField_textColor_defaultContentColor_cuttlefish.png
M compose/material3/material3/elevatedCard_darkTheme_cuttlefish.png
M compose/material/material/outlinedTextField_readOnly_scrolled_cuttlefish.png
M compose/material3/material3/elevated_button_disabled_light_theme_cuttlefish.png
M compose/material3/material3/outlinedTextField_disabled_notScrolled_cuttlefish.png
M compose/material/material/button_disabled_cuttlefish.png
M compose/material3/material3/filled_textField_focused_errorState_dark_cuttlefish.png
M compose/material3/material3/filledCard_disabled_lightTheme_cuttlefish.png
M compose/material/material/actionChip_outlined_cuttlefish.png
M compose/material3/material3/textField_leadingTrailingIcons_error_cuttlefish.png
M compose/material/material/outlinedTextField_disabled_notScrolled_cuttlefish.png
M compose/material3/material3/color_scheme_dark_cuttlefish.png
M compose/material/material/outlinedTextField_leadingTrailingIcons_error_cuttlefish.png
M compose/material/material/outlinedTextField_leadingTrailingIcons_cuttlefish.png
M compose/material3/material3/filledCard_focus_cuttlefish.png
M compose/material/material/filled_textField_withInput_cuttlefish.png
M compose/material3/material3/filled_textField_notFocused_errorState_cuttlefish.png
M compose/material3/material3/color_scheme_light_dynamic_cuttlefish.png
M compose/material3/material3/snackbar_withAction_darkTheme_cuttlefish.png
M compose/material/material/dialog_titleWithoutTextBaseline_cuttlefish.png
M compose/material/material/outlinedTextField_lightThemeSelectionColors_cuttlefish.png
M compose/material3/material3/textField_disabled_notScrolled_cuttlefish.png
M compose/foundation/foundation/textField_defaultSelectionColors_cuttlefish.png
M compose/material/material/dialog_sideBySideButtons_cuttlefish.png
M compose/material3/material3/button_disabled_dark_theme_cuttlefish.png
M compose/material/material/outlinedTextField_customShape_cuttlefish.png
M compose/material/material/scaffold_bottomAppBar_endFab_floating_rtl_cuttlefish.png
M compose/material3/material3/fab_extended_text_cuttlefish.png
M compose/material3/material3/outlinedTextField_readOnly_cuttlefish.png
M compose/foundation/foundation/text_customSelectionColors_cuttlefish.png
M compose/material3/material3/outlinedCard_focused_cuttlefish.png
M compose/material/material/scaffold_bottomAppBar_endFab_docked_rtl_cuttlefish.png
M compose/material3/material3/tabs_lightTheme_cuttlefish.png
M compose/material/material/textField_disabled_notScrolled_cuttlefish.png
M compose/material3/material3/outlinedTextField_lightThemeSelectionColors_cuttlefish.png
M compose/material/material/tabs_lightTheme_defaultColors_pressed_cuttlefish.png
M compose/material/material/snackbar_cuttlefish.png
M compose/material3/material3/tabs_darkTheme_pressed_cuttlefish.png
M compose/material/material/filterChip_selected_cuttlefish.png
M compose/material/material/filled_textField_focused_errorState_cuttlefish.png
M compose/material/material/textField_leadingTrailingIcons_error_cuttlefish.png
M compose/material3/material3/elevatedCard_disabled_lightTheme_cuttlefish.png
M compose/material3/material3/alertDialog_withIcon_darkTheme_cuttlefish.png
M compose/material/material/topAndBottomAppBar_dockedFab_snackbar_cuttlefish.png
M compose/material3/material3/centerAlignedAppBar_darkTheme_cuttlefish.png
M compose/material/material/tabs_darkTheme_defaultColors_pressed_cuttlefish.png
M wear/compose/material/button_rtl_cuttlefish.png
M compose/material3/material3/alertDialog_lightTheme_cuttlefish.png
M compose/material3/material3/text_button_light_theme_cuttlefish.png
M compose/material/material/leadingIconTabs_lightTheme_defaultColors_cuttlefish.png
M compose/material/material/outlined_textField_notFocused_errorState_cuttlefish.png
M compose/material3/material3/outlinedTextField_readOnly_focused_cuttlefish.png
M compose/material/material/outlined_textField_singleLine_withoutLabel_textCenteredVertically_cuttlefish.png
M compose/material/material/scaffold_topAndBottomAppBar_cuttlefish.png
M compose/material3/material3/outlined_textField_singleLine_withLabel_placeholderAlignedToTop_cuttlefish.png
M compose/material3/material3/outlinedCard_hover_cuttlefish.png
M compose/material/material/outlined_textField_multiLine_withLabel_textAlignedToTop_cuttlefish.png
M compose/material3/material3/button_light_theme_cuttlefish.png
M compose/material3/material3/outlined_textField_focused_errorState_cuttlefish.png
M compose/material/material/scaffold_topAndBottomAppBar_endFab_docked_ltr_cuttlefish.png
M compose/material3/material3/fab_extended_text_and_icon_cuttlefish.png
M compose/material3/material3/text_button_disabled_light_theme_cuttlefish.png
M compose/material/material/scaffold_topAppBar_cuttlefish.png

https://android-review.googlesource.com/2064650

ap...@google.com <ap...@google.com> #62Apr 15, 2022 03:20PM

Project: platform/frameworks/support
Branch: androidx-main

commit 85fc924b492636402c5e210641dc69262f89ec32
Author: Siyamed Sinir <siyamed@google.com>
Date: Sat Apr 09 00:50:46 2022

Default includeFontPadding=true

This CL changes the default includeFontPadding back to true.
Previously, for an alpha release we turned it off in aosp/1992050.

This would break some users when switching to the beta/final release.

Moreover, keeping it experimental and optional for now will enable us
to spend a little more time on clipping, line height, text field
related improvements including defining the default line height
behavior with the functionalities in aosp/2058653.

RelNote: "Turned on default includeFontPadding. It is possible to
turn off the includeFontPadding using TextStyle.platformTextStyle
attribute. In the near future we will change the default behavior
however until that time this allows us to better integrate line height
improvements (aosp/2058653) and solve TextField clipping issues."

Test: ./gradlew text:text:test
Test: ./gradlew text:text:cAT
Test: ./gradlew compose:ui:ui-text:test
Test: ./gradlew compose:ui:ui-text:cAT

Bug: 171394808
Change-Id: I01423d9a0042a1f3e462236e1fdadb60a20678fc

M compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/AndroidTextStyle.android.kt
M compose/ui/ui-text/src/androidAndroidTest/kotlin/androidx/compose/ui/text/ParagraphFillBoundingBoxesTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text/selection/TextSelectionColorsScreenshotTest.kt
M compose/ui/ui-text/src/androidAndroidTest/kotlin/androidx/compose/ui/text/ParagraphIntegrationTest.kt

https://android-review.googlesource.com/2059410

si...@google.com <si...@google.com> #63Apr 15, 2022 03:42PM

An update on includeFontPadding

The default value for Compose 1.2 beta and later 1.2 is now the old state which is includeFontPadding=true
It is still possible to opt-in and turn it off via TextStyle( platformStyle = PlatformTextStyle( includeFontPadding = false ) )

co...@protonmail.com <co...@protonmail.com> #64May 3, 2022 01:21AM

@Si...@google.com

Any harm in defaulting to includeFontPadding = false in all of my projects? Seems like it was the default, but got switched and was wondering why the decision to not have includeFontPadding = false by default.

si...@google.com <si...@google.com> #65May 3, 2022 01:31AM

Any harm in defaulting to includeFontPadding = false in all of my projects?

No, as far as we know there is not.

Please check b/228512135 which is about TextField and a natural consequence of a different font with different metrics while editing, and can be fixed by providing line heights (which should work as b/228512135 is fixed and line height for single lines are improved), we will solve it or provide suggestions for it.

Seems like it was the default, but got switched and was wondering why the decision to not have includeFontPadding = false by default.

It was changed to provide opt-in option for the community, and not change their layout (even if it is a small change) without them opting in for Compose 1.2 Beta. We are currently planning to turn it back off as default as described in RelNote section in #comment62:

RelNote: "Turned on default includeFontPadding. It is possible to
turn off the includeFontPadding using TextStyle.platformTextStyle
attribute. In the near future we will change the default behavior
however until that time this allows us to better integrate line height
improvements (aosp/2058653) and solve TextField clipping issues."

co...@protonmail.com <co...@protonmail.com> #66May 3, 2022 06:54AM

Awesome. If it will be turned off by default again then I will just wait for that. Thanks! Looking forward to easier translations from figma to compose =)

ma...@gmail.com <ma...@gmail.com> #67Jul 17, 2022 06:51PM

Comment has been deleted.

Message last modified on Jul 21, 2022 03:34PM

so...@gmail.com <so...@gmail.com> #68Jul 27, 2022 07:48AM

Comment has been deleted.

Message last modified on Jul 27, 2022 07:50AM

ke...@gmail.com <ke...@gmail.com> #69Nov 14, 2023 10:54PM

Any updates? the issue is marked as Fixed for some reason

mi...@gmail.com <mi...@gmail.com> #70Nov 22, 2023 10:19AM

do...@google.com <do...@google.com> #71Feb 22, 2024 06:09PM

Note that the default behavior for includeFontPadding was changed to false from Compose 1.6 onwards. More info: https://medium.com/androiddevelopers/fixing-font-padding-in-compose-text-768cd232425b

Issue 171394808

Description

Issue summary

Comments

nj...@google.com <nj...@google.com> Oct 22, 2020 01:00AM

si...@google.com <si...@google.com> Dec 9, 2020 10:10PM

si...@google.com <si...@google.com> #2Feb 23, 2021 11:11PM

si...@google.com <si...@google.com> #3Feb 23, 2021 11:13PM

si...@google.com <si...@google.com> #4Feb 23, 2021 11:17PM

pa...@gmail.com <pa...@gmail.com> #5Apr 2, 2021 09:45PM

1s...@gmail.com <1s...@gmail.com> #6Jun 13, 2021 01:04PM

co...@protonmail.com <co...@protonmail.com> #7Jun 14, 2021 04:06PM

al...@gmail.com <al...@gmail.com> #8Jun 17, 2021 06:24PM

ma...@gmail.com <ma...@gmail.com> #9Jul 14, 2021 07:08PM

ka...@gmail.com <ka...@gmail.com> #10Jul 19, 2021 02:16PM

to...@gmail.com <to...@gmail.com> #11Jul 22, 2021 09:06AM

ci...@gmail.com <ci...@gmail.com> #12Jul 23, 2021 05:17PM

[Deleted User] <[Deleted User]> #13Jul 26, 2021 04:52AM

dj...@gmail.com <dj...@gmail.com> #14Aug 1, 2021 02:47PM

[Deleted User] <[Deleted User]> #15Aug 3, 2021 05:23AM

kr...@gmail.com <kr...@gmail.com> #16Aug 19, 2021 08:50AM

i....@getorca.app <i....@getorca.app> #17Aug 25, 2021 05:11PM

ha...@google.com <ha...@google.com> Aug 25, 2021 08:53PM

sm...@gmail.com <sm...@gmail.com> #18Aug 27, 2021 08:38AM

zh...@gmail.com <zh...@gmail.com> #19Aug 28, 2021 05:04PM

ti...@soufan.com.br <ti...@soufan.com.br> #20Aug 30, 2021 10:52AM

jr...@gmail.com <jr...@gmail.com> #21Sep 7, 2021 05:51PM

su...@gmail.com <su...@gmail.com> #22Sep 15, 2021 07:34PM

iv...@gmail.com <iv...@gmail.com> #23Sep 17, 2021 12:06PM

ha...@google.com <ha...@google.com> #24Sep 17, 2021 10:40PM

iv...@gmail.com <iv...@gmail.com> #25Sep 18, 2021 05:26PM

ta...@gmail.com <ta...@gmail.com> #26Sep 18, 2021 06:19PM

iv...@gmail.com <iv...@gmail.com> #27Sep 18, 2021 06:54PM

[Deleted User] <[Deleted User]> #28Sep 19, 2021 03:56PM

jo...@pucp.pe <jo...@pucp.pe> #29Sep 21, 2021 03:21AM

se...@gmail.com <se...@gmail.com> #30Sep 27, 2021 10:35PM

fo...@gmail.com <fo...@gmail.com> #31Oct 7, 2021 09:54AM

mx...@gmail.com <mx...@gmail.com> #32Oct 7, 2021 10:34AM

im...@gmail.com <im...@gmail.com> #33Oct 8, 2021 02:20PM

[Deleted User] <[Deleted User]> #34Oct 10, 2021 10:01AM

lc...@gmail.com <lc...@gmail.com> #35Oct 10, 2021 10:04AM

f....@gmail.com <f....@gmail.com> #36Oct 11, 2021 07:58PM

bo...@gmail.com <bo...@gmail.com> #37Oct 19, 2021 02:13PM

si...@google.com <si...@google.com> Nov 17, 2021 02:43AM

jp...@spoton.com <jp...@spoton.com> #38Nov 19, 2021 03:07PM

[Deleted User] <[Deleted User]> #39Dec 15, 2021 09:30PM

mi...@gmail.com <mi...@gmail.com> #40Dec 16, 2021 03:29AM

ch...@googlemail.com <ch...@googlemail.com> #41Jan 5, 2022 12:58PM

[Deleted User] <[Deleted User]> #42Jan 9, 2022 06:58PM

ji...@hotstar.com <ji...@hotstar.com> #43Jan 13, 2022 10:43AM

si...@gmail.com <si...@gmail.com> #44Jan 13, 2022 10:56AM

ag...@gmail.com <ag...@gmail.com> #45Jan 19, 2022 02:44PM

me...@gmail.com <me...@gmail.com> #46Jan 24, 2022 02:09PM

si...@google.com <si...@google.com> Jan 25, 2022 05:17PM

so...@google.com <so...@google.com> Jan 25, 2022 05:59PM

[Deleted User] <[Deleted User]> #47Feb 5, 2022 02:45PM

vi...@gmail.com <vi...@gmail.com> #48Feb 11, 2022 09:23AM

gu...@gmail.com <gu...@gmail.com> #49Feb 13, 2022 06:49AM

si...@google.com <si...@google.com> #50Feb 13, 2022 11:51PM

si...@google.com <si...@google.com> #51Feb 14, 2022 04:59AM

ap...@google.com <ap...@google.com> #52Feb 28, 2022 04:42PM

ap...@google.com <ap...@google.com> #53Feb 28, 2022 04:42PM

si...@google.com <si...@google.com> #54Mar 12, 2022 09:32PM

si...@google.com <si...@google.com> Mar 13, 2022 05:56PM

ap...@google.com <ap...@google.com> #55Mar 21, 2022 06:53PM

ap...@google.com <ap...@google.com> #56Mar 22, 2022 03:38AM

si...@google.com <si...@google.com> #57Mar 23, 2022 09:07PM

ap...@google.com <ap...@google.com> #58Mar 28, 2022 05:46PM

ap...@google.com <ap...@google.com> #59Mar 28, 2022 06:55PM

ap...@google.com <ap...@google.com> #60Mar 31, 2022 04:53PM

ap...@google.com <ap...@google.com> #61Apr 15, 2022 03:20PM

ap...@google.com <ap...@google.com> #62Apr 15, 2022 03:20PM

si...@google.com <si...@google.com> #63Apr 15, 2022 03:42PM

co...@protonmail.com <co...@protonmail.com> #64May 3, 2022 01:21AM

si...@google.com <si...@google.com> #65May 3, 2022 01:31AM

co...@protonmail.com <co...@protonmail.com> #66May 3, 2022 06:54AM

ma...@gmail.com <ma...@gmail.com> #67Jul 17, 2022 06:51PM

so...@gmail.com <so...@gmail.com> #68Jul 27, 2022 07:48AM

ke...@gmail.com <ke...@gmail.com> #69Nov 14, 2023 10:54PM

mi...@gmail.com <mi...@gmail.com> #70Nov 22, 2023 10:19AM