Status Update
Comments
nj...@google.com <nj...@google.com>
si...@google.com <si...@google.com>
si...@google.com <si...@google.com> #2
Branch: androidx-main
commit 0154910724cdc44253af1d2f8cede76264783226
Author: Aurimas Liutikas <aurimas@google.com>
Date: Thu Jun 27 15:25:02 2024
Expand native target support for annotation and collection libraries
- Enable watchos and tvos download in importMaven
- Add support for watchos and tvos targets in AndroidXMultiplatformExtension
- Enable watchos and tvos in :annotation:annotation
- Enable linuxArm64, watchos, and tvos in :collection:collection
This work is required as we work towards setting up native stubs for
compose projects.
Test: ./gradlew collection:collection:publish
Bug: 349894318
Change-Id: Idfd1faa3a826bb91ee14722f7437bdcf99cf0018
M annotation/annotation/build.gradle
M buildSrc/private/src/main/kotlin/androidx/build/AndroidXMultiplatformExtension.kt
M buildSrc/public/src/main/kotlin/androidx/build/KmpPlatforms.kt
M collection/collection/build.gradle
M development/build_log_simplifier/messages.ignore
M development/importMaven/src/main/kotlin/androidx/build/importMaven/KmpConfig.kt
si...@google.com <si...@google.com> #3
Branch: androidx-main
commit 39cd1e9f7579513bde139c17f9c51f9012d56152
Author: Aurimas Liutikas <aurimas@google.com>
Date: Thu Jun 27 15:25:02 2024
Expand native target support for annotation and collection libraries
Reland
- Enable watchos and tvos download in importMaven
- Add support for watchos and tvos targets in AndroidXMultiplatformExtension
- Enable watchos and tvos in :annotation:annotation
- Enable linuxArm64, watchos, and tvos in :collection:collection
This work is required as we work towards setting up native stubs for
compose projects.
Test: ./gradlew collection:collection:publish
Bug: 349894318
Change-Id: Ic795af8486db48b31633799e06665717d08398db
M annotation/annotation/build.gradle
M buildSrc/private/src/main/kotlin/androidx/build/AndroidXMultiplatformExtension.kt
M buildSrc/public/src/main/kotlin/androidx/build/KmpPlatforms.kt
M collection/collection/build.gradle
M development/build_log_simplifier/messages.ignore
M development/importMaven/src/main/kotlin/androidx/build/importMaven/KmpConfig.kt
si...@google.com <si...@google.com> #4
Branch: androidx-main
commit c3a06e79cf427aef1cf0ede1bacb463eb89472be
Author: Aurimas Liutikas <aurimas@google.com>
Date: Thu Jun 27 15:25:02 2024
Expand native target support for annotation and collection libraries
Reland
moving to project(":annotation:annotation") in commonMain as due to
project in one source set and prebuilt in the other.
- Enable watchos and tvos download in importMaven
- Add support for watchos and tvos targets in AndroidXMultiplatformExtension
- Enable watchos and tvos in :annotation:annotation
- Enable linuxArm64, watchos, and tvos in :collection:collection
This work is required as we work towards setting up native stubs for
compose projects.
Test: ./gradlew collection:collection:publish
Bug: 349894318
Change-Id: I7f2a1bddbe79ab5e920cdb01ca6a428950a8c2c3
M annotation/annotation/build.gradle
M buildSrc/private/src/main/kotlin/androidx/build/AndroidXMultiplatformExtension.kt
M buildSrc/public/src/main/kotlin/androidx/build/KmpPlatforms.kt
M busytown/androidx_multiplatform_mac_host_tests_arm64.sh
M camera/integration-tests/avsynctestapp/build.gradle
M collection/collection/build.gradle
M development/build_log_simplifier/messages.ignore
M development/importMaven/src/main/kotlin/androidx/build/importMaven/KmpConfig.kt
M test/uiautomator/integration-tests/testapp/build.gradle
M wear/compose/integration-tests/navigation/build.gradle
pa...@gmail.com <pa...@gmail.com> #5
Branch: androidx-main
commit c56a2faf24c82bf961cb10440156745bf3cf30bd
Author: Aurimas Liutikas <aurimas@google.com>
Date: Wed Jul 03 11:10:40 2024
Add linuxX64Stubs for compose runtime libraries
- Add support for linuxX64Stubs
- Add these linuxX64Stubs to compose runtime projects
- Move OperationsTest from commonTest to jvmTest as it has
jvm-reflection usages
Bug: 349894318
Test: ./gradlew -p compose/runtime build
Change-Id: Ia600fafb174b585cf5a0d7a7f3c3726d10b4cc92
M buildSrc/private/src/main/kotlin/androidx/build/AndroidXMultiplatformExtension.kt
M buildSrc/public/src/main/kotlin/androidx/build/KmpPlatforms.kt
M compose/runtime/runtime-saveable/build.gradle
M compose/runtime/runtime-test-utils/build.gradle
A compose/runtime/runtime-test-utils/src/commonMain/kotlin/androidx/compose/runtime/mock/SynchronizedObject.kt
M compose/runtime/runtime-test-utils/src/commonMain/kotlin/androidx/compose/runtime/mock/TestMonotonicFrameClock.kt
A compose/runtime/runtime-test-utils/src/jvmMain/kotlin/androidx/compose/runtime/mock/SynchronizedObject.jvm.kt
A compose/runtime/runtime-test-utils/src/linuxx64StubsMain/kotlin/androidx/compose/runtime/mock/SynchronizedObject.linuxx64Stubs.kt
M compose/runtime/runtime/build.gradle
M compose/runtime/runtime/src/commonMain/kotlin/androidx/compose/runtime/Stack.kt
M compose/runtime/runtime/src/commonMain/kotlin/androidx/compose/runtime/collection/ScopeMap.kt
M compose/runtime/runtime/src/commonMain/kotlin/androidx/compose/runtime/snapshots/SnapshotStateSet.kt
M compose/runtime/runtime/src/commonTest/kotlin/androidx/compose/runtime/CompositionTestExtensions.kt
M compose/runtime/runtime/src/jvmTest/kotlin/androidx/compose/runtime/changelist/OperationsTest.kt
A compose/runtime/runtime/src/linuxx64StubsMain/kotlin/androidx/compose/runtime/MonotonicFrameClock.linuxx64Stubs.kt
A compose/runtime/runtime/src/linuxx64StubsMain/kotlin/androidx/compose/runtime/NotImplemented.linuxx64Stubs.kt
A compose/runtime/runtime/src/linuxx64StubsMain/kotlin/androidx/compose/runtime/SynchronizedObject.linuxx64Stubs.kt
A compose/runtime/runtime/src/linuxx64StubsMain/kotlin/androidx/compose/runtime/TestOnly.linuxx64Stubs.kt
A compose/runtime/runtime/src/linuxx64StubsMain/kotlin/androidx/compose/runtime/internal/Atomic.linuxx64Stubs.kt
A compose/runtime/runtime/src/linuxx64StubsMain/kotlin/androidx/compose/runtime/internal/ComposableLambda.linuxx64Stubs.kt
A compose/runtime/runtime/src/linuxx64StubsMain/kotlin/androidx/compose/runtime/internal/JvmDefaultWithCompatibility.linuxx64Stubs.kt
A compose/runtime/runtime/src/linuxx64StubsMain/kotlin/androidx/compose/runtime/internal/Thread.linuxx64Stubs.kt
A compose/runtime/runtime/src/linuxx64StubsMain/kotlin/androidx/compose/runtime/internal/Utils.linuxx64Stubs.kt
A compose/runtime/runtime/src/linuxx64StubsMain/kotlin/androidx/compose/runtime/internal/WeakReference.linuxx64Stubs.kt
A compose/runtime/runtime/src/linuxx64StubsMain/kotlin/androidx/compose/runtime/snapshots/SnapshotContextElement.linuxx64Stubs.kt
A compose/runtime/runtime/src/linuxx64StubsTest/kotlin/kotlinx/test/IgnoreAndroidUnitTestTarget.linuxx64Stubs.kt
A compose/runtime/runtime/src/linuxx64StubsTest/kotlin/kotlinx/test/IgnoreJsTarget.linuxx64Stubs.kt
1s...@gmail.com <1s...@gmail.com> #6
Branch: androidx-main
commit 2363176cf646e7eb7647fcda7186746757fa9353
Author: Aurimas Liutikas <aurimas@google.com>
Date: Mon Jul 08 10:48:51 2024
Convert first batch of compose ui projects to add linuxX64Stubs target
- Disable running linuxx64StubsTest, as they are not representative
of a real environment
- Add all needed stub actuals
Bug: 349894318
Test: ./gradlew -p compose/ui build
Change-Id: I6abbf8d425714a1c6c492e5ea25897fe6f226584
M buildSrc/private/src/main/kotlin/androidx/build/AndroidXImplPlugin.kt
M buildSrc/private/src/main/kotlin/androidx/build/AndroidXMultiplatformExtension.kt
M compose/ui/ui-geometry/build.gradle
M compose/ui/ui-graphics/build.gradle
M compose/ui/ui-graphics/src/androidMain/kotlin/androidx/compose/ui/graphics/internal/JvmDefaultWithCompatibility.android.kt
M compose/ui/ui-graphics/src/commonMain/kotlin/androidx/compose/ui/graphics/Bezier.kt
M compose/ui/ui-graphics/src/commonMain/kotlin/androidx/compose/ui/graphics/Float16.kt
M compose/ui/ui-graphics/src/commonStubsMain/kotlin/androidx/compose/ui/graphics/BlendMode.commonStubs.kt
M compose/ui/ui-graphics/src/commonStubsMain/kotlin/androidx/compose/ui/graphics/Canvas.commonStubs.kt
M compose/ui/ui-graphics/src/commonStubsMain/kotlin/androidx/compose/ui/graphics/ColorFilter.commonStubs.kt
M compose/ui/ui-graphics/src/commonStubsMain/kotlin/androidx/compose/ui/graphics/ImageBitmap.commonStubs.kt
M compose/ui/ui-graphics/src/commonStubsMain/kotlin/androidx/compose/ui/graphics/NotImplemented.commonStubs.kt
M compose/ui/ui-graphics/src/commonStubsMain/kotlin/androidx/compose/ui/graphics/Paint.commonStubs.kt
M compose/ui/ui-graphics/src/commonStubsMain/kotlin/androidx/compose/ui/graphics/Path.commonStubs.kt
M compose/ui/ui-graphics/src/commonStubsMain/kotlin/androidx/compose/ui/graphics/PathEffect.commonStubs.kt
M compose/ui/ui-graphics/src/commonStubsMain/kotlin/androidx/compose/ui/graphics/PathIterator.commonStubs.kt
M compose/ui/ui-graphics/src/commonStubsMain/kotlin/androidx/compose/ui/graphics/PathMeasure.commonStubs.kt
M compose/ui/ui-graphics/src/commonStubsMain/kotlin/androidx/compose/ui/graphics/RenderEffect.commonStubs.kt
M compose/ui/ui-graphics/src/commonStubsMain/kotlin/androidx/compose/ui/graphics/Shader.commonStubs.kt
M compose/ui/ui-graphics/src/commonStubsMain/kotlin/androidx/compose/ui/graphics/TileMode.commonStubs.kt
M compose/ui/ui-graphics/src/commonStubsMain/kotlin/androidx/compose/ui/graphics/internal/JvmDefaultWithCompatibility.commonStubs.kt
M compose/ui/ui-graphics/src/commonStubsMain/kotlin/androidx/compose/ui/graphics/layer/GraphicsLayer.commonStubs.kt
M compose/ui/ui-graphics/src/commonTest/kotlin/androidx/compose/ui/graphics/vector/FastFloatParserTest.kt
M compose/ui/ui-unit/build.gradle
M compose/ui/ui-unit/src/commonMain/kotlin/androidx/compose/ui/unit/Constraints.kt
M compose/ui/ui-unit/src/commonMain/kotlin/androidx/compose/ui/unit/Dp.kt
M compose/ui/ui-unit/src/commonMain/kotlin/androidx/compose/ui/unit/IntOffset.kt
M compose/ui/ui-unit/src/linuxx64StubsMain/kotlin/androidx/compose/ui/unit/FontScaling.linuxx64Stubs.kt
M compose/ui/ui-unit/src/linuxx64StubsMain/kotlin/androidx/compose/ui/unit/internal/JvmDefaultWithCompatibility.linuxx64Stubs.kt
M compose/ui/ui-util/build.gradle
M compose/ui/ui-util/src/commonStubsMain/kotlin/androidx/compose/ui/util/NotImplemented.commonStubs.kt
M compose/ui/ui-util/src/commonStubsMain/kotlin/androidx/compose/ui/util/Trace.commonStubs.kt
M compose/ui/ui-util/src/linuxx64StubsMain/kotlin/androidx/compose/ui/util/InlineClassHelper.linuxx64Stubs.kt
co...@protonmail.com <co...@protonmail.com> #7
Branch: androidx-main
commit 2df44b893c1b8ac2f29610fb5d3581c6e6fa4d08
Author: Aurimas Liutikas <aurimas@google.com>
Date: Mon Jul 08 13:29:56 2024
Convert compose ui-text project to add linuxX64Stubs target
- Add all needed stub actuals
Bug: 349894318
Test: ./gradlew -p compose/ui build
Change-Id: I9631b90838a22c1d38c51e1c0e53caee3747f083
M compose/ui/ui-text/build.gradle
M compose/ui/ui-text/src/androidUnitTest/kotlin/androidx/compose/ui/text/SaversTest.kt
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/AnnotatedString.kt
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/ParagraphStyle.kt
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/StringAnnotation.kt
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/TextGranularity.kt
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/TextStyle.kt
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/input/GapBuffer.kt
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/style/Hyphens.kt
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/style/LineHeightStyle.kt
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/style/TextForegroundStyle.kt
M compose/ui/ui-text/src/jvmStubsMain/kotlin/androidx/compose/ui/text/style/LineBreak.jvmStubs.kt
M compose/ui/ui-text/src/jvmStubsMain/kotlin/androidx/compose/ui/text/style/TextMotion.jvmStubs.kt
A compose/ui/ui-text/src/linuxx64StubsMain/kotlin/androidx/compose/ui/text/ActualAtomicReferenceJvm.linuxx64Stubs.kt
A compose/ui/ui-text/src/linuxx64StubsMain/kotlin/androidx/compose/ui/text/AnnotatedString.linuxx64Stubs.kt
A compose/ui/ui-text/src/linuxx64StubsMain/kotlin/androidx/compose/ui/text/JvmCharHelpers.linuxx64Stubs.kt
A compose/ui/ui-text/src/linuxx64StubsMain/kotlin/androidx/compose/ui/text/NotImplemented.linuxx64Stubs.kt
A compose/ui/ui-text/src/linuxx64StubsMain/kotlin/androidx/compose/ui/text/Paragraph.linuxx64Stubs.kt
A compose/ui/ui-text/src/linuxx64StubsMain/kotlin/androidx/compose/ui/text/Savers.linuxx64Stubs.kt
A compose/ui/ui-text/src/linuxx64StubsMain/kotlin/androidx/compose/ui/text/TextStyle.linuxx64Stubs.kt
A compose/ui/ui-text/src/linuxx64StubsMain/kotlin/androidx/compose/ui/text/font/DelegatingFontLoaderForDeprecatedUsage.linuxx64Stubs.kt
A compose/ui/ui-text/src/linuxx64StubsMain/kotlin/androidx/compose/ui/text/font/FontSynthesis.linuxx64Stubs.kt
A compose/ui/ui-text/src/linuxx64StubsMain/kotlin/androidx/compose/ui/text/font/PlatformFontFamilyTypefaceAdapter.linuxx64Stubs.kt
A compose/ui/ui-text/src/linuxx64StubsMain/kotlin/androidx/compose/ui/text/input/GapBuffer.linuxx64Stubs.kt
A compose/ui/ui-text/src/linuxx64StubsMain/kotlin/androidx/compose/ui/text/input/PlatformImeOptions.linuxx64Stubs.kt
A compose/ui/ui-text/src/linuxx64StubsMain/kotlin/androidx/compose/ui/text/internal/JvmDefaultWithCompatibility.linuxx64Stubs.kt
A compose/ui/ui-text/src/linuxx64StubsMain/kotlin/androidx/compose/ui/text/intl/DesktopPlatformLocale.linuxx64Stubs.kt
A compose/ui/ui-text/src/linuxx64StubsMain/kotlin/androidx/compose/ui/text/intl/PlatformLocale.linuxx64Stubs.kt
A compose/ui/ui-text/src/linuxx64StubsMain/kotlin/androidx/compose/ui/text/platform/DesktopStringDelegate.linuxx64Stubs.kt
A compose/ui/ui-text/src/linuxx64StubsMain/kotlin/androidx/compose/ui/text/platform/SkiaMultiParagraphDraw.linuxx64Stubs.kt
A compose/ui/ui-text/src/linuxx64StubsMain/kotlin/androidx/compose/ui/text/platform/SkiaParagraph.linuxx64Stubs.kt
A compose/ui/ui-text/src/linuxx64StubsMain/kotlin/androidx/compose/ui/text/platform/SkiaParagraphIntrinsics.linuxx64Stubs.kt
A compose/ui/ui-text/src/linuxx64StubsMain/kotlin/androidx/compose/ui/text/platform/Synchronization.linuxx64Stubs.kt
A compose/ui/ui-text/src/linuxx64StubsMain/kotlin/androidx/compose/ui/text/style/LineBreak.linuxx64Stubs.kt
A compose/ui/ui-text/src/linuxx64StubsMain/kotlin/androidx/compose/ui/text/style/TextMotion.linuxx64Stubs.kt
al...@gmail.com <al...@gmail.com> #8
Branch: androidx-main
commit 2aaa6124959e14e6982a5d6c88308bdb34b2c186
Author: Aurimas Liutikas <aurimas@google.com>
Date: Mon Jul 08 17:06:43 2024
Convert compose ui-test project to add linuxX64Stubs target
- Add all needed stub actuals
Bug: 349894318
Test: ./gradlew -p compose/ui build
Change-Id: I65c0edbda876c7b9965a9144eae58f521c45967f
M compose/ui/ui-test/build.gradle
M compose/ui/ui-test/src/commonMain/kotlin/androidx/compose/ui/test/Actions.kt
M compose/ui/ui-test/src/commonMain/kotlin/androidx/compose/ui/test/GlobalAssertions.kt
M compose/ui/ui-test/src/commonMain/kotlin/androidx/compose/ui/test/TextActions.kt
M compose/ui/ui-test/src/commonStubsMain/kotlin/androidx/compose/ui/test/Actions.commonStubs.kt
M compose/ui/ui-test/src/commonStubsMain/kotlin/androidx/compose/ui/test/Assertions.commonStubs.kt
M compose/ui/ui-test/src/commonStubsMain/kotlin/androidx/compose/ui/test/ComposeUiTest.commonStubs.kt
M compose/ui/ui-test/src/commonStubsMain/kotlin/androidx/compose/ui/test/DensityForcedSize.commonStubs.kt
M compose/ui/ui-test/src/commonStubsMain/kotlin/androidx/compose/ui/test/DeviceConfigurationOverride.commonStubs.kt
M compose/ui/ui-test/src/commonStubsMain/kotlin/androidx/compose/ui/test/Expect.commonStubs.kt
M compose/ui/ui-test/src/commonStubsMain/kotlin/androidx/compose/ui/test/InputDispatcher.commonStubs.kt
M compose/ui/ui-test/src/commonStubsMain/kotlin/androidx/compose/ui/test/Mouse.commonStubs.kt
M compose/ui/ui-test/src/commonStubsMain/kotlin/androidx/compose/ui/test/NotImplemented.commonStubs.kt
M compose/ui/ui-test/src/commonStubsMain/kotlin/androidx/compose/ui/test/Output.commonStubs.kt
A compose/ui/ui-test/src/commonStubsMain/kotlin/androidx/compose/ui/test/TextActions.commonStubs.kt
M compose/ui/ui-test/src/commonStubsMain/kotlin/androidx/compose/ui/test/internal/JvmDefaultWithCompatibility.commonStubs.kt
A compose/ui/ui-test/src/jvmMain/kotlin/androidx/compose/ui/test/TextActions.jvm.kt
ma...@gmail.com <ma...@gmail.com> #9
Branch: androidx-main
commit 9ec4bcf90fa4f214ba0bc52cbb494896da661cfa
Author: Aurimas Liutikas <aurimas@google.com>
Date: Mon Jul 08 14:48:37 2024
Convert compose ui project to add linuxX64Stubs target
- Add all needed stub actuals
Bug: 349894318
Test: ./gradlew -p compose/ui build
Change-Id: I778f6f9ea095bf06656bd70cc49bf6fdfd0d7b2c
M compose/ui/ui/build.gradle
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/ComposedModifier.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/Modifier.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/SessionMutex.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/focus/FocusDirection.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/focus/FocusEventModifier.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/focus/FocusRequesterModifier.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/focus/Focusability.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/focus/OneDimensionalFocusSearch.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/graphics/vector/ImageVector.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/input/pointer/SuspendingPointerInputFilter.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/layout/Layout.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/layout/LayoutCoordinates.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/DelegatingNode.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/DepthSortedSet.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/MyersDiff.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/NodeKind.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/semantics/SemanticsModifier.kt
A compose/ui/ui/src/jvmMain/kotlin/androidx/compose/ui/Modifier.jvm.kt
A compose/ui/ui/src/jvmMain/kotlin/androidx/compose/ui/input/pointer/SuspendingPointerInputFilter.jvm.kt
A compose/ui/ui/src/jvmMain/kotlin/androidx/compose/ui/semantics/SemanticsModifier.jvm.kt
M compose/ui/ui/src/jvmStubsMain/kotlin/androidx/compose/ui/platform/PlatformClipboardManager.jvmStubs.kt
A compose/ui/ui/src/linuxx64StubsMain/kotlin/androidx/compose/ui/Actual.linuxx64Stubs.kt
A compose/ui/ui/src/linuxx64StubsMain/kotlin/androidx/compose/ui/AtomicReference.linuxx64Stubs.kt
A compose/ui/ui/src/linuxx64StubsMain/kotlin/androidx/compose/ui/Modifier.linuxx64Stubs.kt
A compose/ui/ui/src/linuxx64StubsMain/kotlin/androidx/compose/ui/NotImplemented.linuxx64Stubs.kt
A compose/ui/ui/src/linuxx64StubsMain/kotlin/androidx/compose/ui/autofill/ContentDataType.linuxx64Stubs.kt
A compose/ui/ui/src/linuxx64StubsMain/kotlin/androidx/compose/ui/autofill/ContentType.linuxx64Stubs.kt
A compose/ui/ui/src/linuxx64StubsMain/kotlin/androidx/compose/ui/draganddrop/DragAndDrop.linuxx64Stubs.kt
A compose/ui/ui/src/linuxx64StubsMain/kotlin/androidx/compose/ui/hapticfeedback/PlatformHapticFeedbackType.linuxx64Stubs.kt
A compose/ui/ui/src/linuxx64StubsMain/kotlin/androidx/compose/ui/input/key/Key.linuxx64Stubs.kt
A compose/ui/ui/src/linuxx64StubsMain/kotlin/androidx/compose/ui/input/key/KeyEvent.linuxx64Stubs.kt
A compose/ui/ui/src/linuxx64StubsMain/kotlin/androidx/compose/ui/input/pointer/InternalPointerEvent.linuxx64Stubs.kt
A compose/ui/ui/src/linuxx64StubsMain/kotlin/androidx/compose/ui/input/pointer/PointerEvent.linuxx64Stubs.kt
A compose/ui/ui/src/linuxx64StubsMain/kotlin/androidx/compose/ui/input/pointer/PointerIcon.linuxx64Stubs.kt
A compose/ui/ui/src/linuxx64StubsMain/kotlin/androidx/compose/ui/input/pointer/PointerInputEvent.linuxx64Stubs.kt
A compose/ui/ui/src/linuxx64StubsMain/kotlin/androidx/compose/ui/input/pointer/SuspendingPointerInputFilter.linuxx64Stubs.kt
A compose/ui/ui/src/linuxx64StubsMain/kotlin/androidx/compose/ui/input/rotary/RotaryScrollEvent.linuxx64Stubs.kt
A compose/ui/ui/src/linuxx64StubsMain/kotlin/androidx/compose/ui/internal/JvmDefaultWithCompatibility.linuxx64Stubs.kt
A compose/ui/ui/src/linuxx64StubsMain/kotlin/androidx/compose/ui/node/JvmTreeSet.linuxx64Stubs.kt
A compose/ui/ui/src/linuxx64StubsMain/kotlin/androidx/compose/ui/node/WeakReference.linuxx64Stubs.kt
A compose/ui/ui/src/linuxx64StubsMain/kotlin/androidx/compose/ui/platform/AtomicInt.linuxx64Stubs.kt
A compose/ui/ui/src/linuxx64StubsMain/kotlin/androidx/compose/ui/platform/ClassHelpers.linuxx64Stubs.kt
A compose/ui/ui/src/linuxx64StubsMain/kotlin/androidx/compose/ui/platform/DebugUtils.linuxx64Stubs.kt
A compose/ui/ui/src/linuxx64StubsMain/kotlin/androidx/compose/ui/platform/PlatformClipboardManager.linuxx64Stubs.kt
A compose/ui/ui/src/linuxx64StubsMain/kotlin/androidx/compose/ui/platform/PlatformTextInputMethodRequest.linuxx64Stubs.kt
A compose/ui/ui/src/linuxx64StubsMain/kotlin/androidx/compose/ui/platform/PlatformTextInputSession.linuxx64Stubs.kt
A compose/ui/ui/src/linuxx64StubsMain/kotlin/androidx/compose/ui/platform/Synchronization.linuxx64Stubs.kt
A compose/ui/ui/src/linuxx64StubsMain/kotlin/androidx/compose/ui/platform/Wrapper.linuxx64Stubs.kt
A compose/ui/ui/src/linuxx64StubsMain/kotlin/androidx/compose/ui/viewinterop/InteropView.linuxx64Stubs.kt
A compose/ui/ui/src/linuxx64StubsMain/kotlin/androidx/compose/ui/viewinterop/InteropViewFactoryHolder.linuxx64Stubs.kt
A compose/ui/ui/src/linuxx64StubsMain/kotlin/androidx/compose/ui/window/Dialog.linuxx64Stubs.kt
A compose/ui/ui/src/linuxx64StubsMain/kotlin/androidx/compose/ui/window/Popup.linuxx64Stubs.kt
ka...@gmail.com <ka...@gmail.com> #10
Branch: androidx-main
commit 25969d8585b6735cf7b56bf4dc118c68d3a1704f
Author: Aurimas Liutikas <aurimas@google.com>
Date: Tue Jul 09 14:51:32 2024
Convert compose foundation-layout project to add linuxX64Stubs target
- Add all needed stub actuals
Bug: 349894318
Test: ./gradlew -p compose/foundation build
Change-Id: I69eb81436264648db175a6d865ca7bc29e2851d5
M compose/foundation/foundation-layout/build.gradle
M compose/foundation/foundation-layout/src/commonMain/kotlin/androidx/compose/foundation/layout/Column.kt
M compose/foundation/foundation-layout/src/commonMain/kotlin/androidx/compose/foundation/layout/ContextualFlowLayout.kt
M compose/foundation/foundation-layout/src/commonMain/kotlin/androidx/compose/foundation/layout/FlowLayout.kt
M compose/foundation/foundation-layout/src/commonMain/kotlin/androidx/compose/foundation/layout/Row.kt
M compose/foundation/foundation-layout/src/commonMain/kotlin/androidx/compose/foundation/layout/RowColumnImpl.kt
M compose/foundation/foundation-layout/src/commonMain/kotlin/androidx/compose/foundation/layout/RowColumnMeasurePolicy.kt
M compose/foundation/foundation-layout/src/commonStubsMain/kotlin/androidx/compose/foundation/layout/NotImplemented.commonStubs.kt
A compose/foundation/foundation-layout/src/commonStubsMain/kotlin/androidx/compose/foundation/layout/RowColumnMeasurePolicy.commonStubs.kt
M compose/foundation/foundation-layout/src/commonStubsMain/kotlin/androidx/compose/foundation/layout/WindowInsets.commonStubs.kt
M compose/foundation/foundation-layout/src/commonStubsMain/kotlin/androidx/compose/foundation/layout/WindowInsetsPadding.commonStubs.kt
A compose/foundation/foundation-layout/src/commonStubsMain/kotlin/androidx/compose/foundation/layout/internal/JvmDefaultWithCompatibility.commonStubs.kt
A compose/foundation/foundation-layout/src/jvmMain/kotlin/androidx/compose/foundation/layout/RowColumnMeasurePolicy.jvm.kt
to...@gmail.com <to...@gmail.com> #11
Branch: androidx-main
commit cae205daf0f36453c2334fe5ab6a158477503420
Author: Aurimas Liutikas <aurimas@google.com>
Date: Tue Jul 09 13:09:41 2024
Convert compose animation-core project to add linuxX64Stubs target
- Add all needed stub actuals
Bug: 349894318
Test: ./gradlew -p compose/animation build
Change-Id: I872bcb0e1d1b5b9be13f35a7645a9704a2411e14
M compose/animation/animation-core/build.gradle
M compose/animation/animation-core/src/commonMain/kotlin/androidx/compose/animation/core/Animation.kt
M compose/animation/animation-core/src/commonMain/kotlin/androidx/compose/animation/core/ArcSpline.kt
M compose/animation/animation-core/src/commonMain/kotlin/androidx/compose/animation/core/IntListExtension.kt
M compose/animation/animation-core/src/commonMain/kotlin/androidx/compose/animation/core/InternalMutatorMutex.kt
M compose/animation/animation-core/src/commonMain/kotlin/androidx/compose/animation/core/Transition.kt
M compose/animation/animation-core/src/commonMain/kotlin/androidx/compose/animation/core/VectorizedAnimationSpec.kt
A compose/animation/animation-core/src/commonMain/kotlin/androidx/compose/animation/core/internal/JvmDefaultWithCompatibility.kt
A compose/animation/animation-core/src/commonStubsMain/kotlin/androidx/compose/animation/core/ArcSpline.commonStubs.kt
A compose/animation/animation-core/src/commonStubsMain/kotlin/androidx/compose/animation/core/Expect.commonStubs.kt
A compose/animation/animation-core/src/commonStubsMain/kotlin/androidx/compose/animation/core/InternalMutatorMutex.commonStubs.kt
A compose/animation/animation-core/src/commonStubsMain/kotlin/androidx/compose/animation/core/NotImplemented.commonStubs.kt
A compose/animation/animation-core/src/commonStubsMain/kotlin/androidx/compose/animation/core/internal/JvmDefaultWithCompatibility.commonStubs.kt
A compose/animation/animation-core/src/jvmMain/kotlin/androidx/compose/animation/core/ArcSpline.jvm.kt
A compose/animation/animation-core/src/jvmMain/kotlin/androidx/compose/animation/core/InternalMotatorMutex.jvm.kt
ci...@gmail.com <ci...@gmail.com> #12
Branch: androidx-main
commit dd908bb91d5d71617c2e5b20402ff801c16de0bb
Author: Aurimas Liutikas <aurimas@google.com>
Date: Tue Jul 09 15:13:15 2024
Convert compose animation projects to add linuxX64Stubs target
- Add all needed stub actuals
Bug: 349894318
Test: ./gradlew -p compose/animation build
Change-Id: I5af188f28e9ab251623adfcf6916fc50d959f75a
M compose/animation/animation-graphics/build.gradle
M compose/animation/animation/build.gradle
M compose/animation/animation/src/commonStubsMain/kotlin/androidx/compose/animation/DefaultDecayAnimationSpec.commonStubs.kt
M compose/animation/animation/src/commonStubsMain/kotlin/androidx/compose/animation/NotImplemented.commonStubs.kt
M compose/animation/animation/src/commonStubsMain/kotlin/androidx/compose/animation/SplineBasedDecayAnimationSpec.commonStubs.kt
A compose/animation/animation/src/commonStubsMain/kotlin/androidx/compose/animation/internal/JvmDefaultWithCompatibility.commonStubs.kt
[Deleted User] <[Deleted User]> #13
Branch: androidx-main
commit 64c19e2612ecaca5c53a3f7b96d7b4fec2991709
Author: Aurimas Liutikas <aurimas@google.com>
Date: Tue Jul 09 20:32:43 2024
Convert compose foundation project to add linuxX64Stubs target
- Add all needed stub actuals
Bug: 349894318
Test: ./gradlew -p compose/foundation build
Change-Id: I102625214a9299e77d32cf1e627d3d2f159f4541
M compose/foundation/foundation/build.gradle
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/BasicMarquee.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/MutatorMutex.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/content/TransferableContent.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/gestures/AnchoredDraggable.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/internal/JvmSynchronized.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/lazy/layout/LazyLayoutItemContentFactory.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/lazy/layout/LazyLayoutPrefetchState.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/lazy/layout/ObservableScopeInvalidator.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/lazy/staggeredgrid/LazyStaggeredGridMeasure.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/pager/Pager.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/relocation/BringIntoView.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/relocation/BringIntoViewRequester.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/relocation/BringIntoViewResponder.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/relocation/ScrollIntoViewRequester.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/ValidatingOffsetMapping.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/input/TextFieldBuffer.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/input/TextFieldCharSequence.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/input/TextObfuscationMode.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/input/internal/GapBuffer.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/input/internal/TextFieldDragAndDropNode.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/modifiers/InlineDensity.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/selection/MultiWidgetSelectionDelegate.kt
M compose/foundation/foundation/src/commonStubsMain/kotlin/androidx/compose/foundation/BasicTooltip.commonStubs.kt
M compose/foundation/foundation/src/commonStubsMain/kotlin/androidx/compose/foundation/Clickable.commonStubs.kt
M compose/foundation/foundation/src/commonStubsMain/kotlin/androidx/compose/foundation/DarkTheme.commonStubs.kt
M compose/foundation/foundation/src/commonStubsMain/kotlin/androidx/compose/foundation/DesktopOverscroll.commonStubs.kt
A compose/foundation/foundation/src/commonStubsMain/kotlin/androidx/compose/foundation/Expect.commonStubs.kt
M compose/foundation/foundation/src/commonStubsMain/kotlin/androidx/compose/foundation/MutatorMutex.commonStubs.kt
M compose/foundation/foundation/src/commonStubsMain/kotlin/androidx/compose/foundation/NotImplemented.commonStubs.kt
A compose/foundation/foundation/src/commonStubsMain/kotlin/androidx/compose/foundation/content/MediaType.commonStubs.kt
M compose/foundation/foundation/src/commonStubsMain/kotlin/androidx/compose/foundation/content/TransferableContent.commonStubs.kt
M compose/foundation/foundation/src/commonStubsMain/kotlin/androidx/compose/foundation/content/internal/DragAndDropRequestPermission.commonStubs.kt
M compose/foundation/foundation/src/commonStubsMain/kotlin/androidx/compose/foundation/content/internal/ReceiveContentDragAndDropNode.commonStubs.kt
A compose/foundation/foundation/src/commonStubsMain/kotlin/androidx/compose/foundation/gestures/AnchoredDraggable.commonStubs.kt
M compose/foundation/foundation/src/commonStubsMain/kotlin/androidx/compose/foundation/gestures/BringIntoViewSpec.commonStubs.kt
M compose/foundation/foundation/src/commonStubsMain/kotlin/androidx/compose/foundation/gestures/DesktopScrollable.commonStubs.kt
M compose/foundation/foundation/src/commonStubsMain/kotlin/androidx/compose/foundation/internal/JvmDefaultWithCompatibility.commonStubs.kt
M compose/foundation/foundation/src/commonStubsMain/kotlin/androidx/compose/foundation/internal/JvmSynchronized.commonStubs.kt
M compose/foundation/foundation/src/commonStubsMain/kotlin/androidx/compose/foundation/lazy/layout/Lazy.commonStubs.kt
M compose/foundation/foundation/src/commonStubsMain/kotlin/androidx/compose/foundation/lazy/layout/LazyLayoutPrefetchState.commonStubs.kt
M compose/foundation/foundation/src/commonStubsMain/kotlin/androidx/compose/foundation/lazy/layout/PrefetchScheduler.commonStubs.kt
M compose/foundation/foundation/src/commonStubsMain/kotlin/androidx/compose/foundation/relocation/BringIntoViewResponder.commonStubs.kt
M compose/foundation/foundation/src/commonStubsMain/kotlin/androidx/compose/foundation/text/ContextMenu.commonStubs.kt
M compose/foundation/foundation/src/commonStubsMain/kotlin/androidx/compose/foundation/text/CursorHandle.commonStubs.kt
M compose/foundation/foundation/src/commonStubsMain/kotlin/androidx/compose/foundation/text/DeadKeyCombiner.commonStubs.kt
M compose/foundation/foundation/src/commonStubsMain/kotlin/androidx/compose/foundation/text/KeyEventHelpers.commonStubs.kt
M compose/foundation/foundation/src/commonStubsMain/kotlin/androidx/compose/foundation/text/KeyMapping.commonStubs.kt
M compose/foundation/foundation/src/commonStubsMain/kotlin/androidx/compose/foundation/text/StringHelpers.commonStubs.kt
M compose/foundation/foundation/src/commonStubsMain/kotlin/androidx/compose/foundation/text/TextFieldFocusModifier.commonStubs.kt
M compose/foundation/foundation/src/commonStubsMain/kotlin/androidx/compose/foundation/text/TextFieldKeyInput.commonStubs.kt
M compose/foundation/foundation/src/commonStubsMain/kotlin/androidx/compose/foundation/text/TextPointerIcon.commonStubs.kt
M compose/foundation/foundation/src/commonStubsMain/kotlin/androidx/compose/foundation/text/TouchMode.commonStubs.kt
M compose/foundation/foundation/src/commonStubsMain/kotlin/androidx/compose/foundation/text/UndoManager.commonStubs.kt
M compose/foundation/foundation/src/commonStubsMain/kotlin/androidx/compose/foundation/text/handwriting/StylusHandwriting.commonStubs.kt
M compose/foundation/foundation/src/commonStubsMain/kotlin/androidx/compose/foundation/text/input/internal/CodepointHelpers.commonStubs.kt
M compose/foundation/foundation/src/commonStubsMain/kotlin/androidx/compose/foundation/text/input/internal/LegacyPlatformTextInputServiceAdapter.commonStubs.kt
M compose/foundation/foundation/src/commonStubsMain/kotlin/androidx/compose/foundation/text/input/internal/TextFieldDragAndDropNode.commonStubs.kt
M compose/foundation/foundation/src/commonStubsMain/kotlin/androidx/compose/foundation/text/input/internal/TextFieldKeyEventHandler.commonStubs.kt
M compose/foundation/foundation/src/commonStubsMain/kotlin/androidx/compose/foundation/text/input/internal/TextFieldLayoutStateCache.commonStubs.kt
M compose/foundation/foundation/src/commonStubsMain/kotlin/androidx/compose/foundation/text/input/internal/TextInputSession.commonStubs.kt
M compose/foundation/foundation/src/commonStubsMain/kotlin/androidx/compose/foundation/text/input/internal/ToCharArray.commonStubs.kt
M compose/foundation/foundation/src/commonStubsMain/kotlin/androidx/compose/foundation/text/input/internal/selection/TextFieldMagnifier.commonStubs.kt
M compose/foundation/foundation/src/commonStubsMain/kotlin/androidx/compose/foundation/text/selection/SelectionHandles.commonStubs.kt
M compose/foundation/foundation/src/commonStubsMain/kotlin/androidx/compose/foundation/text/selection/SelectionManager.commonStubs.kt
M compose/foundation/foundation/src/commonStubsMain/kotlin/androidx/compose/foundation/text/selection/TextFieldSelectionManager.commonStubs.kt
A compose/foundation/foundation/src/jvmMain/kotlin/androidx/compose/foundation/MutatorMutex.jvm.kt
A compose/foundation/foundation/src/jvmMain/kotlin/androidx/compose/foundation/gestures/AnchoredDraggable.jvm.kt
M compose/foundation/foundation/src/jvmMain/kotlin/androidx/compose/foundation/internal/JvmSynchronized.jvm.kt
M compose/foundation/foundation/src/jvmMain/kotlin/androidx/compose/foundation/lazy/layout/LazyLayoutPrefetchState.jvm.kt
D compose/foundation/foundation/src/jvmStubsMain/kotlin/androidx/compose/foundation/content/MediaType.jvmStubs.kt
dj...@gmail.com <dj...@gmail.com> #14
Branch: androidx-main
commit cec36ac792a749f139f04404d8ca327ec0711dc9
Author: Aurimas Liutikas <aurimas@google.com>
Date: Wed Jul 10 13:43:42 2024
Convert compose material projects to add linuxX64Stubs target
- Add all needed stub actuals
Bug: 349894318
Test: ./gradlew -p compose/material build
Change-Id: Id9f289348121c28e6e81875049143af92bde4bc1
M compose/material/material-ripple/build.gradle
M compose/material/material-ripple/src/commonStubsMain/kotlin/androidx/compose/material/ripple/NotImplemented.commonStubs.kt
M compose/material/material-ripple/src/commonStubsMain/kotlin/androidx/compose/material/ripple/Ripple.commonStubs.kt
M compose/material/material/build.gradle
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/AnchoredDraggable.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/BackdropScaffold.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/BottomSheetScaffold.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Chip.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Drawer.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/InteractiveComponentSize.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/ModalBottomSheet.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Scaffold.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/SwipeToDismiss.kt
M compose/material/material/src/commonStubsMain/kotlin/androidx/compose/material/AlertDialog.jvmStubs.kt
M compose/material/material/src/commonStubsMain/kotlin/androidx/compose/material/AnchoredDraggable.commonStubs.kt
M compose/material/material/src/commonStubsMain/kotlin/androidx/compose/material/DefaultPlatformTextStyle.jvmStubs.kt
M compose/material/material/src/commonStubsMain/kotlin/androidx/compose/material/InteractiveComponentSize.commonStubs.kt
A compose/material/material/src/commonStubsMain/kotlin/androidx/compose/material/InternalMutatorMutex.commonStubs.kt
M compose/material/material/src/commonStubsMain/kotlin/androidx/compose/material/MaterialTheme.jvmStubs.kt
M compose/material/material/src/commonStubsMain/kotlin/androidx/compose/material/Menu.commonStubs.kt
M compose/material/material/src/commonStubsMain/kotlin/androidx/compose/material/NotImplemented.jvmStubs.kt
M compose/material/material/src/commonStubsMain/kotlin/androidx/compose/material/Strings.jvmStubs.kt
M compose/material/material/src/commonStubsMain/kotlin/androidx/compose/material/SystemBarsDefaultInsets.jvmStubs.kt
M compose/material/material/src/jvmMain/kotlin/androidx/compose/material/AnchoredDraggable.jvm.kt
M compose/material/material/src/jvmMain/kotlin/androidx/compose/material/InteractiveComponentSize.jvm.kt
D compose/material/material/src/jvmStubsMain/kotlin/androidx/compose/material/DesktopMenu.jvmStubs.kt
[Deleted User] <[Deleted User]> #15
kr...@gmail.com <kr...@gmail.com> #16
Branch: androidx-main
commit 932720ab79c7fd016cff7adec4358606209662cc
Author: Aurimas Liutikas <aurimas@google.com>
Date: Wed Jul 10 16:54:13 2024
Add additional targets to graphics:graphics-shapes library
These targets are needed to add support for these targets to
compose.material3 library
Bug: 349894318
Test: ./gradlew graphics:graphics-shapes:build
Change-Id: I10d41346cd9555e5a76b267e8cb305e13487b208
M graphics/graphics-shapes/build.gradle
M graphics/graphics-shapes/src/commonMain/kotlin/androidx/graphics/shapes/CornerRounding.kt
M graphics/graphics-shapes/src/commonMain/kotlin/androidx/graphics/shapes/Cubic.kt
M graphics/graphics-shapes/src/commonMain/kotlin/androidx/graphics/shapes/FeatureMapping.kt
M graphics/graphics-shapes/src/commonMain/kotlin/androidx/graphics/shapes/FloatMapping.kt
A graphics/graphics-shapes/src/commonMain/kotlin/androidx/graphics/shapes/Format.kt
M graphics/graphics-shapes/src/commonMain/kotlin/androidx/graphics/shapes/Morph.kt
M graphics/graphics-shapes/src/commonMain/kotlin/androidx/graphics/shapes/RoundedPolygon.kt
M graphics/graphics-shapes/src/commonMain/kotlin/androidx/graphics/shapes/Shapes.kt
M graphics/graphics-shapes/src/commonMain/kotlin/androidx/graphics/shapes/Utils.kt
A graphics/graphics-shapes/src/jvmMain/kotlin/androidx/graphics/shapes/Format.jvm.kt
A graphics/graphics-shapes/src/nativeMain/kotlin/androidx/graphics/shapes/Format.native.kt
i....@getorca.app <i....@getorca.app> #17
Branch: androidx-main
commit 0c6639ccf4cc18be4c3a461125c52af8c483dc9d
Author: Aurimas Liutikas <aurimas@google.com>
Date: Thu Jul 18 13:35:49 2024
Add support for mingwX64 target in annotation:annotation
This will help in the effort to allow jetbrains' compose to stop forking
this library.
Bug: 349894318
Relnote: Adding support for mingwX64 platform
Test: ./gradlew annotation:annotation:publish
Change-Id: I461cad1935cd2c29aa7eb05f5e6971215292f11c
M annotation/annotation/bcv/native/current.txt
M annotation/annotation/build.gradle
M buildSrc-tests/src/test/java/androidx/build/KmpPlatformsTest.kt
M buildSrc/private/src/main/kotlin/androidx/build/AndroidXMultiplatformExtension.kt
M buildSrc/public/src/main/kotlin/androidx/build/KmpPlatforms.kt
ha...@google.com <ha...@google.com>
sm...@gmail.com <sm...@gmail.com> #18
Branch: androidx-main
commit c2551dbbb12c9d690b1e52c854ff72103aed4935
Author: Aurimas Liutikas <aurimas@google.com>
Date: Wed Jul 10 16:10:02 2024
Convert first batch of compose material3 projects to add linuxX64Stubs target
- Add all needed stub actuals
- Remove dependency on material-icons-core from material3 by copying
relevant icons over
Relnote: """material3 no longer adds a dependency to material-icons-core so if
your project relied on that, you will have to explicitly add that
dependency in your build.gradle[.kts] files."""
Bug: 349894318
Test: ./gradlew -p compose/material3 build
Change-Id: I735ffb809330e77356492b3f63ad4bd5081cdd8e
M compose/material3/adaptive/samples/build.gradle
M compose/material3/integration-tests/macrobenchmark-target/build.gradle
M compose/material3/material3-adaptive-navigation-suite/samples/build.gradle
M compose/material3/material3-common/build.gradle
M compose/material3/material3-common/src/commonMain/kotlin/androidx/compose/material3/common/InteractiveComponentSize.kt
A compose/material3/material3-common/src/commonStubsMain/kotlin/androidx/compose/material3/common/InteractiveComponentSize.commonStubs.kt
A compose/material3/material3-common/src/commonStubsMain/kotlin/androidx/compose/material3/common/NotImplemented.commonStubs.kt
A compose/material3/material3-common/src/jvmMain/kotlin/androidx/compose/material3/common/InteractiveComponentSize.jvm.kt
M compose/material3/material3-window-size-class/build.gradle
A compose/material3/material3-window-size-class/src/commonStubsMain/kotlin/androidx/compose/material3/windowsizeclass/TestOnly.stubsCommon.kt
M compose/material3/material3/build.gradle
A compose/material3/material3/src/androidMain/kotlin/androidx/compose/material3/DateInput.android.kt
A compose/material3/material3/src/androidMain/kotlin/androidx/compose/material3/DatePicker.android.kt
M compose/material3/material3/src/androidMain/kotlin/androidx/compose/material3/ExposedDropdownMenu.android.kt
M compose/material3/material3/src/androidMain/kotlin/androidx/compose/material3/InteractiveComponentSize.android.kt
A compose/material3/material3/src/androidMain/kotlin/androidx/compose/material3/internal/AnchoredDraggable.android.kt
M compose/material3/material3/src/androidMain/kotlin/androidx/compose/material3/internal/CalendarModel.android.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/AppBar.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/BottomSheetScaffold.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/DateInput.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/DatePicker.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/InteractiveComponentSize.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/ListItem.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/NavigationItem.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/ProgressIndicator.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/SegmentedButton.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/SheetDefaults.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/ShortNavigationBar.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/Slider.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/Snackbar.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/TimePicker.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/WideNavigationRail.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/carousel/Carousel.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/internal/AnchoredDraggable.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/internal/CalendarModel.kt
A compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/internal/Icons.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/internal/Strings.kt
M compose/material3/material3/src/commonStubsMain/kotlin/androidx/compose/material3/AlertDialog.commonStubs.kt
M compose/material3/material3/src/commonStubsMain/kotlin/androidx/compose/material3/CalendarLocale.commonStubs.kt
A compose/material3/material3/src/commonStubsMain/kotlin/androidx/compose/material3/DateInput.commonStubs.kt
A compose/material3/material3/src/commonStubsMain/kotlin/androidx/compose/material3/DatePicker.commonStubs.kt
M compose/material3/material3/src/commonStubsMain/kotlin/androidx/compose/material3/InteractiveComponentSize.commonStubs.kt
M compose/material3/material3/src/commonStubsMain/kotlin/androidx/compose/material3/ModalBottomSheet.commonStubs.kt
M compose/material3/material3/src/commonStubsMain/kotlin/androidx/compose/material3/NavigationDrawer.commonStubs.kt
M compose/material3/material3/src/commonStubsMain/kotlin/androidx/compose/material3/NotImplemented.commonStubs.kt
M compose/material3/material3/src/commonStubsMain/kotlin/androidx/compose/material3/SkikoMenu.commonStubs.kt
M compose/material3/material3/src/commonStubsMain/kotlin/androidx/compose/material3/TimeFormat.commonStubs.kt
M compose/material3/material3/src/commonStubsMain/kotlin/androidx/compose/material3/TimePicker.commonStubs.kt
M compose/material3/material3/src/commonStubsMain/kotlin/androidx/compose/material3/Tooltip.commonStubs.kt
M compose/material3/material3/src/commonStubsMain/kotlin/androidx/compose/material3/internal/AccessibilityServiceStateProvider.commonStubs.kt
M compose/material3/material3/src/commonStubsMain/kotlin/androidx/compose/material3/internal/AnchoredDraggable.commonStubs.kt
M compose/material3/material3/src/commonStubsMain/kotlin/androidx/compose/material3/internal/BasicTooltip.commonStubs.kt
M compose/material3/material3/src/commonStubsMain/kotlin/androidx/compose/material3/internal/CalendarModel.commonStubs.kt
M compose/material3/material3/src/commonStubsMain/kotlin/androidx/compose/material3/internal/DefaultPlatformTextStyle.commonStubs.kt
M compose/material3/material3/src/commonStubsMain/kotlin/androidx/compose/material3/internal/InternalMutatorMutex.commonStubs.kt
M compose/material3/material3/src/commonStubsMain/kotlin/androidx/compose/material3/internal/Strings.commonStubs.kt
M compose/material3/material3/src/commonStubsMain/kotlin/androidx/compose/material3/internal/SystemBarsDefaultInsets.commonStubs.kt
zh...@gmail.com <zh...@gmail.com> #19
Branch: androidx-main
commit 1d1abef790da93325a83fe19b50ccdec06be6956
Author: Aurimas Liutikas <aurimas@google.com>
Date: Tue Jul 23 12:56:48 2024
Remove material-icons-core dependency from the material library
Copies the single icon used in ExposedDropdownMenu into the library.
This helps make sure that Jetbrains copy of compose does not need this
library.
Relnote: """material no longer adds a dependency to material-icons-core so if
your project relied on that, you will have to explicitly add that
dependency in your build.gradle[.kts] files."""
Bug: 349894318
Test: ./gradlew -p compose:material build assembleAndroidTest
Change-Id: Ie8fb35d07ce22063d5daf175927dd5a094016cae
M camera/integration-tests/avsynctestapp/build.gradle
M compose/animation/animation-core/samples/build.gradle
M compose/animation/animation/integration-tests/animation-demos/build.gradle
M compose/animation/animation/samples/build.gradle
M compose/foundation/foundation-layout/benchmark/build.gradle
M compose/foundation/foundation-layout/integration-tests/layout-demos/build.gradle
M compose/foundation/foundation/integration-tests/foundation-demos/build.gradle
M compose/foundation/foundation/samples/build.gradle
M compose/integration-tests/macrobenchmark-target/build.gradle
M compose/integration-tests/material-catalog/build.gradle
M compose/material/material/build.gradle
M compose/material/material/samples/build.gradle
M compose/material/material/src/androidMain/kotlin/androidx/compose/material/ExposedDropdownMenu.android.kt
A compose/material/material/src/commonMain/kotlin/androidx/compose/material/internal/Icons.kt
M compose/ui/ui-inspection/build.gradle
M compose/ui/ui-tooling/build.gradle
M compose/ui/ui/build.gradle
M compose/ui/ui/integration-tests/ui-demos/build.gradle
M constraintlayout/constraintlayout-compose/build.gradle
M constraintlayout/constraintlayout-compose/integration-tests/demos/build.gradle
M constraintlayout/constraintlayout-compose/integration-tests/macrobenchmark-target/build.gradle
M navigation/navigation-compose/integration-tests/navigation-demos/build.gradle
ti...@soufan.com.br <ti...@soufan.com.br> #20
Branch: androidx-main
commit 41f67627c98f52328685113382cc67d0676d40af
Author: Aurimas Liutikas <aurimas@google.com>
Date: Thu Jul 25 14:10:45 2024
Add additional native platforms to window-core library
Test: ./gradlew window:window-core:build
Bug: 349894318
Change-Id: I488534b84bb0b646c422bb28349ed391290d3c1d
M window/window-core/build.gradle
M window/window-core/src/commonMain/kotlin/androidx/window/core/layout/WindowSizeClass.kt
jr...@gmail.com <jr...@gmail.com> #21
r.android.com/3205674 will be the last change adding linux stubs to androidx.compose.material3.adaptive
su...@gmail.com <su...@gmail.com> #22
For adaptive, follow along on
iv...@gmail.com <iv...@gmail.com> #23
ha...@google.com <ha...@google.com> #24
Updates: Currently we are studying the use cases for includeFontPadding == false. And it would be super helpful if you can share a little bit more about why you want to turned off includeFontPadding.
Here are some cases we are considering:
- Vertically align Text with another composable/widget
- Making 2 Text composable exactly the same as 2 lines of text.
- Vertically centering the text within another composable/widget.
Your suggestions are welcomed. Thanks a lot!
iv...@gmail.com <iv...@gmail.com> #25
ta...@gmail.com <ta...@gmail.com> #26
Originally, there was a problem with Android's handling of Noto Sans CJK Font, and I worked around it by setting "includeFontPaddings = false".
For related discussions, the following may be helpful.
iv...@gmail.com <iv...@gmail.com> #27
CustomFontWithBottomPadding.png - applying custom font adds a lot of bottom padding.
I don't need it, because distance from bottom of the Text to other elements are broken by this
[Deleted User] <[Deleted User]> #28
any workable workarounds for now?
jo...@pucp.pe <jo...@pucp.pe> #29
se...@gmail.com <se...@gmail.com> #30
Any update on this? This is really a dealbreaker for me. I could make a wrapper with TextView, but that really defeats the purpose of using the Jetpack Compose :(
fo...@gmail.com <fo...@gmail.com> #31
mx...@gmail.com <mx...@gmail.com> #32
A side note unrelated to the issue itself.
If you are using custom fonts and see too much padding due to Android's
- Install
. You can usefonttools pip3 install fonttools
. - Run
ttx -t head font.ttf
. - Open
font.ttx
with a text editor and modifyyMin
andyMax
values. It should be generally safe to change them to be the same as Roboto's values, which are-555
and2163
respectively. - Run
ttx -m font.ttf -b font.ttx
and you'll getfont#1.ttf
.
im...@gmail.com <im...@gmail.com> #33
[Deleted User] <[Deleted User]> #34
lc...@gmail.com <lc...@gmail.com> #35
Please just star the issue, adding a comment with +1 is just going to spam emails to everyone subscribed to this issue. Thank you for understanding.
f....@gmail.com <f....@gmail.com> #36
+1
bo...@gmail.com <bo...@gmail.com> #37
si...@google.com <si...@google.com>
jp...@spoton.com <jp...@spoton.com> #38
Workaround that works for my font, it cut's down bottom padding by looking at lines multiplied by lineHeight:
fun Modifier.removeFontPadding(
textStyle: TextStyle
) = layout { measurable, constraints ->
val placeable = measurable.measure(constraints)
val heightWithoutPadding = placeable.height - placeable.height.mod(textStyle.lineHeight.roundToPx())
layout(placeable.width, heightWithoutPadding) {
placeable.placeRelative(0, 0)
}
}
usage:
Text(
modifier = Modifier.removeFontPadding(typography.h5),
text = title,
style = typography.h5,
)
[Deleted User] <[Deleted User]> #39
mi...@gmail.com <mi...@gmail.com> #40
ch...@googlemail.com <ch...@googlemail.com> #41
[Deleted User] <[Deleted User]> #42
ji...@hotstar.com <ji...@hotstar.com> #43
si...@gmail.com <si...@gmail.com> #44
I built a component with annotatedStrings and 2 different styles + different sizes + different baselines. Basically, I needed a Superscript text (but aligned with the top and not above the second text, and different 60% of the font size) the second text (Baseline.None). I had some size variations for this component, and for each variation, I had to implement a different Baseline multiplier because it just wasn't aligning properly at the top (because of the font padding).
ag...@gmail.com <ag...@gmail.com> #45
fun Modifier.baselinePadding(
firstBaselineToTop: Dp,
lastBaselineToBottom: Dp
) = layout { measurable, constraints ->
val placeable = measurable.measure(constraints)
check(placeable[FirstBaseline] != AlignmentLine.Unspecified)
val firstBaseline = placeable[FirstBaseline]
check(placeable[LastBaseline] != AlignmentLine.Unspecified)
val lastBaseline = placeable[LastBaseline]
val lastBaselineToBottomHeight = placeable.height - lastBaseline
val lastBaselineToBottomDelta = lastBaselineToBottom.roundToPx() - lastBaselineToBottomHeight
val totalHeight = placeable.height +
(firstBaselineToTop.roundToPx() - firstBaseline)
val placeableY = totalHeight - placeable.height
layout(placeable.width, totalHeight + lastBaselineToBottomDelta) {
placeable.placeRelative(0, placeableY)
}
}
me...@gmail.com <me...@gmail.com> #46
si...@google.com <si...@google.com>
so...@google.com <so...@google.com>
[Deleted User] <[Deleted User]> #47
vi...@gmail.com <vi...@gmail.com> #48
gu...@gmail.com <gu...@gmail.com> #49
android:includeFontPadding
it seems to be pushed up or down depending on the excess padding on the top or bottom.
<hhea>
tag, ascent
for yMax
and descent
for yMin
si...@google.com <si...@google.com> #50
Anastasia, I have an idea and picked up the ticket. Will start discussion soon.
si...@google.com <si...@google.com> #51
Notes: go/compose-include-font-padding-2
ap...@google.com <ap...@google.com> #52
Branch: androidx-main
commit 6b3a3705892a51e67c63b446ea69a5cf249effd2
Author: Siyamed Sinir <siyamed@google.com>
Date: Sun Feb 27 00:13:24 2022
Update screenshot tests for includeFontPadding
aosp/1992050
Bug: 171394808
Change-Id: Ia680e6bbbee0e2da192465eef234fb763793a8d7
M wear/compose/material/button_disabled_cuttlefish.png
M compose/material/material/actionChip_disabled_cuttlefish.png
M wear/compose/material/compactbutton_ltr_cuttlefish.png
M wear/compose/material/swiped_to_right_50_percent_ltr_cuttlefish.png
M compose/material/material/tabs_lightTheme_defaultColors_cuttlefish.png
M compose/material/material/outlinedTextField_disabled_cuttlefish.png
M compose/material/material/scaffold_bottomAppBar_centerFab_docked_cuttlefish.png
M compose/material3/material3/drawerItem_lightTheme_defaultColors_pressed_cuttlefish.png
M compose/material/material/fab_text_cuttlefish.png
M compose/material/material/filled_textField_singleLine_labelCenteredVetically_cuttlefish.png
M compose/material/material/dialog_stackedButtons_cuttlefish.png
M compose/material3/material3/centerAlignedAppBar_lightTheme_cuttlefish.png
M compose/material/material/fab_textAndIcon_cuttlefish.png
M compose/material/material/outlinedTextField_readOnly_focused_cuttlefish.png
M compose/material/material/tabs_lightTheme_surfaceColors_pressed_cuttlefish.png
M compose/material/material/actionChip_outlined_disabled_cuttlefish.png
M compose/material/material/badge_lightTheme_longContent_tab_cuttlefish.png
M compose/material/material/filterChip_disabled_selected_cuttlefish.png
M compose/material/material/outlined_textField_focused_cuttlefish.png
M compose/material/material/filled_textField_singleLine_withLabel_placeholderAlignedToTop_cuttlefish.png
M wear/compose/material/compactbutton_disabled_cuttlefish.png
M compose/material3/material3/drawerItem_darkTheme_defaultColors_pressed_cuttlefish.png
M compose/material/material/outlined_textField_withInput_cuttlefish.png
M compose/material/material/dialog_onlyText_cuttlefish.png
M compose/material/material/filterChip_disabled_notSelected_cuttlefish.png
M compose/material/material/filterChip_notSelected_cuttlefish.png
M compose/material/material/outlined_textField_focused_errorState_cuttlefish.png
M compose/material3/material3/color_scheme_light_cuttlefish.png
M compose/material3/material3/tabs_lightTheme_pressed_cuttlefish.png
M compose/material/material/outlined_textField_singleLine_withLabel_textAlignedToTop_cuttlefish.png
M compose/material/material/scaffold_bottomAppBar_endFab_floating_ltr_cuttlefish.png
M compose/material3/material3/outlinedCard_darkTheme_cuttlefish.png
M compose/material3/material3/drawerItem_lightTheme_defaultColors_cuttlefish.png
M compose/foundation/foundation/multiStyleText_setFontWeight_cuttlefish.png
M compose/material/material/scaffold_bottomAppBar_centerFab_docked_noCutout_cuttlefish.png
M compose/material3/material3/filled_tonal_button_disabled_light_theme_cuttlefish.png
M compose/material/material/scaffold_bottomAppBar_endFab_docked_ltr_cuttlefish.png
M compose/material/material/filled_textField_not_focused_cuttlefish.png
M compose/material/material/filled_textField_singleLine_withoutLabel_placeholderCenteredVertically_cuttlefish.png
M compose/material/material/textField_readOnly_scrolled_cuttlefish.png
M compose/material3/material3/filled_tonal_button_light_theme_cuttlefish.png
M compose/material/material/scaffold_topAndBottomAppBar_centerFab_docked_cuttlefish.png
M compose/material/material/scaffold_bottomAppBar_cuttlefish.png
M compose/material/material/textField_readOnly_cuttlefish.png
M compose/material3/material3/outlined_button_disabled_light_theme_cuttlefish.png
M compose/material3/material3/snackbar_withDismiss_darkTheme_cuttlefish.png
M compose/material/material/scaffold_topAppBar_endFab_ltr_cuttlefish.png
M compose/foundation/foundation/multiStyleText_setFontStyle_cuttlefish.png
M compose/material3/material3/tabs_darkTheme_cuttlefish.png
M compose/material3/material3/elevatedCard_lightTheme_cuttlefish.png
M wear/compose/material/togglebutton_disabled_cuttlefish.png
M compose/material3/material3/alertDialog_withIcon_lightTheme_cuttlefish.png
M wear/compose/material/button_ltr_cuttlefish.png
M compose/material3/material3/snackbar_darkTheme_cuttlefish.png
M compose/material3/material3/filledCard_lightTheme_cuttlefish.png
M compose/material/material/topAndBottomAppBar_floatingFab_snackbar_cuttlefish.png
M compose/material/material/bottomAppBar_snackbar_cuttlefish.png
M compose/material/material/outlined_textField_multiLine_labelAlignedToTop_cuttlefish.png
M compose/material/material/filterChip_with_leading_icon_selected_cuttlefish.png
M compose/material/material/outlined_textField_focused_rtl_cuttlefish.png
M compose/material/material/outlined_textField_multiLine_withoutLabel_textAlignedToTop_cuttlefish.png
M compose/material3/material3/button_disabled_light_theme_cuttlefish.png
M compose/material/material/leadingIconTabs_darkTheme_defaultColors_cuttlefish.png
M compose/material/material/scaffold_topAndBottomAppBar_endFab_docked_rtl_cuttlefish.png
M compose/material/material/textField_readOnly_focused_cuttlefish.png
M compose/material3/material3/outlinedCard_lightTheme_cuttlefish.png
M compose/material/material/tabs_darkTheme_primaryColors_cuttlefish.png
M compose/material/material/outlinedTextField_textCenterAligned_cuttlefish.png
M compose/material/material/topAppBar_snackbar_cuttlefish.png
M compose/material/material/scaffold_topAndBottomAppBar_endFab_floating_rtl_cuttlefish.png
M compose/material/material/dialog_noTitleOrText_cuttlefish.png
M wear/compose/material/compactbutton_rtl_cuttlefish.png
M compose/material/material/outlined_textField_not_focused_cuttlefish.png
M compose/material3/material3/snackbar_lightTheme_cuttlefish.png
M wear/compose/material/swiped_to_right_50_percent_rtl_cuttlefish.png
M compose/material/material/filterChip_with_leading_icon_disabled_selected_cuttlefish.png
M compose/material/material/button_default_cuttlefish.png
M compose/material/material/tabs_darkTheme_primaryColors_pressed_cuttlefish.png
M compose/material3/material3/elevatedCard_pressed_cuttlefish.png
M compose/material/material/scaffold_topAppBar_centerFab_cuttlefish.png
M compose/material3/material3/snackbar_withAction_lightTheme_cuttlefish.png
M compose/material3/material3/elevatedCard_focused_cuttlefish.png
M compose/material/material/outlinedTextField_readOnly_scrolled_cuttlefish.png
M compose/material3/material3/elevatedCard_darkTheme_cuttlefish.png
M compose/material/material/filled_textField_textColor_defaultContentColor_cuttlefish.png
M compose/material3/material3/elevated_button_disabled_light_theme_cuttlefish.png
M compose/foundation/foundation/text_defaultSelectionColors_cuttlefish.png
M compose/material/material/button_disabled_cuttlefish.png
M compose/material/material/filled_textField_notFocused_errorState_cuttlefish.png
M compose/material/material/actionChip_outlined_cuttlefish.png
M compose/material/material/outlinedTextField_disabled_notScrolled_cuttlefish.png
M compose/material3/material3/color_scheme_dark_cuttlefish.png
M compose/material/material/outlinedTextField_leadingTrailingIcons_cuttlefish.png
M compose/material/material/outlinedTextField_leadingTrailingIcons_error_cuttlefish.png
M compose/material/material/filled_textField_withInput_cuttlefish.png
M compose/material/material/outlinedTextField_readOnly_cuttlefish.png
M compose/material3/material3/filledCard_focus_cuttlefish.png
M compose/material3/material3/outlined_button_light_theme_cuttlefish.png
M compose/material3/material3/color_scheme_light_dynamic_cuttlefish.png
M compose/material/material/outlinedTextField_disabled_notFocusable_cuttlefish.png
M compose/material3/material3/snackbar_withDismiss_lightTheme_cuttlefish.png
M compose/material/material/dialog_titleWithoutTextBaseline_cuttlefish.png
M compose/material3/material3/snackbar_withAction_darkTheme_cuttlefish.png
M compose/material/material/outlinedTextField_lightThemeSelectionColors_cuttlefish.png
M compose/material/material/tabs_lightTheme_surfaceColors_cuttlefish.png
M compose/material/material/filledTextField_lightThemeSelectionColors_cuttlefish.png
M compose/foundation/foundation/textField_defaultSelectionColors_cuttlefish.png
M compose/material/material/dialog_sideBySideButtons_cuttlefish.png
M compose/material3/material3/filledCard_pressed_cuttlefish.png
M compose/material3/material3/button_disabled_dark_theme_cuttlefish.png
M compose/material/material/outlined_textField_multiLine_withLabel_placeholderAlignedToTop_cuttlefish.png
M compose/material/material/scaffold_bottomAppBar_endFab_floating_rtl_cuttlefish.png
M compose/material/material/outlinedTextField_customShape_cuttlefish.png
M compose/material/material/outlined_textField_singleLine_labelCenteredVetically_cuttlefish.png
M compose/material3/material3/fab_extended_text_cuttlefish.png
M compose/material/material/textField_leadingTrailingIcons_cuttlefish.png
M compose/material3/material3/filledCard_darkTheme_cuttlefish.png
M compose/material3/material3/alertDialog_darkTheme_cuttlefish.png
M compose/material/material/filled_textField_singleLine_withLabel_textAlignedToTop_cuttlefish.png
M compose/material/material/outlined_textField_textColor_defaultContentColor_cuttlefish.png
M compose/material/material/tabs_darkTheme_defaultColors_cuttlefish.png
M compose/material/material/topAndBottomAppBar_snackbar_cuttlefish.png
M compose/foundation/foundation/text_customSelectionColors_cuttlefish.png
M compose/material3/material3/outlinedCard_focused_cuttlefish.png
M compose/material3/material3/outlinedCard_pressed_cuttlefish.png
M compose/material3/material3/elevated_button_light_theme_cuttlefish.png
M compose/material/material/dialog_onlyTitle_cuttlefish.png
M compose/material/material/scaffold_bottomAppBar_endFab_docked_rtl_cuttlefish.png
M compose/material/material/outlinedTextField_textAlignedToEnd_cuttlefish.png
M compose/material3/material3/tabs_lightTheme_cuttlefish.png
M compose/material/material/filledTextField_darkThemeSelectionColors_cuttlefish.png
M compose/material/material/textField_disabled_notScrolled_cuttlefish.png
M compose/foundation/foundation/textField_customSelectionColors_cuttlefish.png
M compose/material/material/tabs_lightTheme_defaultColors_pressed_cuttlefish.png
M compose/material/material/snackbar_cuttlefish.png
M compose/material3/material3/filledCard_hover_cuttlefish.png
M compose/material3/material3/tabs_darkTheme_pressed_cuttlefish.png
M compose/material/material/tabs_darkTheme_surfaceColors_cuttlefish.png
M compose/material/material/outlined_textField_multiLine_withoutLabel_placeholderAlignedToTop_cuttlefish.png
M compose/material/material/outlinedTextField_darkThemeSelectionColors_cuttlefish.png
M compose/material/material/scaffold_topAndBottomAppBar_centerFab_floating_cuttlefish.png
M compose/material3/material3/button_dark_theme_cuttlefish.png
M compose/material/material/filled_textField_focused_errorState_cuttlefish.png
M compose/material/material/filterChip_selected_cuttlefish.png
M compose/material/material/textField_leadingTrailingIcons_error_cuttlefish.png
M compose/material/material/scaffold_topAppBar_endFab_rtl_cuttlefish.png
M compose/material3/material3/alertDialog_withIcon_darkTheme_cuttlefish.png
M compose/material3/material3/elevatedCard_hover_cuttlefish.png
M compose/material/material/scaffold_bottomAppBar_centerFab_floating_cuttlefish.png
M compose/material/material/topAndBottomAppBar_dockedFab_snackbar_cuttlefish.png
M compose/material3/material3/centerAlignedAppBar_darkTheme_cuttlefish.png
M compose/material/material/tabs_darkTheme_defaultColors_pressed_cuttlefish.png
M wear/compose/material/button_rtl_cuttlefish.png
M compose/material3/material3/alertDialog_lightTheme_cuttlefish.png
M compose/material/material/outlined_textField_singleLine_withoutLabel_placeholderCenteredVertically_cuttlefish.png
M compose/material3/material3/text_button_light_theme_cuttlefish.png
M compose/material/material/leadingIconTabs_lightTheme_defaultColors_cuttlefish.png
M compose/material/material/outlined_textField_notFocused_errorState_cuttlefish.png
M compose/material/material/scaffold_topAndBottomAppBar_cuttlefish.png
M compose/material/material/outlined_textField_singleLine_withoutLabel_textCenteredVertically_cuttlefish.png
M compose/material/material/actionChip_cuttlefish.png
M compose/foundation/foundation/multiStyleText_setFontFamily_cuttlefish.png
M compose/material3/material3/color_scheme_dark_dynamic_cuttlefish.png
M compose/material/material/tabs_darkTheme_surfaceColors_pressed_cuttlefish.png
M compose/material3/material3/outlinedCard_hover_cuttlefish.png
M compose/material/material/outlined_textField_singleLine_withLabel_placeholderAlignedToTop_cuttlefish.png
M compose/material/material/outlined_textField_multiLine_withLabel_textAlignedToTop_cuttlefish.png
M compose/material3/material3/button_light_theme_cuttlefish.png
M compose/material/material/scaffold_topAndBottomAppBar_endFab_docked_ltr_cuttlefish.png
M compose/material3/material3/fab_extended_text_and_icon_cuttlefish.png
M compose/material3/material3/text_button_disabled_light_theme_cuttlefish.png
M compose/material3/material3/drawerItem_darkTheme_defaultColors_cuttlefish.png
M compose/material/material/scaffold_topAppBar_cuttlefish.png
M compose/material/material/scaffold_topAndBottomAppBar_endFab_floating_ltr_cuttlefish.png
ap...@google.com <ap...@google.com> #53
Branch: androidx-main
commit b3085385b770c834850a133b07e9b28d5a8adc6d
Author: Siyamed Sinir <siyamed@google.com>
Date: Sun Feb 13 15:52:24 2022
Turn off includeFontPadding
This CL turns off includeFontPadding by default. In order to
prevent tall text clip issues, it applies additional padding when
required.
More details at go/compose-include-font-padding-2
Performance: The major change happened in Paragraph construction for
length of 16 and 32. They regressed around 10%. For example length 16
moved from 0.27ms to 0.31ms (Jio Phone Android 11)
Overall this CL
- turn off includeFontPadding
- add additional padding when the text is higher for only the first
and last line
- update LineHeightSpan to not apply line height to first line
- add demos for the new state
RelNote: "Text: includeFontPadding is now turned off by default. The
clipping issues as a result of includeFontPadding=false is handled
and no clipping should occur for tall scripts.
Test: ./gradlew :text:text:test
Test: ./gradlew :text:text:cAT
Test: ./gradlew compose:ui:ui-text:test
Test: ./gradlew compose:ui:ui-text:cAT
Test: ./gradlew compose:foundation:foundation:test
Test: ./gradlew compose:foundation:foundation:cAT
Bug: 171394808
Change-Id: I31c84166ae5241fea3f49e8f293dd9d8a5d712cb
A text/text/src/androidTest/java/androidx/compose/ui/text/android/PaintBoundsTest.kt
M text/text/src/main/java/androidx/compose/ui/text/android/SpannedExtensions.kt
M compose/ui/ui-text/api/restricted_current.txt
M text/text/src/androidTest/java/androidx/compose/ui/text/android/TextLayoutSpanTest.kt
M text/text/src/main/java/androidx/compose/ui/text/android/TextLayout.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/textfield/TextFieldCursorTest.kt
M text/text/src/main/java/androidx/compose/ui/text/android/style/LineHeightSpan.kt
M compose/ui/ui-inspection/src/androidTest/java/androidx/compose/ui/inspection/inspector/LayoutInspectorTreeTest.kt
M compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/platform/AndroidParagraphHelper.android.kt
M compose/ui/ui-text/src/androidAndroidTest/kotlin/androidx/compose/ui/text/ParagraphIntegrationTest.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/OutlinedTextField.kt
A text/text/src/main/java/androidx/compose/ui/text/android/PaintExtensions.kt
A compose/ui/ui-test-font/src/font_ttx/tall_font.ttx
A text/text/src/androidTest/java/androidx/compose/ui/text/android/FontPaddingWithCustomFallbackTest.kt
A compose/ui/ui-test-font/src/commonMain/resources/font/tall_font.ttf
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/text/TextDemos.kt
A text/text/src/androidTest/java/androidx/compose/ui/text/android/FontPaddingTest.kt
M compose/ui/ui-text/src/androidAndroidTest/kotlin/androidx/compose/ui/text/ParagraphFillBoundingBoxesTest.kt
M compose/ui/ui-text/src/androidAndroidTest/kotlin/androidx/compose/ui/text/TextTestExtensions.kt
M text/text/src/main/java/androidx/compose/ui/text/android/LayoutCompat.kt
M compose/ui/ui-text/api/public_plus_experimental_current.txt
M compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/platform/AndroidParagraph.android.kt
M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/textfield/OutlinedTextFieldTest.kt
A compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/text/ComposeFontPadding.kt
M compose/ui/ui-inspection/build.gradle
M compose/ui/ui-text/api/current.txt
M compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/platform/extensions/SpannableExtensions.android.kt
si...@google.com <si...@google.com> #54
si...@google.com <si...@google.com>
ap...@google.com <ap...@google.com> #55
Branch: androidx-main
commit 610346f638983d151c85b0328fa3b3498096543d
Author: Siyamed Sinir <siyamed@google.com>
Date: Sat Mar 19 10:15:06 2022
Fix selection & getLineBottom with top/bottom padding
When includeFontPadding is false TextLayout adds additional padding
around the original Android layout to prevent clipping (aosp/1992050).
In such cases getLineBottom returns the line bottom from the
previously clipped case. This CL adds the bottomPadding to the last
line bottom, and a test for it.
Moreover, when topPadding is set to a non-zero value, selection is
drawn higher than it should be. This CL fixes the selection path
by offsetting it by topPadding to draw in its original location.
However offsetting does not correct the height of the selection for
each line.
Note: SelectionPathHelper is added in the first version of this CL
to illustrate a patch to draw all of selection with the correct
height. However it is not clear if the visual fix is worth the
any performance cost.
Test: New test
Test: ./gradlew :text:text:test
Test: ./gradlew :text:text:cAT
Test: ./gradlew compose:ui:ui-text:test
Test: ./gradlew compose:ui:ui-text:cAT
Bug: 171394808
Change-Id: I22673819a80c9b6ba4d8ad10a2bb020b348c9e27
M text/text/src/androidTest/java/androidx/compose/ui/text/android/FontPaddingWithCustomFallbackTest.kt
M text/text/src/main/java/androidx/compose/ui/text/android/TextLayout.kt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/text/ComposeFontPadding.kt
ap...@google.com <ap...@google.com> #56
Branch: androidx-main
commit 8e2ae729dd4266a6ee955caf2e65135a3cbb99ba
Author: Siyamed Sinir <siyamed@google.com>
Date: Thu Mar 10 08:23:44 2022
Add deprecated includeFontPadding
aosp/1992050 turned off includeFontPadding by default.
This CL adds platform configuration options for TextStyle,
SpanStyle and ParagraphStyle that includes includeFontPadding param.
Other attempts/ideas
* aosp/2020339
* aosp/2025246
RelNote: "Added temporary compatibility configuration for
includeFontPadding in TextStyle/ParagraphStyle. includeFontPadding
can be changed via TextStyle(platformStyle =
PlatformTextStyle(includeFontPadding = true/false)). This is a
temporary configuration option to enable migration and will be
removed."
Test: New tests
Test: ./gradlew compose:ui:ui-text:test
Test: ./gradlew compose:ui:ui-text:cAT
Test: DemoApp
Test: Treehugger
Test: ANDROIDX_PROJECTS=COMPOSE ./gradlew jvmTest desktopTest \
-Pandroidx.compose.multiplatformEnabled=true --no-daemon
Test: ANDROIDX_PROJECTS=COMPOSE ./gradlew \
:compose:desktop:desktop:desktop-samples:run \
-Pandroidx.compose.multiplatformEnabled=true --no-daemon
Bug: 171394808
Change-Id: If47be074f53de9ccf12af114648b21e25722d166
M compose/ui/ui-inspection/src/androidTest/java/androidx/compose/ui/inspection/inspector/ParameterFactoryTest.kt
M compose/ui/ui-text/api/restricted_current.txt
M compose/ui/ui-text/src/androidAndroidTest/kotlin/androidx/compose/ui/text/platform/AndroidParagraphTest.kt
M compose/ui/ui-test-font/src/commonMain/resources/font/sample_font.ttf
M compose/ui/ui-text/src/test/java/androidx/compose/ui/text/TextStyleResolveDefaultsTest.kt
A compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/PlatformTextStyle.kt
M compose/ui/ui-text/src/androidAndroidTest/kotlin/androidx/compose/ui/text/ParagraphIntegrationTest.kt
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/TextStyle.kt
M compose/ui/ui-text/src/test/java/androidx/compose/ui/text/ParagraphStyleTest.kt
M compose/ui/ui-text/src/test/java/androidx/compose/ui/text/TextSpanParagraphStyleTest.kt
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/SpanStyle.kt
M compose/ui/ui-text/src/test/java/androidx/compose/ui/text/SpanStyleTest.kt
A compose/ui/ui-text/src/skikoMain/kotlin/androidx/compose/ui/text/DesktopTextStyle.skiko.kt
A compose/ui/ui-text/src/androidAndroidTest/kotlin/androidx/compose/ui/text/PlatformSpanStyleTest.kt
M compose/ui/ui-test-font/src/font_ttx/sample_font.ttx
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/ParagraphStyle.kt
M compose/ui/ui-text/src/test/java/androidx/compose/ui/text/TextStyleTest.kt
A compose/ui/ui-text/src/androidAndroidTest/kotlin/androidx/compose/ui/text/PlatformTextStyleTest.kt
A compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/AndroidTextStyle.android.kt
A compose/ui/ui-text/src/androidAndroidTest/kotlin/androidx/compose/ui/text/PlatformParagraphStyleTest.kt
M compose/ui/ui-text/api/public_plus_experimental_current.txt
M compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/platform/AndroidParagraph.android.kt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/text/ComposeFontPadding.kt
M compose/ui/ui-text/api/current.txt
si...@google.com <si...@google.com> #57
Thanks for all your feedback.
In the current state:
- we have turned off includeFontPadding
- prevented font clippings that would normally occur, and backported it
- Added an experimental/deprecated API to help with transition in case default value does not work for you right now:
TextStyle(platformStyle = PlatformTextStyle(includeFontPadding = true/false)
ap...@google.com <ap...@google.com> #58
Branch: androidx-main
commit 8263dbf4386be7a8e53dc809f83cb0eb84329d06
Author: Siyamed Sinir <siyamed@google.com>
Date: Sun Mar 27 22:11:27 2022
includeFontPadding line height fix
When we disabled includeFontPadding, because of the differences
between platform versions, we updated LineHeightSpan not to apply
line height to first line. This might be causing small rounding (1px)
differences between the line heights of 1st and the rest of the lines.
This CL updates AndroidParagraphHelper to return to the state before
includeFontPadding changes if includeFontPadding is true.
Finally, canvas.translate is not needed to be called if the
topPadding is 0. This CL updates TextLayout.kt not to translate if
topPadding is 0.
Test: ./gradlew text:text:test
Test: ./gradlew text:text:cAT
Test: ./gradlew compose:ui:ui-text:test
Test: ./gradlew compose:ui:ui-text:cAT
Test: Manual Test in demo app
Bug: 171394808
Bug: 227095468
Change-Id: I112732a542b47b373d6b45992b9758f1bed0b668
M compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/platform/AndroidParagraphHelper.android.kt
M compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/platform/AndroidParagraph.android.kt
M text/text/src/main/java/androidx/compose/ui/text/android/TextLayout.kt
ap...@google.com <ap...@google.com> #59
Branch: androidx-main
commit e752cae9056f9bf8d272f822e64f0e2ec4d0c07d
Author: Siyamed Sinir <siyamed@google.com>
Date: Sun Mar 27 09:06:15 2022
Fix TextStyle.canReuseLayout when platformStyle changes
When platformStyle was added, this function didn't compare
platformStyle.
Test: Added tests
Test: ./gradlew compose:ui:ui-text:test
Test: ./gradlew compose:ui:ui-text:cAT
Test: ./gradlew compose:foundation:foundation:test
Test: ./gradlew compose:foundation:foundation:cAT
Bug: 171394808
Change-Id: Ia5e867dc6419162c9f3db99def86f03e8f4ada9f
M compose/foundation/foundation/src/test/kotlin/androidx/compose/foundation/text/TextLayoutHelperTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/TextLayoutHelper.kt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/text/TextDemos.kt
A compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/text/ComposeReuseLayout.kt
ap...@google.com <ap...@google.com> #60
Branch: androidx-main
commit 5dad3878a8895c328bfb596f44098f3c98789e18
Author: Siyamed Sinir <siyamed@google.com>
Date: Tue Mar 29 07:37:42 2022
Add tests for aosp/2043668
Adds test for first line lineHeight issue fixed in aosp/2043668
Also address open comment for aosp/2045375: add class comment to the
demo screen named ComposeReuseLayout.kt
Test: Added tests
Test: ./gradlew compose:ui:ui-text:test
Test: ./gradlew compose:ui:ui-text:cAT
Test: ./gradlew text:text:test
Test: ./gradlew text:text:cAT
Bug: 171394808
Bug: 227095468
Change-Id: I4562b9abd80ab057b2b5abcf82b81521e5d60a4b
M text/text/src/main/java/androidx/compose/ui/text/android/style/LineHeightSpan.kt
M compose/ui/ui-text/src/androidAndroidTest/kotlin/androidx/compose/ui/text/platform/AndroidParagraphTest.kt
M text/text/src/androidTest/java/androidx/compose/ui/text/android/TextLayoutIntrinsicWidthTest.kt
M compose/ui/ui-text/src/androidAndroidTest/kotlin/androidx/compose/ui/text/ParagraphIntegrationTest.kt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/text/ComposeReuseLayout.kt
M compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/platform/extensions/SpannableExtensions.android.kt
ap...@google.com <ap...@google.com> #61
Branch: androidx-main
commit 51b941b3c03a8dcabf041b6f5bcbcc82c1032460
Author: Siyamed Sinir <siyamed@google.com>
Date: Thu Apr 14 02:01:24 2022
Update screenshot tests for includeFontPadding=true
Related: aosp/2059410
Bug: 171394808
Change-Id: I6195e6a1bd2e803a9de80a862bafcf08cb1d31f6
M wear/compose/material/swiped_to_right_50_percent_ltr_cuttlefish.png
M compose/material/material/tabs_lightTheme_defaultColors_cuttlefish.png
M compose/material3/material3/elevatedCard_disabled_darkTheme_cuttlefish.png
M compose/material3/material3/outlined_textField_singleLine_labelCenteredVetically_cuttlefish.png
M compose/material/material/fab_text_cuttlefish.png
M compose/material3/material3/centerAlignedAppBar_lightTheme_cuttlefish.png
M compose/material3/material3/outlinedTextField_leadingTrailingIcons_error_cuttlefish.png
M compose/material3/material3/outlined_textField_focused_errorState_dark_cuttlefish.png
M compose/material/material/outlinedTextField_readOnly_focused_cuttlefish.png
M compose/material/material/tabs_lightTheme_surfaceColors_pressed_cuttlefish.png
M compose/material/material/outlined_textField_focused_cuttlefish.png
M compose/material/material/outlined_textField_withInput_cuttlefish.png
M compose/material3/material3/drawerItem_darkTheme_defaultColors_pressed_cuttlefish.png
M compose/material/material/filterChip_disabled_notSelected_cuttlefish.png
M compose/material/material/outlined_textField_focused_errorState_cuttlefish.png
M compose/material3/material3/color_scheme_light_cuttlefish.png
M compose/material3/material3/outlined_textField_singleLine_withoutLabel_placeholderCenteredVertically_cuttlefish.png
M compose/material/material/outlined_textField_singleLine_withLabel_textAlignedToTop_cuttlefish.png
M compose/material3/material3/filledCard_disabled_darkTheme_cuttlefish.png
M compose/material/material/scaffold_bottomAppBar_centerFab_docked_noCutout_cuttlefish.png
M compose/material/material/scaffold_bottomAppBar_endFab_docked_ltr_cuttlefish.png
M compose/material3/material3/filled_textField_withInput_cuttlefish.png
M compose/material3/material3/filled_textField_singleLine_withoutLabel_placeholderCenteredVertically_cuttlefish.png
M compose/material/material/filled_textField_not_focused_cuttlefish.png
M compose/material/material/filled_textField_singleLine_withoutLabel_placeholderCenteredVertically_cuttlefish.png
M compose/material3/material3/filled_tonal_button_light_theme_cuttlefish.png
M compose/material/material/scaffold_topAndBottomAppBar_centerFab_docked_cuttlefish.png
M compose/material3/material3/outlinedCard_disabled_darkTheme_cuttlefish.png
M compose/material/material/scaffold_bottomAppBar_cuttlefish.png
M compose/material/material/textField_readOnly_cuttlefish.png
M compose/material3/material3/snackbar_withDismiss_darkTheme_cuttlefish.png
M compose/material/material/scaffold_topAppBar_endFab_ltr_cuttlefish.png
M compose/foundation/foundation/multiStyleText_setFontStyle_cuttlefish.png
M compose/material3/material3/textField_leadingTrailingIcons_cuttlefish.png
M wear/compose/material/togglebutton_disabled_cuttlefish.png
M wear/compose/material/button_ltr_cuttlefish.png
M compose/material3/material3/snackbar_darkTheme_cuttlefish.png
M compose/material3/material3/filledCard_lightTheme_cuttlefish.png
M compose/material3/material3/outlined_textField_not_focused_cuttlefish.png
M compose/material/material/topAndBottomAppBar_floatingFab_snackbar_cuttlefish.png
M compose/material3/material3/filledTextField_darkThemeSelectionColors_cuttlefish.png
M compose/material/material/outlined_textField_focused_rtl_cuttlefish.png
M compose/material/material/leadingIconTabs_darkTheme_defaultColors_cuttlefish.png
M compose/material3/material3/outlinedCard_lightTheme_cuttlefish.png
M compose/material/material/text_darkThemeSelectionColors_cuttlefish.png
M compose/material/material/dialog_noTitleOrText_cuttlefish.png
M wear/compose/material/compactbutton_rtl_cuttlefish.png
M wear/compose/material/swiped_to_right_50_percent_rtl_cuttlefish.png
M compose/material3/material3/outlinedTextField_leadingTrailingIcons_cuttlefish.png
M compose/material3/material3/elevatedCard_pressed_cuttlefish.png
M compose/foundation/foundation/text_defaultSelectionColors_cuttlefish.png
M compose/material/material/filled_textField_notFocused_errorState_cuttlefish.png
M compose/material3/material3/fab_extended_animation_cuttlefish.png
M compose/material/material/outlinedTextField_readOnly_cuttlefish.png
M compose/material3/material3/outlined_button_light_theme_cuttlefish.png
M compose/material/material/outlinedTextField_disabled_notFocusable_cuttlefish.png
M compose/material3/material3/snackbar_withDismiss_lightTheme_cuttlefish.png
M compose/material3/material3/filled_textField_textColor_customTextColor_cuttlefish.png
M compose/material/material/tabs_lightTheme_surfaceColors_cuttlefish.png
M compose/material/material/filledTextField_lightThemeSelectionColors_cuttlefish.png
M compose/material3/material3/filledCard_pressed_cuttlefish.png
M compose/material/material/outlined_textField_multiLine_withLabel_placeholderAlignedToTop_cuttlefish.png
M compose/material3/material3/filled_textField_focused_errorState_cuttlefish.png
M compose/material/material/outlined_textField_singleLine_labelCenteredVetically_cuttlefish.png
M compose/material/material/textField_leadingTrailingIcons_cuttlefish.png
M compose/material3/material3/filledCard_darkTheme_cuttlefish.png
M compose/material3/material3/alertDialog_darkTheme_cuttlefish.png
M compose/material/material/filled_textField_singleLine_withLabel_textAlignedToTop_cuttlefish.png
M compose/material/material/outlined_textField_textColor_defaultContentColor_cuttlefish.png
M compose/material/material/tabs_darkTheme_defaultColors_cuttlefish.png
M compose/material/material/topAndBottomAppBar_snackbar_cuttlefish.png
M compose/material3/material3/outlinedTextField_leadingTrailingIcons_dark_cuttlefish.png
M compose/material3/material3/outlinedCard_pressed_cuttlefish.png
M compose/material3/material3/elevated_button_light_theme_cuttlefish.png
M compose/material/material/dialog_onlyTitle_cuttlefish.png
M compose/material/material/outlinedTextField_textAlignedToEnd_cuttlefish.png
M compose/material/material/filledTextField_darkThemeSelectionColors_cuttlefish.png
M compose/material3/material3/outlined_textField_withInput_dark_cuttlefish.png
M compose/foundation/foundation/textField_customSelectionColors_cuttlefish.png
M compose/material3/material3/outlined_textField_singleLine_withLabel_textAlignedToTop_cuttlefish.png
M compose/material3/material3/filledCard_hover_cuttlefish.png
M compose/material/material/tabs_darkTheme_surfaceColors_cuttlefish.png
M compose/material/material/outlined_textField_multiLine_withoutLabel_placeholderAlignedToTop_cuttlefish.png
M compose/material/material/outlinedTextField_darkThemeSelectionColors_cuttlefish.png
M compose/material/material/scaffold_topAndBottomAppBar_centerFab_floating_cuttlefish.png
M compose/material3/material3/button_dark_theme_cuttlefish.png
M compose/material/material/scaffold_topAppBar_endFab_rtl_cuttlefish.png
M compose/material3/material3/outlinedTextField_readOnly_scrolled_cuttlefish.png
M compose/material3/material3/elevatedCard_hover_cuttlefish.png
M compose/material/material/scaffold_bottomAppBar_centerFab_floating_cuttlefish.png
M compose/material3/material3/filled_textField_not_focused_cuttlefish.png
M compose/material/material/outlined_textField_singleLine_withoutLabel_placeholderCenteredVertically_cuttlefish.png
M compose/material/material/actionChip_cuttlefish.png
M compose/foundation/foundation/multiStyleText_setFontFamily_cuttlefish.png
M compose/material3/material3/filled_textField_singleLine_labelCenteredVetically_cuttlefish.png
M compose/material3/material3/color_scheme_dark_dynamic_cuttlefish.png
M compose/material/material/tabs_darkTheme_surfaceColors_pressed_cuttlefish.png
M compose/material/material/outlined_textField_singleLine_withLabel_placeholderAlignedToTop_cuttlefish.png
M compose/material3/material3/filled_textField_singleLine_withLabel_textAlignedToTop_cuttlefish.png
M compose/material3/material3/drawerItem_darkTheme_defaultColors_cuttlefish.png
M compose/material/material/scaffold_topAndBottomAppBar_endFab_floating_ltr_cuttlefish.png
M compose/material3/material3/filledTextField_lightThemeSelectionColors_cuttlefish.png
M wear/compose/material/button_disabled_cuttlefish.png
M wear/compose/material/compactbutton_ltr_cuttlefish.png
M compose/material/material/actionChip_disabled_cuttlefish.png
M compose/material3/material3/textField_readOnly_focused_cuttlefish.png
M compose/material3/material3/filled_textField_withInput_dark_cuttlefish.png
M compose/material/material/scaffold_bottomAppBar_centerFab_docked_cuttlefish.png
M compose/material/material/outlinedTextField_disabled_cuttlefish.png
M compose/material3/material3/drawerItem_lightTheme_defaultColors_pressed_cuttlefish.png
M compose/material/material/filled_textField_singleLine_labelCenteredVetically_cuttlefish.png
M compose/material3/material3/text_darkThemeSelectionColors_cuttlefish.png
M compose/material/material/dialog_stackedButtons_cuttlefish.png
M compose/material/material/fab_textAndIcon_cuttlefish.png
M compose/material/material/actionChip_outlined_disabled_cuttlefish.png
M compose/material/material/badge_lightTheme_longContent_tab_cuttlefish.png
M compose/material/material/filterChip_disabled_selected_cuttlefish.png
M compose/material/material/filled_textField_singleLine_withLabel_placeholderAlignedToTop_cuttlefish.png
M wear/compose/material/compactbutton_disabled_cuttlefish.png
M compose/material/material/dialog_onlyText_cuttlefish.png
M compose/material/material/filterChip_notSelected_cuttlefish.png
M compose/material3/material3/tabs_lightTheme_pressed_cuttlefish.png
M compose/material/material/scaffold_bottomAppBar_endFab_floating_ltr_cuttlefish.png
M compose/material3/material3/outlined_textField_textColor_customTextColor_cuttlefish.png
M compose/material3/material3/textField_readOnly_scrolled_cuttlefish.png
M compose/material3/material3/outlinedCard_darkTheme_cuttlefish.png
M compose/material3/material3/outlined_textField_withInput_cuttlefish.png
M compose/material3/material3/drawerItem_lightTheme_defaultColors_cuttlefish.png
M compose/material3/material3/outlinedCard_disabled_lightTheme_cuttlefish.png
M compose/material3/material3/text_lightThemeSelectionColors_cuttlefish.png
M compose/foundation/foundation/multiStyleText_setFontWeight_cuttlefish.png
M compose/material3/material3/filled_tonal_button_disabled_light_theme_cuttlefish.png
M compose/material3/material3/textField_readOnly_cuttlefish.png
M compose/material/material/textField_readOnly_scrolled_cuttlefish.png
M compose/material3/material3/outlined_button_disabled_light_theme_cuttlefish.png
M compose/material3/material3/filled_textField_singleLine_withLabel_placeholderAlignedToTop_cuttlefish.png
M compose/material3/material3/tabs_darkTheme_cuttlefish.png
M compose/material3/material3/elevatedCard_lightTheme_cuttlefish.png
M compose/material3/material3/alertDialog_withIcon_lightTheme_cuttlefish.png
M compose/material3/material3/outlined_textField_notFocused_errorState_cuttlefish.png
M compose/material/material/bottomAppBar_snackbar_cuttlefish.png
M compose/material3/material3/outlinedTextField_darkThemeSelectionColors_cuttlefish.png
M compose/material/material/outlined_textField_multiLine_labelAlignedToTop_cuttlefish.png
M compose/material/material/filterChip_with_leading_icon_selected_cuttlefish.png
M compose/material/material/outlined_textField_multiLine_withoutLabel_textAlignedToTop_cuttlefish.png
M compose/material3/material3/button_disabled_light_theme_cuttlefish.png
M compose/material/material/scaffold_topAndBottomAppBar_endFab_docked_rtl_cuttlefish.png
M compose/material/material/textField_readOnly_focused_cuttlefish.png
M compose/material/material/tabs_darkTheme_primaryColors_cuttlefish.png
M compose/material/material/outlinedTextField_textCenterAligned_cuttlefish.png
M compose/material/material/topAppBar_snackbar_cuttlefish.png
M compose/material/material/scaffold_topAndBottomAppBar_endFab_floating_rtl_cuttlefish.png
M compose/material3/material3/snackbar_lightTheme_cuttlefish.png
M compose/material/material/outlined_textField_not_focused_cuttlefish.png
M compose/material3/material3/textField_leadingTrailingIcons_dark_cuttlefish.png
M compose/material/material/filterChip_with_leading_icon_disabled_selected_cuttlefish.png
M compose/material/material/button_default_cuttlefish.png
M compose/material/material/tabs_darkTheme_primaryColors_pressed_cuttlefish.png
M compose/material3/material3/snackbar_withAction_lightTheme_cuttlefish.png
M compose/material/material/scaffold_topAppBar_centerFab_cuttlefish.png
M compose/material3/material3/elevatedCard_focused_cuttlefish.png
M compose/material/material/filled_textField_textColor_defaultContentColor_cuttlefish.png
M compose/material3/material3/elevatedCard_darkTheme_cuttlefish.png
M compose/material/material/outlinedTextField_readOnly_scrolled_cuttlefish.png
M compose/material3/material3/elevated_button_disabled_light_theme_cuttlefish.png
M compose/material3/material3/outlinedTextField_disabled_notScrolled_cuttlefish.png
M compose/material/material/button_disabled_cuttlefish.png
M compose/material3/material3/filled_textField_focused_errorState_dark_cuttlefish.png
M compose/material3/material3/filledCard_disabled_lightTheme_cuttlefish.png
M compose/material/material/actionChip_outlined_cuttlefish.png
M compose/material3/material3/textField_leadingTrailingIcons_error_cuttlefish.png
M compose/material/material/outlinedTextField_disabled_notScrolled_cuttlefish.png
M compose/material3/material3/color_scheme_dark_cuttlefish.png
M compose/material/material/outlinedTextField_leadingTrailingIcons_error_cuttlefish.png
M compose/material/material/outlinedTextField_leadingTrailingIcons_cuttlefish.png
M compose/material3/material3/filledCard_focus_cuttlefish.png
M compose/material/material/filled_textField_withInput_cuttlefish.png
M compose/material3/material3/filled_textField_notFocused_errorState_cuttlefish.png
M compose/material3/material3/color_scheme_light_dynamic_cuttlefish.png
M compose/material3/material3/snackbar_withAction_darkTheme_cuttlefish.png
M compose/material/material/dialog_titleWithoutTextBaseline_cuttlefish.png
M compose/material/material/outlinedTextField_lightThemeSelectionColors_cuttlefish.png
M compose/material3/material3/textField_disabled_notScrolled_cuttlefish.png
M compose/foundation/foundation/textField_defaultSelectionColors_cuttlefish.png
M compose/material/material/dialog_sideBySideButtons_cuttlefish.png
M compose/material3/material3/button_disabled_dark_theme_cuttlefish.png
M compose/material/material/outlinedTextField_customShape_cuttlefish.png
M compose/material/material/scaffold_bottomAppBar_endFab_floating_rtl_cuttlefish.png
M compose/material3/material3/fab_extended_text_cuttlefish.png
M compose/material3/material3/outlinedTextField_readOnly_cuttlefish.png
M compose/foundation/foundation/text_customSelectionColors_cuttlefish.png
M compose/material3/material3/outlinedCard_focused_cuttlefish.png
M compose/material/material/scaffold_bottomAppBar_endFab_docked_rtl_cuttlefish.png
M compose/material3/material3/tabs_lightTheme_cuttlefish.png
M compose/material/material/textField_disabled_notScrolled_cuttlefish.png
M compose/material3/material3/outlinedTextField_lightThemeSelectionColors_cuttlefish.png
M compose/material/material/tabs_lightTheme_defaultColors_pressed_cuttlefish.png
M compose/material/material/snackbar_cuttlefish.png
M compose/material3/material3/tabs_darkTheme_pressed_cuttlefish.png
M compose/material/material/filterChip_selected_cuttlefish.png
M compose/material/material/filled_textField_focused_errorState_cuttlefish.png
M compose/material/material/textField_leadingTrailingIcons_error_cuttlefish.png
M compose/material3/material3/elevatedCard_disabled_lightTheme_cuttlefish.png
M compose/material3/material3/alertDialog_withIcon_darkTheme_cuttlefish.png
M compose/material/material/topAndBottomAppBar_dockedFab_snackbar_cuttlefish.png
M compose/material3/material3/centerAlignedAppBar_darkTheme_cuttlefish.png
M compose/material/material/tabs_darkTheme_defaultColors_pressed_cuttlefish.png
M wear/compose/material/button_rtl_cuttlefish.png
M compose/material3/material3/alertDialog_lightTheme_cuttlefish.png
M compose/material3/material3/text_button_light_theme_cuttlefish.png
M compose/material/material/leadingIconTabs_lightTheme_defaultColors_cuttlefish.png
M compose/material/material/outlined_textField_notFocused_errorState_cuttlefish.png
M compose/material3/material3/outlinedTextField_readOnly_focused_cuttlefish.png
M compose/material/material/outlined_textField_singleLine_withoutLabel_textCenteredVertically_cuttlefish.png
M compose/material/material/scaffold_topAndBottomAppBar_cuttlefish.png
M compose/material3/material3/outlined_textField_singleLine_withLabel_placeholderAlignedToTop_cuttlefish.png
M compose/material3/material3/outlinedCard_hover_cuttlefish.png
M compose/material/material/outlined_textField_multiLine_withLabel_textAlignedToTop_cuttlefish.png
M compose/material3/material3/button_light_theme_cuttlefish.png
M compose/material3/material3/outlined_textField_focused_errorState_cuttlefish.png
M compose/material/material/scaffold_topAndBottomAppBar_endFab_docked_ltr_cuttlefish.png
M compose/material3/material3/fab_extended_text_and_icon_cuttlefish.png
M compose/material3/material3/text_button_disabled_light_theme_cuttlefish.png
M compose/material/material/scaffold_topAppBar_cuttlefish.png
ap...@google.com <ap...@google.com> #62
Branch: androidx-main
commit 85fc924b492636402c5e210641dc69262f89ec32
Author: Siyamed Sinir <siyamed@google.com>
Date: Sat Apr 09 00:50:46 2022
Default includeFontPadding=true
This CL changes the default includeFontPadding back to true.
Previously, for an alpha release we turned it off in aosp/1992050.
This would break some users when switching to the beta/final release.
Moreover, keeping it experimental and optional for now will enable us
to spend a little more time on clipping, line height, text field
related improvements including defining the default line height
behavior with the functionalities in aosp/2058653.
RelNote: "Turned on default includeFontPadding. It is possible to
turn off the includeFontPadding using TextStyle.platformTextStyle
attribute. In the near future we will change the default behavior
however until that time this allows us to better integrate line height
improvements (aosp/2058653) and solve TextField clipping issues."
Test: ./gradlew text:text:test
Test: ./gradlew text:text:cAT
Test: ./gradlew compose:ui:ui-text:test
Test: ./gradlew compose:ui:ui-text:cAT
Bug: 171394808
Change-Id: I01423d9a0042a1f3e462236e1fdadb60a20678fc
M compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/AndroidTextStyle.android.kt
M compose/ui/ui-text/src/androidAndroidTest/kotlin/androidx/compose/ui/text/ParagraphFillBoundingBoxesTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text/selection/TextSelectionColorsScreenshotTest.kt
M compose/ui/ui-text/src/androidAndroidTest/kotlin/androidx/compose/ui/text/ParagraphIntegrationTest.kt
si...@google.com <si...@google.com> #63
An update on includeFontPadding
- The default value for Compose 1.2 beta and later 1.2 is now the old state which is includeFontPadding=true
- It is still possible to opt-in and turn it off via
TextStyle( platformStyle = PlatformTextStyle( includeFontPadding = false ) )
co...@protonmail.com <co...@protonmail.com> #64
@Si...@google.com
Any harm in defaulting to includeFontPadding = false in all of my projects? Seems like it was the default, but got switched and was wondering why the decision to not have includeFontPadding = false by default.
si...@google.com <si...@google.com> #65
Any harm in defaulting to includeFontPadding = false in all of my projects?
No, as far as we know there is not.
Please check
Seems like it was the default, but got switched and was wondering why the decision to not have includeFontPadding = false by default.
It was changed to provide opt-in option for the community, and not change their layout (even if it is a small change) without them opting in for Compose 1.2 Beta. We are currently planning to turn it back off as default as described in RelNote
section in
RelNote: "Turned on default includeFontPadding. It is possible to
turn off the includeFontPadding using TextStyle.platformTextStyle
attribute. In the near future we will change the default behavior
however until that time this allows us to better integrate line height
improvements (aosp/2058653) and solve TextField clipping issues."
co...@protonmail.com <co...@protonmail.com> #66
Awesome. If it will be turned off by default again then I will just wait for that. Thanks! Looking forward to easier translations from figma to compose =)
ma...@gmail.com <ma...@gmail.com> #67
so...@gmail.com <so...@gmail.com> #68
ke...@gmail.com <ke...@gmail.com> #69
Any updates? the issue is marked as Fixed
for some reason
Description
With traditional views, you can specify in XML on your TextView whether or not you want to include font padding using
android:includeFontPadding="false"
.It would be nice if Compose provided a means of doing this (because otherwise it makes it difficult to migrate traditional views over to Compose w/o it looking visually different).