Fixed
Status Update
No update yet.
Comments
je...@google.com
And: the input dispatcher is internal, yet localToGlobal is public
je...@google.com
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 16da8beff7b64d52156e207e34a4c2b26580f437
Author: Jelle Fresen <jellefresen@google.com>
Date: Thu Oct 22 12:06:39 2020
Remove localToGlobal from GestureScope
It was intended to be used when interacting with the InputDispatcher
directly, but that one is internal. That makes localToGlobal a loaded
gun pointing at your feet, because there literally is no correct usage.
Fixes: 171462785
Test: ./gradlew compose:ui:ui-test:cC
Relnote: "Removed GestureScope.localToGlobal"
Change-Id: I15299ffe7f0119020089ca9f2256508f56424b8e
M compose/ui/ui-test/api/current.txt
M compose/ui/ui-test/api/public_plus_experimental_current.txt
M compose/ui/ui-test/api/restricted_current.txt
M compose/ui/ui-test/src/androidAndroidTest/kotlin/androidx/compose/ui/test/gesturescope/PositionsTest.kt
M compose/ui/ui-test/src/commonMain/kotlin/androidx/compose/ui/test/GestureScope.kt
https://android-review.googlesource.com/1474154
Branch: androidx-master-dev
commit 16da8beff7b64d52156e207e34a4c2b26580f437
Author: Jelle Fresen <jellefresen@google.com>
Date: Thu Oct 22 12:06:39 2020
Remove localToGlobal from GestureScope
It was intended to be used when interacting with the InputDispatcher
directly, but that one is internal. That makes localToGlobal a loaded
gun pointing at your feet, because there literally is no correct usage.
Fixes: 171462785
Test: ./gradlew compose:ui:ui-test:cC
Relnote: "Removed GestureScope.localToGlobal"
Change-Id: I15299ffe7f0119020089ca9f2256508f56424b8e
M compose/ui/ui-test/api/current.txt
M compose/ui/ui-test/api/public_plus_experimental_current.txt
M compose/ui/ui-test/api/restricted_current.txt
M compose/ui/ui-test/src/androidAndroidTest/kotlin/androidx/compose/ui/test/gesturescope/PositionsTest.kt
M compose/ui/ui-test/src/commonMain/kotlin/androidx/compose/ui/test/GestureScope.kt
Description
Jelle> "everything that you need inputdispatcher for is already present in gesturescope