Please add a NavOptions parameter to the NavController.navigate extension function. [171468994]

Fixed

Feature Request

Status Update

No update yet.

Description

le...@gmail.com

created issue #1

Oct 22, 2020 03:53PM

Component used: Navigation Compose

Version used: 1.0.0-SNAPSHOT

Devices/Android versions reproduced on: All

In NavHostController.kt please consider adding an extra parameter to the navigate extension function, for example:

public fun NavController.navigate(
    destinationId: Any,
    args: Bundle? = null,
    navOptions: NavOptions? = null
)

This is needed to be able to set the popUpTo parameter for clearing the BackStack, for example after displaying a sign-in page.

Comments

il...@google.com <il...@google.com> Oct 22, 2020 06:10PM

Assigned to jb...@google.com.

ap...@google.com <ap...@google.com> #2Nov 2, 2020 08:51PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 41b9a249e82a06a228e09257a8b880c646eae92f
Author: Jeremy Woods <jbwoods@google.com>
Date: Thu Oct 29 15:17:30 2020

Add support for NavOptions in Navigation compose

Adding support to add NavOptions to navigate() calls in Navigation
compose.

Used the new support in the BottomBarNavDemo.

RelNote: "Navigation compose now support NavOptions for using popUpTo
and launchSingleTop operations"
Test: NavHostControllerTest and ComposeNavigatorTest
Bug: 171468994

Change-Id: I8282d4d92eb90b32f4ee5119face3b57920d873b

M navigation/navigation-compose/api/current.txt
M navigation/navigation-compose/api/public_plus_experimental_current.txt
M navigation/navigation-compose/api/restricted_current.txt
M navigation/navigation-compose/build.gradle
M navigation/navigation-compose/integration-tests/navigation-demos/src/main/java/androidx/navigation/compose/demos/BottomBarNavDemo.kt
A navigation/navigation-compose/src/androidTest/java/androidx/navigation/compose/ComposeNavigatorTest.kt
M navigation/navigation-compose/src/androidTest/java/androidx/navigation/compose/NavHostControllerTest.kt
M navigation/navigation-compose/src/main/java/androidx/navigation/compose/ComposeNavigator.kt
M navigation/navigation-compose/src/main/java/androidx/navigation/compose/NavHostController.kt
A navigation/navigation-compose/src/main/java/androidx/navigation/compose/NavOptionsBuilder.kt

https://android-review.googlesource.com/1480405

ap...@google.com <ap...@google.com> #3Nov 3, 2020 05:02PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 4f4ccf7a4e75e118bfa893db1203785020bed317
Author: Jeremy Woods <jbwoods@google.com>
Date: Mon Nov 02 23:53:04 2020

Revert "Revert "Add support for NavOptions in Navigation compose""

This reverts commit e8fd1a39707a6edd1daf85c430fb5327976b5f79.

Reason for revert: aosp/1483934 add support for compose studio version

RelNote: "Navigation compose now support NavOptions for using popUpTo
and launchSingleTop operations"
Test: NavHostControllerTest and ComposeNavigatorTest
Bug: 171468994

Change-Id: If96c3a3f99f29c6e2e88d64285b7af46ad3835c2

M navigation/navigation-compose/api/current.txt
M navigation/navigation-compose/api/public_plus_experimental_current.txt
M navigation/navigation-compose/api/restricted_current.txt
M navigation/navigation-compose/build.gradle
M navigation/navigation-compose/integration-tests/navigation-demos/src/main/java/androidx/navigation/compose/demos/BottomBarNavDemo.kt
A navigation/navigation-compose/src/androidTest/java/androidx/navigation/compose/ComposeNavigatorTest.kt
M navigation/navigation-compose/src/androidTest/java/androidx/navigation/compose/NavHostControllerTest.kt
M navigation/navigation-compose/src/main/java/androidx/navigation/compose/ComposeNavigator.kt
M navigation/navigation-compose/src/main/java/androidx/navigation/compose/NavHostController.kt
A navigation/navigation-compose/src/main/java/androidx/navigation/compose/NavOptionsBuilder.kt

https://android-review.googlesource.com/1484382

ap...@google.com <ap...@google.com> #4Nov 5, 2020 01:06AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 5e2ce6f7c99860914391ba465ce5d5b2ad33bbcc
Author: Jeremy Woods <jbwoods@google.com>
Date: Tue Nov 03 09:37:53 2020

Add samples for popUpTo and singleTop

Adding samples for the new NavOptions feature.

Test: tested in demo app
Bug: 171468994
Change-Id: Ibff40345ca8562549d8580b9b04b0955035fba1c

A navigation/navigation-compose/integration-tests/navigation-demos/src/main/java/androidx/navigation/compose/demos/NavPopUpToDemo.kt
A navigation/navigation-compose/integration-tests/navigation-demos/src/main/java/androidx/navigation/compose/demos/NavSingleTopDemo.kt
M navigation/navigation-compose/integration-tests/navigation-demos/src/main/java/androidx/navigation/compose/demos/NavigationDemos.kt

https://android-review.googlesource.com/1486336

jb...@google.com <jb...@google.com> #5Nov 5, 2020 01:08AM

Marked as fixed.

This has been fixed internally, and will be available in the Navigation Compose 1.0.0-alpha02 release.

Issue 171468994