Please add a NavOptions parameter to the NavController.navigate extension function. [171468994]

Fixed

Feature Request

Status Update

No update yet.

Description

le...@gmail.com

created issue #1

Oct 22, 2020 03:53PM

Component used: Navigation Compose

Version used: 1.0.0-SNAPSHOT

Devices/Android versions reproduced on: All

In NavHostController.kt please consider adding an extra parameter to the navigate extension function, for example:

public fun NavController.navigate(
    destinationId: Any,
    args: Bundle? = null,
    navOptions: NavOptions? = null
)

This is needed to be able to set the popUpTo parameter for clearing the BackStack, for example after displaying a sign-in page.

Comments

il...@google.com <il...@google.com> Oct 22, 2020 06:10PM

Assigned to jb...@google.com.

ap...@google.com <ap...@google.com> #2Nov 2, 2020 08:51PM

Nested scrolling works partially (as per

http://b/122818889). Let's discuss if we need full support and if so make sure it works.

ap...@google.com <ap...@google.com> #3Nov 3, 2020 05:02PM

Hi!

What is 'partially' exactly?
How do I see it?
Thanks!

ap...@google.com <ap...@google.com> #4Nov 5, 2020 01:06AM

As of now:
- Nesting scroll views with a scroll direction perpendicular to the ViewPager2's orientation inside ViewPager2 works
- Nesting scroll views with a scroll direction parallel to the ViewPager2's orientation inside ViewPager2 does not work

jb...@google.com <jb...@google.com> #5Nov 5, 2020 01:08AM

Marked as fixed.

Horizontal ViewPager2 not correctly working into a vertical RecyclerView
Set a setNestedScrollingEnabled to the RecyclerView into the ViewPager2 (across reflection) resolves the problem

Issue 171468994