Fixed
Status Update
No update yet.
Comments
nj...@google.com
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit d9b4479dc7b80f8909f5a1fd2bd5ffd7c62dda80
Author: Nader Jawad <njawad@google.com>
Date: Mon Oct 26 21:41:09 2020
Add camera distance support to DrawLayer
Relnote: "Add support for camera distance
to complement 3d transformations
rotationX/rotationY on layer APIs."
Fixes: 171492100
Test: Added test to AndroidLayoutDrawTest
Change-Id: I402132be203b2d62b5c3026e3989877e2fa8f3e1
M compose/ui/ui/api/current.txt
M compose/ui/ui/api/public_plus_experimental_current.txt
M compose/ui/ui/api/restricted_current.txt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/AndroidLayoutDrawTest.kt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/draw/DrawLayerModifierTest.kt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/draw/DrawLayerTest.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/DeviceRenderNode.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/RenderNodeApi23.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/RenderNodeApi29.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/RenderNodeLayer.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/ViewLayer.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/DrawLayerModifier.kt
M compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/platform/SkijaLayer.kt
https://android-review.googlesource.com/1475539
Branch: androidx-master-dev
commit d9b4479dc7b80f8909f5a1fd2bd5ffd7c62dda80
Author: Nader Jawad <njawad@google.com>
Date: Mon Oct 26 21:41:09 2020
Add camera distance support to DrawLayer
Relnote: "Add support for camera distance
to complement 3d transformations
rotationX/rotationY on layer APIs."
Fixes: 171492100
Test: Added test to AndroidLayoutDrawTest
Change-Id: I402132be203b2d62b5c3026e3989877e2fa8f3e1
M compose/ui/ui/api/current.txt
M compose/ui/ui/api/public_plus_experimental_current.txt
M compose/ui/ui/api/restricted_current.txt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/AndroidLayoutDrawTest.kt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/draw/DrawLayerModifierTest.kt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/draw/DrawLayerTest.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/DeviceRenderNode.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/RenderNodeApi23.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/RenderNodeApi29.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/RenderNodeLayer.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/ViewLayer.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/DrawLayerModifier.kt
M compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/platform/SkijaLayer.kt
Description
Jetpack Compose release version: 1.0.0-alpha05
From discussion in
In
Modifier.drawLayer()there arerotationXandrotationYparameters, which are making kind of 3D rotation. But these rotations look very distorted, because camera distance is too small, and there's no way to control it. BothRenderNodeViewsetCameraDistance(), which can be used to control camera distance from Compose.So I think there should be either good defaults, so that
rotationXandrotationYwould not look that distorted, or there should be modifier parameter to control camera distance.