Icon.kt applies a transparent tint when Color.Unspecified is passed as the `tint` argument. [171624632]

Fixed

Bug

Status Update

No update yet.

Description

al...@gmail.com

created issue #1

Oct 25, 2020 09:03PM

When using Icon.kt, I personally would expect that passing Color.Unspecified as the tint would result in no tint being applied to the icon at all (in other words, a null color filter would be passed to the Painter and the colors that are rendered would just be whatever the VectorAsset or ImageAsset internally draws).

This is currently not the case, as passing Color.Unspecified results in a transparent color filter being applied (meaning the icon is not rendered at all).

This behavior is particularly important to support multi-colored icons, where you need to avoid a tint being applied all together.

// EXPECTED BEHAVIOR: no tint is applied to the vector asset
// ACTUAL BEHAVIOR: a transparent tint is applied to the vector asset
Icon(
    asset = someVectorAsset,
    tint = Color.Unspecified,
)

The code in question at the time this bug was filed is here: https://cs.android.com/androidx/platform/frameworks/support/+/androidx-master-dev:compose/material/material/src/commonMain/kotlin/androidx/compose/material/Icon.kt;l=96;drc=989981f1b2a64419ed599cb82e2c589b6b41e46d

Comments

ma...@google.com <ma...@google.com> #2Oct 26, 2020 11:38AM

Reassigned to nj...@google.com.

Hi,

I also see my text cut off when I set maxLines = 2. Is it the same issue?

  Box(
    modifier =
      Modifier.size(
        width = 108dp,
        height = 34dp,
      ),
    contentAlignment = Alignment.Center,
  ) {
    BasicText(
      text = "text text text",
      maxLines = 2,
      autoSize = AutoSize.StepBased(minFontSize = 1.sp, maxFontSize = 13.sp, stepSize = 0.2.sp),
    )
  }

al...@gmail.com <al...@gmail.com> #3Oct 26, 2020 04:44PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Jossi Wolf <jossiwolf@google.com>
Link: https://android-review.googlesource.com/3450389

Fix TextAutoSize bug with maxLines = 1

Expand for full commit details

Fix TextAutoSize bug with maxLines = 1 
 
We were overcaching the paragraphIntrinsics in MultiParagraphLayoutCache when mutating the style. For `AutoSizeStepBased` instances with biased windows (more values smaller/bigger than the optimal), this could result in performing layout with outdated intrinsics, and thus an outdated style and font size, without surfacing this in the TextLayoutResult. 
 
Test: New MultiParagraphLayoutCacheTests and manual testing 
Relnote: Fixed a bug in BasicText with TextAutoSize and maxLines set to 1. 
Fixes: 376834366 
 
Change-Id: Ic0450c763c5d764492995b44ee1fe570246a9689

Files:

M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/text/modifiers/MultiParagraphLayoutCacheTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/modifiers/MultiParagraphLayoutCache.kt

Hash: e1b712d78cc60384ed67a56c006148291ba146a6
Date: Tue Jan 07 18:52:26 2025

nj...@google.com <nj...@google.com> Oct 28, 2020 03:43AM

Accepted by nj...@google.com.

ap...@google.com <ap...@google.com> #4Oct 28, 2020 06:31PM

Marked as fixed.

#2, yeah, that's the same issue.

ap...@google.com <ap...@google.com> #5Oct 28, 2020 11:26PM

Thanks @jo...@google.com for fixing this! Do you know when the fix would be available for g3 apps?

Issue 171624632