Icon.kt applies a transparent tint when Color.Unspecified is passed as the `tint` argument. [171624632]

Fixed

Bug

Status Update

No update yet.

Description

al...@gmail.com

created issue #1

Oct 25, 2020 09:03PM

When using Icon.kt, I personally would expect that passing Color.Unspecified as the tint would result in no tint being applied to the icon at all (in other words, a null color filter would be passed to the Painter and the colors that are rendered would just be whatever the VectorAsset or ImageAsset internally draws).

This is currently not the case, as passing Color.Unspecified results in a transparent color filter being applied (meaning the icon is not rendered at all).

This behavior is particularly important to support multi-colored icons, where you need to avoid a tint being applied all together.

// EXPECTED BEHAVIOR: no tint is applied to the vector asset
// ACTUAL BEHAVIOR: a transparent tint is applied to the vector asset
Icon(
    asset = someVectorAsset,
    tint = Color.Unspecified,
)

The code in question at the time this bug was filed is here: https://cs.android.com/androidx/platform/frameworks/support/+/androidx-master-dev:compose/material/material/src/commonMain/kotlin/androidx/compose/material/Icon.kt;l=96;drc=989981f1b2a64419ed599cb82e2c589b6b41e46d

Comments

ma...@google.com <ma...@google.com> #2Oct 26, 2020 11:38AM

Reassigned to nj...@google.com.

There is a report about it in kotlinlang Slack: https://kotlinlang.slack.com/archives/C01D6HTPATV/p1706005056105739

al...@gmail.com <al...@gmail.com> #3Oct 26, 2020 04:44PM

Thanks for the report!

nj...@google.com <nj...@google.com> Oct 28, 2020 03:43AM

Accepted by nj...@google.com.

ap...@google.com <ap...@google.com> #4Oct 28, 2020 06:31PM

Marked as fixed.

The release notes documentation has been edited to clarify this change in behavior for line height.

To support non-standard text sizes, we encourage users to follow the Material design system and use a different type scale rather than changing the font size directly. Alternatively, users can overwrite the line height like so: style = LocalTextStyle.current.copy(lineHeight = TextUnit.Unspecified), or create a custom Typography entirely.

ap...@google.com <ap...@google.com> #5Oct 28, 2020 11:26PM

deleted

Issue 171624632