Icon.kt applies a transparent tint when Color.Unspecified is passed as the `tint` argument. [171624632]

Fixed

Bug

Status Update

No update yet.

Description

al...@gmail.com

created issue #1

Oct 25, 2020 09:03PM

When using Icon.kt, I personally would expect that passing Color.Unspecified as the tint would result in no tint being applied to the icon at all (in other words, a null color filter would be passed to the Painter and the colors that are rendered would just be whatever the VectorAsset or ImageAsset internally draws).

This is currently not the case, as passing Color.Unspecified results in a transparent color filter being applied (meaning the icon is not rendered at all).

This behavior is particularly important to support multi-colored icons, where you need to avoid a tint being applied all together.

// EXPECTED BEHAVIOR: no tint is applied to the vector asset
// ACTUAL BEHAVIOR: a transparent tint is applied to the vector asset
Icon(
    asset = someVectorAsset,
    tint = Color.Unspecified,
)

The code in question at the time this bug was filed is here: https://cs.android.com/androidx/platform/frameworks/support/+/androidx-master-dev:compose/material/material/src/commonMain/kotlin/androidx/compose/material/Icon.kt;l=96;drc=989981f1b2a64419ed599cb82e2c589b6b41e46d

Comments

ma...@google.com <ma...@google.com> #2Oct 26, 2020 11:38AM

Reassigned to nj...@google.com.

A couple of questions:

1. Have you saw crash in real device or only in simulators?
2. Do you use dynamic feature for language ID?

al...@gmail.com <al...@gmail.com> #3Oct 26, 2020 04:44PM

Tested on Android 12 Emulator with custom executor, but cannot repro this issue.

nj...@google.com <nj...@google.com> Oct 28, 2020 03:43AM

Accepted by nj...@google.com.

ap...@google.com <ap...@google.com> #4Oct 28, 2020 06:31PM

Marked as fixed.

Second crash in the description is from a real device. Experienced it myself on two different Xiaomi phones, plus lots of crashes from users in the Google Play console.
Dynamic features are not used in the application.

As a wild guess, I have downgraded build tools from 31.0.0 to 30.0.3, compileSdk from 31 to 30, and moved all work with Language ID to the service in a separate process (just to be sure that crash can kill secondary process instead of main). This combination is in beta for 2 days by now and I don't see any SIGSEGV crashes.

ap...@google.com <ap...@google.com> #5Oct 28, 2020 11:26PM

Hmm, I feel the crash might be something related to separate/secondary process.

I also changed compileSdk and targetSDK to 31 but still cannot repro this issue.

Issue 171624632