drawShadow opacity affects the opacity of the whole Composable and its children [171624638]

Fixed

Bug

Status Update

No update yet.

Description

af...@gmail.com

created issue #1

Oct 26, 2020 02:05AM

Build: AI-202.7660.26.42.6907010, 202010150442,

AI-202.7660.26.42.6907010, JRE 11.0.8+10-b944.6842174x64 JetBrains s.r.o, OS Mac OS X(x86_64) v10.15.7, screens 1680x1050

AS: 4.2 Canary 14; Kotlin plugin: 1.4.20-M1-Studio4.2-1; Android Gradle Plugin: 4.2.0-alpha14; Gradle: 6.7; latest from SDK: 21.3.6528147; CMake: from local.properties: (not specified), latest from SDK: (not found), from PATH: 3.18.2

Jetpack Compose: 1.0.0-alpha05

IMPORTANT: Please read https://developer.android.com/studio/report-bugs.html carefully and supply all required information.

It seems like when I add a drawShadow modifier with an opacity lower than 1f to a Box. Its and its children's opacity gets affected.

Here's an example where changing the opacity should only change the shadow's opacity but instead it changes the opacity of the whole box.

val opacity = 0.3f

@Composable
private fun StrangeButton() {
    Box(
        modifier = Modifier.drawShadow(
            elevation = 4.dp,
            opacity = opacity
        ).background(
            color = Color.Green
        )
    ) {
        Image(
            asset = Icons.Default.Person,
            colorFilter = ColorFilter.tint(Color.White)
        )
    }
}

Please let me know if I can provide any more details. Thanks!

Comments

cl...@google.com <cl...@google.com> Oct 27, 2020 12:48PM

Assigned to an...@google.com.

an...@google.com <an...@google.com> #2Oct 27, 2020 03:51PM

Reassigned to mo...@google.com.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019

Change the way to detect mismatch between POJO and query

This fixes cursor mismatch warnings with expandProjection.

Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8

M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt

https://android-review.googlesource.com/1123258

https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1

mo...@google.com <mo...@google.com> #3Oct 27, 2020 03:53PM

Status: Won't Fix (Intended Behavior)

The following changes were cherrypicked through Coastguard (

https://android-build.googleplex.com/coastguard/)
Release Track: (

https://android-build.googleplex.com/coastguard/dashboard/6093116828680192/#/cherrypickHistory/all)
Created: 2019-10-14 17:23:42.610596+00:00
Changes: aosp/1123258

an...@google.com <an...@google.com> #4Oct 27, 2020 03:58PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020

Re-factor how errors are dismissed when query is re-written

This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (

b/140759491

).
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.

This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.

Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f

M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt

https://android-review.googlesource.com/1288456

af...@gmail.com <af...@gmail.com> #5Oct 27, 2020 03:58PM

Seems like this is already achieved through drawOpacity so it might be misleading that there's an opacity argument for drawShadow that does not only affect the shadow.

So is there any way to change of opacity of just the shadow?

mo...@google.com <mo...@google.com> #6Oct 27, 2020 03:58PM

Status: Assigned (reopened)

Hmm.. maybe removing opacity is a good idea. A developer can always write her own version.

an...@google.com <an...@google.com> #7Oct 27, 2020 04:03PM

A bit hacky, but you can achieve it by stacking the shadow with opacity with your real content on top of it.
Box(Modifier.size(48.dp)) {
Box(Modifier.fillMaxSize().drawShadow(elevation = 4.dp, opacity = 0.5f))
Box(Modifier.fillMaxSize()) {
/// your content
}
}

af...@gmail.com <af...@gmail.com> #8Oct 27, 2020 04:08PM

Thanks. That's how I implemented moving a shadow behind a box too, so I guess that works!

ap...@google.com <ap...@google.com> #9Oct 28, 2020 03:27PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 0b4461f9627049831e2fd92a593a757aeca6ee84
Author: George Mount <mount@google.com>
Date: Tue Oct 27 11:14:34 2020

Remove opacity from drawShadow

Fixes: 171624638
Relnote: "Removed opacity from drawShadow() modifier as it was
confusing."

Test: existing tests
Change-Id: I82c622c9eb42c528667fdaeef53271c502c16fb5

M compose/ui/ui/api/current.txt
M compose/ui/ui/api/public_plus_experimental_current.txt
M compose/ui/ui/api/restricted_current.txt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/draw/DrawShadowTest.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/draw/DrawShadow.kt

https://android-review.googlesource.com/1477077