drawShadow opacity affects the opacity of the whole Composable and its children [171624638]

Fixed

Bug

Status Update

No update yet.

Description

af...@gmail.com

created issue #1

Oct 26, 2020 02:05AM

Build: AI-202.7660.26.42.6907010, 202010150442,

AI-202.7660.26.42.6907010, JRE 11.0.8+10-b944.6842174x64 JetBrains s.r.o, OS Mac OS X(x86_64) v10.15.7, screens 1680x1050

AS: 4.2 Canary 14; Kotlin plugin: 1.4.20-M1-Studio4.2-1; Android Gradle Plugin: 4.2.0-alpha14; Gradle: 6.7; latest from SDK: 21.3.6528147; CMake: from local.properties: (not specified), latest from SDK: (not found), from PATH: 3.18.2

Jetpack Compose: 1.0.0-alpha05

IMPORTANT: Please read https://developer.android.com/studio/report-bugs.html carefully and supply all required information.

It seems like when I add a drawShadow modifier with an opacity lower than 1f to a Box. Its and its children's opacity gets affected.

Here's an example where changing the opacity should only change the shadow's opacity but instead it changes the opacity of the whole box.

val opacity = 0.3f

@Composable
private fun StrangeButton() {
    Box(
        modifier = Modifier.drawShadow(
            elevation = 4.dp,
            opacity = opacity
        ).background(
            color = Color.Green
        )
    ) {
        Image(
            asset = Icons.Default.Person,
            colorFilter = ColorFilter.tint(Color.White)
        )
    }
}

Please let me know if I can provide any more details. Thanks!

Comments

cl...@google.com <cl...@google.com> Oct 27, 2020 12:48PM

Assigned to an...@google.com.

an...@google.com <an...@google.com> #2Oct 27, 2020 03:51PM

Reassigned to mo...@google.com.

First of all thanks for this detailed issue.

This issue had been investigated thoroughly when it was first reported internally. The surprising detail in this report is that the issue is not reproducible before 1.7. I will look into this.

The main problem with POBox is the fact that it is deprecated. Since 2021 Sony has been shipping new Xperia devices with Gboard pre-installed. Although we are aware that there is still a considerable amount of users still using POBox, the described behavior is caused by POBox's noncompliant behavior with InputConnection and InputMethodManager documentation. However, this is understandable since TextView implementation was also not respecting the behavior that is expected from Editors.

Ultimately we have decided to enforce the documented behavior with specifically regards to when editors should call InputMethodManager.updateSelection. Also, although unconfirmed, there were traces of possible custom code being included in Sony OEM images that changed how InputMethodManager was notified from TextView. If POBox also depended on something like this, it would be impossible for Compose code to replicate the same unknown behavior.

mo...@google.com <mo...@google.com> #3Oct 27, 2020 03:53PM

Status: Won't Fix (Intended Behavior)

If the investigation takes time, would it be possible to revert the surrounding implementation to 1.6.x equivalent?

Or is that option not available?

Even if the root cause is POBox, from the perspective of the app's customers, it looks like an app bug, so this issue is a blocker against updating Jetpack Compose.

an...@google.com <an...@google.com> #4Oct 27, 2020 03:58PM

Just to be sure, it is dangerous to replace Compose TextField with Android View EditText as a workaround for this issue.

Compose 1.7 has a bug that causes ANR when the focus is on EditText. https://issuetracker.google.com/issues/369354336

Another View-related bug in Compose 1.7 is that an Android View is focused by calling FocusManager.clearFocus(). https://issuetracker.google.com/issues/374031296

Perhaps there is a lack of testing of Compose 1.7 in combination with Android View. There is also a possibility that there are other fatal bugs related to View.

In other words, the only options for apps targeting the Japanese market that require POBox support are to continue using Compose 1.6 or to use EditText in combination with various workarounds.

af...@gmail.com <af...@gmail.com> #5Oct 27, 2020 03:58PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Halil Ozercan <halilibo@google.com>
Link: https://android-review.googlesource.com/3317256

Fix POBox keyboard issue

Expand for full commit details

Fix POBox keyboard issue 
 
Fix: 373743376 
Fix: 329209241 
Test: NullableInputConnectionWrapperTest 
Change-Id: I94e0e598274fb88b255f977f9fbd50dfbbb1ecb1

Files:

M compose/ui/ui/src/androidInstrumentedTest/kotlin/androidx/compose/ui/text/input/NullableInputConnectionWrapperTest.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/text/input/NullableInputConnectionWrapper.android.kt

Hash: 57f58c4b80d5d8470b2aca325dfdcd55f235231e
Date: Thu Oct 24 01:25:20 2024

mo...@google.com <mo...@google.com> #6Oct 27, 2020 03:58PM

Status: Assigned (reopened)

Many thanks again for this report. Especially for giving us a huge clue in terms of what could be going wrong. The fix is now merged and I will ask for a cherry-pick into a stable release.

an...@google.com <an...@google.com> #7Oct 27, 2020 04:03PM

Thank you for fixing the issue, I confirmed the fix was released in version 1.8.0-alpha05.
Do you have any concrete plan to cherry-pick the fix into current stable version (1.7.x)? We are currently waiting it.

af...@gmail.com <af...@gmail.com> #8Oct 27, 2020 04:08PM

Yes, this fix is planned to be included in a future 1.7.x release.

ap...@google.com <ap...@google.com> #9Oct 28, 2020 03:27PM

Marked as fixed.

Thanks for the fix. Sorry to follow up on this. is it possible for you to share specific release version/date for the stable version? We are waiting on this to decide on our direction.