IssueTracker

Hi,

I also see my text cut off when I set maxLines = 2. Is it the same issue?

  Box(
    modifier =
      Modifier.size(
        width = 108dp,
        height = 34dp,
      ),
    contentAlignment = Alignment.Center,
  ) {
    BasicText(
      text = "text text text",
      maxLines = 2,
      autoSize = AutoSize.StepBased(minFontSize = 1.sp, maxFontSize = 13.sp, stepSize = 0.2.sp),
    )
  }

Project: platform/frameworks/support
Branch: androidx-main
Author: Jossi Wolf <jossiwolf@google.com>
Link:      https://android-review.googlesource.com/3450389

Fix TextAutoSize bug with maxLines = 1

Fix TextAutoSize bug with maxLines = 1 
 
We were overcaching the paragraphIntrinsics in MultiParagraphLayoutCache when mutating the style. For `AutoSizeStepBased` instances with biased windows (more values smaller/bigger than the optimal), this could result in performing layout with outdated intrinsics, and thus an outdated style and font size, without surfacing this in the TextLayoutResult. 
 
Test: New MultiParagraphLayoutCacheTests and manual testing 
Relnote: Fixed a bug in BasicText with TextAutoSize and maxLines set to 1. 
Fixes: 376834366 
 
Change-Id: Ic0450c763c5d764492995b44ee1fe570246a9689

#2, yeah, that's the same issue.

Thanks @jo...@google.com for fixing this! Do you know when the fix would be available for g3 apps?

Moving the internal discussion offline. The bug is fixed and the fix available in snapshot builds. We will comment on this issue when the bug fix is included in a release.

The following release(s) address this bug.It is possible this bug has only been partially addressed:

• androidx.compose.foundation:foundation:1.8.0-beta01
• androidx.compose.foundation:foundation-android:1.8.0-beta01
• androidx.compose.foundation:foundation-jvmstubs:1.8.0-beta01
• androidx.compose.foundation:foundation-linuxx64stubs:1.8.0-beta01

Yes, it is available in the latest compose released yesterday

Will there ever be support for Android 11 and below?

Stretch effect overscroll will be supported only for android 12 and above. For versions prior to that, the original glow edge overscroll will be shown.

This is done by design, so that overscroll in every app will feel the same, leaving users with the feel of consistency.

I hope that makes sense.

This looks broken indeed. I believe this should not happen if you are using latest snapshot where we properly support stretch effect. Could you share more information about this sample's setup? Compose version, code with snippet (is it LazyColumn, Modifier.verticalScroll or your own Modifier.scrollable) and any other relevant info.

Thanks.

I used LazyColumn in compose_version = '1.1.0-alpha03' . I just created a brand new project to test this, still the same issue. I am attaching android version,build number... if that helps.

//code snippet

@Composable
fun ScreenMain() {
    LazyColumn(
        modifier = Modifier.fillMaxSize(),
        content = {

            items(30) {
                RowItem(number = it)
            }
        })
}

@Composable
fun RowItem(number: Int) {
    Box(
        modifier = Modifier
            .fillMaxWidth()
            .height(50.dp)
            .padding(all = 8.dp)
            .border(width = 1.dp, color = Color.Red),
        contentAlignment = Alignment.Center,
    ) {
        Text(text = "Row $number", color = Color.Black)
    }
}

Thanks for additional info.

I tried this example in the emulator, pixel 3 and some various Samsungs, and I cannot reproduce the issue for some reason.

There's a version check that prohibits any kind of overscroll for S devices on 1.1.0-alpha03.

Could you please try a real phone with android S if you have some? Or a fresh emulator image?

Alternatively, you can turn off overscroll for now and wait for alpha04 where stretch overscroll for S devices will be fully supported.

Thanks for the reply. I reinstalled Android S Images and then created a new virtual device. Issue seems to be resolved now. Probably issue was with the S preview.

Oh, that makes sense as well, as some S previews had incomplete support for stretch in the RenderNode, so it might have been broken there.

I'm glad that everything is working well for you now!

Is the default material color correct for both light mode and dark mode? I see 0xff666666 hardcoded here: https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/gestures/OverScrollConfiguration.kt;l=38?q=OverScrollConfiguration%20lang:kotlin&ss=androidx%2Fplatform%2Fframeworks%2Fsupport:compose%2F

But IIRC this color is themed using android:colorEdgeEffect, for example here: https://cs.android.com/android/platform/superproject/+/master:frameworks/base/core/res/res/values/themes_material.xml;l=775?q=themes_material.xml&ss=android%2Fplatform%2Fsuperproject:frameworks%2Fbase

Might need to update MaterialTheme.kt and the material-components-android-compose-theme-adapter project too if this is the case.

Yup, you are right.

The default color is design system agnostic. Since we're waiting for API feedback - we cannot wire up foundation glow api with material just yet. It will be done as soon as we will graduate OverScrollConfiguration from experimental.

you can do it manually for now in your app.