Touch indication sometimes doesn't show when tapped very quickly [171913923]

Fixed

Bug

Status Update

No update yet.

Description

za...@gmail.com

created issue #1

Oct 28, 2020 10:15PM

Jetpack Compose release version: 1.0.0-alpha06 Android Studio Build: Android Studio 4.2 Canary 15 Build #AI-202.7660.26.42.6922807, built on October 21, 2020 Runtime version: 11.0.8+10-b944.6842174 x86_64 VM: OpenJDK 64-Bit Server VM by N/A macOS 10.15.7 GC: ParNew, ConcurrentMarkSweep Memory: 15974M Cores: 16 Registry: analyze.exceptions.on.the.fly=true, debugger.watches.in.variables=false, vcs.log.index.git=off, caches.indexerThreadsCount=16 Non-Bundled Plugins: carbon-now-sh, com.squareup.android.library.generator, org.jetbrains.kotlin

There seems to be a regression from alpha05 to alpha06 where the touch indication on clickable seems to occasionally not render, when tapped very quickly. See the attached video.

Code to reproduce:

@Composable fun ClickableRepro() {
  var state by remember { mutableStateOf(true) }

  MaterialTheme {
    Box(
        Modifier.clickable(onClick = { state = !state })
            .fillMaxSize()
            .wrapContentSize()
    ) {
      Text(if (state) "One" else "Two")
    }
  }
}

clickable bug.mp4

166 KB

Download

Comments

ma...@google.com <ma...@google.com> #2Oct 29, 2020 09:57AM

Assigned to lp...@google.com.

Project: platform/frameworks/support
Branch: androidx-main

commit ed90c9a382eb2afe65b62765519e6256edc76195
Author: Siyamed Sinir <siyamed@google.com>
Date: Thu Apr 15 11:12:47 2021

Add ParagraphStyle/SpanStyle Saver

Preparation for TextFieldValue/AnnotatedString Savers.
- After a concern about dependencies collected all
savers to the same file un ui-text.
- We want to make those savers public, however since
the module of those Savers requires discussion,
will move the Savers in another CL.

RelNote: "Added TextUnit constructor function
TextUnit(value: Float, type: TextUnitType)"

Test: Added tests
Test: ./gradlew compose:ui:ui-text:test
Test: ./gradlew compose:ui:ui-text:cAT

Bug: 178446304
Change-Id: I7eccedda948c374d0cab1e883a56294aa9007b68

M compose/ui/ui-text/api/1.0.0-beta06.txt
M compose/ui/ui-text/api/current.txt
M compose/ui/ui-text/api/public_plus_experimental_1.0.0-beta06.txt
M compose/ui/ui-text/api/public_plus_experimental_current.txt
M compose/ui/ui-text/api/restricted_1.0.0-beta06.txt
M compose/ui/ui-text/api/restricted_current.txt
A compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/Savers.kt
A compose/ui/ui-text/src/test/java/androidx/compose/ui/text/SaversTest.kt
M compose/ui/ui-unit/api/public_plus_experimental_1.0.0-beta06.txt
M compose/ui/ui-unit/api/public_plus_experimental_current.txt
M compose/ui/ui-unit/src/commonMain/kotlin/androidx/compose/ui/unit/TextUnit.kt

https://android-review.googlesource.com/1675372

lp...@google.com <lp...@google.com> #3Oct 29, 2020 12:29PM

Project: platform/frameworks/support
Branch: androidx-main

commit 3e6425cb44d32cd39f9bc7e1daacd78dfaa56552
Author: Siyamed Sinir <siyamed@google.com>
Date: Fri Apr 16 23:52:31 2021

Add LocaleList.Saver

Test: Added tests
Test: ./gradlew compose:ui:ui-text:test
Test: ./gradlew compose:ui:ui-text:cAT

Bug: 178446304
Change-Id: I24412b7f8e19191e2450c7241e256fd0fa47e9f7

M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/textfield/TextFieldTest.kt
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/Savers.kt
M compose/ui/ui-text/src/test/java/androidx/compose/ui/text/SaversTest.kt
M compose/ui/ui-text/src/test/java/androidx/compose/ui/text/input/TextFieldValueTest.kt

https://android-review.googlesource.com/1678467

za...@gmail.com <za...@gmail.com> #4Oct 29, 2020 01:55PM

Project: platform/frameworks/support
Branch: androidx-main

commit 9d7ad4e2c349f6c47555b15f7789068361b5006c
Author: Siyamed Sinir <siyamed@google.com>
Date: Fri Apr 16 20:39:10 2021

Add AnnotatedString Saver

- Added AnnotatedString Saver
- Added TextRange.Saver
- changed TextFieldValue.Saver to use
AnnotatedStringSaver and TextRange.Saver
- Added missing API
AnnotatedString.Builder.addTtsAnnotation
- Added missing API
AnnotatedString.Builder.withAnnotation for
String and TtsAnnotation

RelNote: "AnnotatedString save support to
TextFieldValue.Saver. Added addTtsAnnotation
and withAnnotation utility functions to
AnnotatedString.Builder
"

Test: Added tests
Test: ./gradlew compose:ui:ui-text:test
Test: ./gradlew compose:ui:ui-text:cAT

Bug: 178446304
Change-Id: I8cbdcfcdbe167ff7c68c760aebdd8affe2d8434e

M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/textfield/TextFieldTest.kt
M compose/ui/ui-text/api/public_plus_experimental_1.0.0-beta06.txt
M compose/ui/ui-text/api/public_plus_experimental_current.txt
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/AnnotatedString.kt
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/Savers.kt
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/TtsAnnotation.kt
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/input/TextFieldValue.kt
M compose/ui/ui-text/src/test/java/androidx/compose/ui/text/SaversTest.kt
M compose/ui/ui-text/src/test/java/androidx/compose/ui/text/input/TextFieldValueTest.kt

https://android-review.googlesource.com/1678466

lp...@google.com <lp...@google.com> #5Oct 29, 2020 05:01PM

this ticket is waiting fontFamily to be saved.

ap...@google.com <ap...@google.com> #6Feb 11, 2021 02:34AM

Marked as fixed.

might be related to b/334682521

Issue 171913923