Fixed
Status Update
No update yet.
Comments
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit ffab94165541560e134bd7af8fb1d61233f242fa
Author: Nader Jawad <njawad@google.com>
Date: Fri Oct 30 14:35:21 2020
Update drawWithCache API naming for consistentcy
Relnote: "Created onDrawBehind API within ContentDrawScope
to match naming convention with Modifier.drawBehind."
Fixes: 171955269
Test: Re-ran compose tests
Change-Id: I4fc3ae880757f9956c522a03e2ac28ab205946e9
M compose/ui/ui/api/current.txt
M compose/ui/ui/api/public_plus_experimental_current.txt
M compose/ui/ui/api/restricted_current.txt
M compose/ui/ui/samples/src/main/java/androidx/compose/ui/samples/DrawModifierSample.kt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/draw/DrawModifierTest.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/DrawModifier.kt
https://android-review.googlesource.com/1482478
Branch: androidx-master-dev
commit ffab94165541560e134bd7af8fb1d61233f242fa
Author: Nader Jawad <njawad@google.com>
Date: Fri Oct 30 14:35:21 2020
Update drawWithCache API naming for consistentcy
Relnote: "Created onDrawBehind API within ContentDrawScope
to match naming convention with Modifier.drawBehind."
Fixes: 171955269
Test: Re-ran compose tests
Change-Id: I4fc3ae880757f9956c522a03e2ac28ab205946e9
M compose/ui/ui/api/current.txt
M compose/ui/ui/api/public_plus_experimental_current.txt
M compose/ui/ui/api/restricted_current.txt
M compose/ui/ui/samples/src/main/java/androidx/compose/ui/samples/DrawModifierSample.kt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/draw/DrawModifierTest.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/DrawModifier.kt
Description
We have:
Modifier.drawBehind {}
Modifier.drawWithCache {}
But in inside drawWithCache block we have:
onDraw {}
onDrawWithCache {}
Should the first one have "Behind" in the name? I am also not sure they both need "on" as well