Fixed
Status Update
No update yet.
Comments
me...@appinventiv.com
Hi Ed, Thank you so much for these suggestions. I've been reviewing them and merging them in. Hopefully it should be live. I've included a thank you note too in the article.
sc...@google.com
Great! Thanks a lot, I'll look for the live updates soon!
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 332e6cdde83db7c2346dfa7d21846be62bcd7107
Author: Scott Nien <scottnien@google.com>
Date: Tue Nov 10 22:35:39 2020
Stops repeating ahead of still capture when flash is always/auto on Samsung SM-A716 devices.
On Samsung SM-A716 series devices, when taking photos in dark environement with auto/always
flash, it will not notify the results to the app.
Added a workaround to fix the problem by stoping repeating before triggering still image
capture and resume repeating after the capture is done or abort.
Relnote:"Fixed the issue that taking pictures doesn't receive results when flash is always/on
and environment is dark on Samsung SM-A716 devices."
Test: StillCaptureFlowTest, all camera2 test
Bug:
Change-Id: If98b2b45cbf1a7fb7228d4db1885846621644341
M camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/CameraBurstCaptureCallback.java
M camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/CaptureSession.java
M camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/compat/quirk/DeviceQuirksLoader.java
A camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/compat/quirk/StillCaptureFlashStopRepeatingQuirk.java
A camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/compat/workaround/StillCaptureFlow.java
M camera/camera-camera2/src/test/java/androidx/camera/camera2/internal/CameraBurstCaptureCallbackTest.java
A camera/camera-camera2/src/test/java/androidx/camera/camera2/internal/compat/workaround/StillCaptureFlowTest.java
https://android-review.googlesource.com/1494336
Branch: androidx-master-dev
commit 332e6cdde83db7c2346dfa7d21846be62bcd7107
Author: Scott Nien <scottnien@google.com>
Date: Tue Nov 10 22:35:39 2020
Stops repeating ahead of still capture when flash is always/auto on Samsung SM-A716 devices.
On Samsung SM-A716 series devices, when taking photos in dark environement with auto/always
flash, it will not notify the results to the app.
Added a workaround to fix the problem by stoping repeating before triggering still image
capture and resume repeating after the capture is done or abort.
Relnote:"Fixed the issue that taking pictures doesn't receive results when flash is always/on
and environment is dark on Samsung SM-A716 devices."
Test: StillCaptureFlowTest, all camera2 test
Bug:
Change-Id: If98b2b45cbf1a7fb7228d4db1885846621644341
M camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/CameraBurstCaptureCallback.java
M camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/CaptureSession.java
M camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/compat/quirk/DeviceQuirksLoader.java
A camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/compat/quirk/StillCaptureFlashStopRepeatingQuirk.java
A camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/compat/workaround/StillCaptureFlow.java
M camera/camera-camera2/src/test/java/androidx/camera/camera2/internal/CameraBurstCaptureCallbackTest.java
A camera/camera-camera2/src/test/java/androidx/camera/camera2/internal/compat/workaround/StillCaptureFlowTest.java
Description
calling stopRepeating before the still imageCapture will fix the issue but our framework team think this is still a bug . OEM device should allow the single capture to be executed parallelly with repeating request.
This bug is for having a workaround in CameraX to workaround it while the