[Feature Request] Expose onConfigure to RoomDatabase.Callback [172270145]

Fixed

Bug

Status Update

No update yet.

Description

ah...@gmail.com

created issue #1

Nov 3, 2020 10:07AM

Component used: Jetpack Room Version used: 2.2.5 Devices/Android versions reproduced on: Any

I'd like to execute some PRAGMA statements[1], before using the Database, I tried to do that on onOpen callback but it doesn't seem to work. There is an onConfigure[2] callback from the SQLiteOpenHelper that I can use but it's not exposed through Room. Is it possible to expose it or is there an alternative way to execute PRAGMA statements?

I can send a PR if it's okay.

[1] PRAGMA wal_autocheckpoint=-1

[2] https://developer.android.com/reference/android/database/sqlite/SQLiteOpenHelper#onConfigure(android.database.sqlite.SQLiteDatabase)

Comments

da...@google.com <da...@google.com> #2Nov 6, 2020 12:50AM

The issue is reproducible with core-ktx 1.2.0 and 1.3.0-rc01.

da...@google.com <da...@google.com> #3Nov 6, 2020 01:03AM

The Typeface.weight is not a weight of the underlying font file. It is a display style. On older APIs, the display style is adjusted if the Typeface is created from single font. However, after moving to CustomFallbackBuilder, that adjustment is removed since it can crate Typeface from multiple style font files.

Looks like it is good to set display style by ResourcesCompat.getFont for backward compatibility.

ah...@gmail.com <ah...@gmail.com> #4Nov 6, 2020 09:23AM

Hi Nona,

Can you please schedule a release after you merge the fix?

da...@google.com <da...@google.com> #5Nov 6, 2020 04:21PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 3d6aa2e9b3243dcc4de1f54bd8d40339bd69cb05
Author: Seigo Nonaka <nona@google.com>
Date: Wed May 27 17:38:05 2020

Adjust the Typeface display style with the style of given font

This behavir is implicitly done by Typeface.Builder and
Typeface.createXXX function but not to be done by
Typeface.CustomFallbackBuilder since it is designed to be working
with multiple font files which has different style.

Looks like the style argument is ignored on older API implementation.

Bug: 156853883
Bug: 152023266
Test: ResourcesCompatTest#testGetFont_adjustDisplayStyle passes on 29
Test: ./gradlew core:core:connectedAndroidTest on API 29, 28, 23
Change-Id: I3a377c339a7aed50973cf11df86ddf0069f4ec25

A core/core/src/androidTest/assets/fonts/thin_italic.ttf
A core/core/src/androidTest/assets/fonts/thin_italic.ttx
M core/core/src/androidTest/java/androidx/core/content/res/ResourcesCompatTest.java
A core/core/src/androidTest/res/font/thin_italic.ttf
M core/core/src/main/java/androidx/core/graphics/TypefaceCompatApi29Impl.java

https://android-review.googlesource.com/1318947

ah...@gmail.com <ah...@gmail.com> #6Nov 8, 2020 10:56PM

The following changes were cherrypicked through Coastguard Release Track: (https://android-build.googleplex.com/coastguard/dashboard/6222780589080576/#/history/all) Changes: aosp/1318947

ap...@google.com <ap...@google.com> #7Nov 12, 2020 06:26PM

Any way I can tell what version this will land in?

da...@google.com <da...@google.com> Dec 8, 2020 04:17PM

Marked as fixed.

ah...@gmail.com <ah...@gmail.com> #8
Restricted
Nov 28, 2021 12:57AM

Comment has been deleted.

Issue 172270145