Disabled buttons are not marked as "disabled" in TalkBack [172366489]

Fixed

Bug

Status Update

No update yet.

Description

ta...@gmail.com

created issue #1

Nov 4, 2020 03:19PM

Jetpack Compose release version: 1.0.0-alpha06

TalkBack does not currently read out "disabled" for buttons that are disabled.

For example, I'd expect this button to read out as "Save, Button, disabled", but it currently is read as simple "Save" (I know the button class name issue is being worked on separately):

Button(
  onClick = {},
  enabled = false
) {
  Text("Save")
}

As an example from the View world, this does read as "Save, button, disabled":

<Button
  android:layout_width="wrap_content"
  android:layout_height="wrap_content"
  android:enabled="false"
  android:text="Save" />

This appears to be because TalkBack only reads "disabled" on nodes that are both disabled and actionable, with "actionable" being defined as clickable, long clickable, focusable, or has custom actions. Since Button only adds an onClick semantic if it is enabled, it is never both "actionable" and disabled right now.

Comments

so...@google.com <so...@google.com> Nov 4, 2020 04:01PM

Assigned to yi...@google.com.

so...@google.com <so...@google.com> #2Nov 4, 2020 05:03PM

We have some support in androidx.compose.ui.autofill

Leaving this bug open in case Ralston wants to add more info

yi...@google.com <yi...@google.com> #3Dec 1, 2020 09:51PM

Accepted by yi...@google.com.

I found an example here. One problem is that it only works with the Google autofill service. When using any other service like Microsoft Authenticator or OneKey, the following error is shown:

D/Autofill Status: Autofill popup isn't shown because autofill is not available.
    
    Did you set up autofill?
    1. Go to Settings > System > Languages&input > Advanced > Autofill Service
    2. Pick a service
    
    Did you add an account?
    1. Go to Settings > System > Languages&input > Advanced
    2. Click on the settings icon next to the Autofill Service
    3. Add your account

Is this a bug on your side or do the app developers of these password managers need to change their implementation?

pw...@google.com <pw...@google.com> #4Dec 1, 2020 09:57PM

Another problem I am facing with autofill is that it won't save my credentials. I tried forcing to finish the context as described here, but it won't do that either although I filled in the username with the one provided by the Google autofill service.

cb...@google.com <cb...@google.com> #5Dec 2, 2020 11:09PM

deleted

ap...@google.com <ap...@google.com> #6Dec 11, 2020 02:54AM

Marked as fixed.

Facing the same issue here, Google autofill service seems to work. Zero documentation on adding support for Autofill framework on jetpack compose.

Issue 172366489