Disabled buttons are not marked as "disabled" in TalkBack [172366489]

Fixed

Bug

Status Update

No update yet.

Description

ta...@gmail.com

created issue #1

Nov 4, 2020 03:19PM

Jetpack Compose release version: 1.0.0-alpha06

TalkBack does not currently read out "disabled" for buttons that are disabled.

For example, I'd expect this button to read out as "Save, Button, disabled", but it currently is read as simple "Save" (I know the button class name issue is being worked on separately):

Button(
  onClick = {},
  enabled = false
) {
  Text("Save")
}

As an example from the View world, this does read as "Save, button, disabled":

<Button
  android:layout_width="wrap_content"
  android:layout_height="wrap_content"
  android:enabled="false"
  android:text="Save" />

This appears to be because TalkBack only reads "disabled" on nodes that are both disabled and actionable, with "actionable" being defined as clickable, long clickable, focusable, or has custom actions. Since Button only adds an onClick semantic if it is enabled, it is never both "actionable" and disabled right now.

Comments

so...@google.com <so...@google.com> Nov 4, 2020 04:01PM

Assigned to yi...@google.com.

so...@google.com <so...@google.com> #2Nov 4, 2020 05:03PM

Hi,

I also see my text cut off when I set maxLines = 2. Is it the same issue?

  Box(
    modifier =
      Modifier.size(
        width = 108dp,
        height = 34dp,
      ),
    contentAlignment = Alignment.Center,
  ) {
    BasicText(
      text = "text text text",
      maxLines = 2,
      autoSize = AutoSize.StepBased(minFontSize = 1.sp, maxFontSize = 13.sp, stepSize = 0.2.sp),
    )
  }

yi...@google.com <yi...@google.com> #3Dec 1, 2020 09:51PM

Accepted by yi...@google.com.

Project: platform/frameworks/support
Branch: androidx-main
Author: Jossi Wolf <jossiwolf@google.com>
Link: https://android-review.googlesource.com/3450389

Fix TextAutoSize bug with maxLines = 1

Expand for full commit details

Fix TextAutoSize bug with maxLines = 1 
 
We were overcaching the paragraphIntrinsics in MultiParagraphLayoutCache when mutating the style. For `AutoSizeStepBased` instances with biased windows (more values smaller/bigger than the optimal), this could result in performing layout with outdated intrinsics, and thus an outdated style and font size, without surfacing this in the TextLayoutResult. 
 
Test: New MultiParagraphLayoutCacheTests and manual testing 
Relnote: Fixed a bug in BasicText with TextAutoSize and maxLines set to 1. 
Fixes: 376834366 
 
Change-Id: Ic0450c763c5d764492995b44ee1fe570246a9689

Files:

M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/text/modifiers/MultiParagraphLayoutCacheTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/modifiers/MultiParagraphLayoutCache.kt

Hash: e1b712d78cc60384ed67a56c006148291ba146a6
Date: Tue Jan 07 18:52:26 2025

pw...@google.com <pw...@google.com> #4Dec 1, 2020 09:57PM

#2, yeah, that's the same issue.

cb...@google.com <cb...@google.com> #5Dec 2, 2020 11:09PM

Thanks @jo...@google.com for fixing this! Do you know when the fix would be available for g3 apps?

ap...@google.com <ap...@google.com> #6Dec 11, 2020 02:54AM

Marked as fixed.

Moving the internal discussion offline. The bug is fixed and the fix available in snapshot builds. We will comment on this issue when the bug fix is included in a release.

Issue 172366489