Disabled buttons are not marked as "disabled" in TalkBack [172366489]

Fixed

Bug

Status Update

No update yet.

Description

ta...@gmail.com

created issue #1

Nov 4, 2020 03:19PM

Jetpack Compose release version: 1.0.0-alpha06

TalkBack does not currently read out "disabled" for buttons that are disabled.

For example, I'd expect this button to read out as "Save, Button, disabled", but it currently is read as simple "Save" (I know the button class name issue is being worked on separately):

Button(
  onClick = {},
  enabled = false
) {
  Text("Save")
}

As an example from the View world, this does read as "Save, button, disabled":

<Button
  android:layout_width="wrap_content"
  android:layout_height="wrap_content"
  android:enabled="false"
  android:text="Save" />

This appears to be because TalkBack only reads "disabled" on nodes that are both disabled and actionable, with "actionable" being defined as clickable, long clickable, focusable, or has custom actions. Since Button only adds an onClick semantic if it is enabled, it is never both "actionable" and disabled right now.

Comments

so...@google.com <so...@google.com> Nov 4, 2020 04:01PM

Assigned to yi...@google.com.

so...@google.com <so...@google.com> #2Nov 4, 2020 05:03PM

Hi. Thanks for reporting this. Fixed in this changelist. This should be available in alpha-04

yi...@google.com <yi...@google.com> #3Dec 1, 2020 09:51PM

Accepted by yi...@google.com.

Project: platform/frameworks/support
Branch: androidx-main

commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023

fix: tab row crashes when only 1 tab is added

Bug:

b/264018028

Test: Added unit test

Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f

M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt

https://android-review.googlesource.com/2373449

pw...@google.com <pw...@google.com> #4Dec 1, 2020 09:57PM

deleted

cb...@google.com <cb...@google.com> #5Dec 2, 2020 11:09PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.tv:tv-material:1.0.0-alpha04

ap...@google.com <ap...@google.com> #6Dec 11, 2020 02:54AM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 1e6d8aa505d2efde5f61ff3c45325ab533840d32
Author: yingleiw <yingleiw@google.com>
Date: Fri Dec 04 14:49:25 2020

provide SemanticsActions when a SemanticsNode is marked as disabled

In android, we have a clickable property. when disabled, we don't
add the click accessibility action (we still have the onclick
listener though for non accessibility), but we still set the
clickable to true.

In talkback, we only notify disabled when the node is actionable.
In android, since we have clickable set the node is actionable.
but for compose, clickable is not set, so talkback doesn't announce
it is disabled because the node is not considered actionable.

This cl change it to always add semantics actions, even when the node is
disabled and convert to corresponding android accessibility properties.
For more details on different solutions considered, please see the bug.

Relnote: Add Toggle to foundation Strings.kt

Fix:

b/172366489

Test: tested with demo app and talkback. Added a disabled toggle button
in the demo app to make sure disabled nodes can't be toggled. Added an
integration test to make sure disabled nodes can't be toggled.
Unit tests added.

Change-Id: I4a5b74e3ed9bc3b1acd09af221331ef6ab51b9fe

M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/public_plus_experimental_current.txt
M compose/foundation/foundation/api/restricted_current.txt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/ClickableTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/ToggleableTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Clickable.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Strings.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/selection/Toggleable.kt
M compose/material/material/integration-tests/material-demos/src/main/java/androidx/compose/material/demos/ButtonDemo.kt
M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/CheckboxUiTest.kt
M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/SwitchTest.kt
M compose/ui/ui-test/src/androidAndroidTest/kotlin/androidx/compose/ui/test/ErrorMessagesTest.kt
M compose/ui/ui/api/current.txt
M compose/ui/ui/api/public_plus_experimental_current.txt
M compose/ui/ui/api/restricted_current.txt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/AndroidAccessibilityTest.kt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/AndroidComposeViewAccessibilityDelegateCompatTest.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/AndroidComposeViewAccessibilityDelegateCompat.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/semantics/SemanticsProperties.kt

https://android-review.googlesource.com/1518413

Issue 172366489