Fixed
Status Update
Comments
cc...@google.com <cc...@google.com> #2
Yigit, do you have time to fix it?
reemission of the same liveData is racy
reemission of the same liveData is racy
ap...@google.com <ap...@google.com> #4
Thanks for the detailed analysis. This may not be an issue anymore since we've started using Main.immediate there but I' not sure; I'll try to create a test case.
Description
Current default directory requires android:requestLegacyExternalStorage on Q+ devices. See b/145598917#comment7 for this hitting us in CI (not the first time).
Changing the default is difficult, since it's hard coded in older versions of AGP. We could change it, and give people an option to change it back via inst arg, e.g.
androidx.benchmark.legacyOutputDirectory=true
The simpler approach would be to set
android:requestLegacyExternalStorage=true
in our manifest, and avoid the complexity for clients, at the cost of setting a legacy behavior flag without app involvement. As our library is only expected to be used for testing purposes, this may be fine.