Fixed
Status Update
Comments
cc...@google.com <cc...@google.com> #2
A couple of questions:
1. Have you saw crash in real device or only in simulators?
2. Do you use dynamic feature for language ID?
1. Have you saw crash in real device or only in simulators?
2. Do you use dynamic feature for language ID?
cc...@google.com <cc...@google.com> #3
Tested on Android 12 Emulator with custom executor, but cannot repro this issue.
ap...@google.com <ap...@google.com> #4
-
Second crash in the description is from a real device. Experienced it myself on two different Xiaomi phones, plus lots of crashes from users in the Google Play console.
-
Dynamic features are not used in the application.
As a wild guess, I have downgraded build tools from 31.0.0 to 30.0.3, compileSdk from 31 to 30, and moved all work with Language ID to the service in a separate process (just to be sure that crash can kill secondary process instead of main). This combination is in beta for 2 days by now and I don't see any SIGSEGV crashes.
Description
Current default directory requires android:requestLegacyExternalStorage on Q+ devices. See b/145598917#comment7 for this hitting us in CI (not the first time).
Changing the default is difficult, since it's hard coded in older versions of AGP. We could change it, and give people an option to change it back via inst arg, e.g.
androidx.benchmark.legacyOutputDirectory=true
The simpler approach would be to set
android:requestLegacyExternalStorage=true
in our manifest, and avoid the complexity for clients, at the cost of setting a legacy behavior flag without app involvement. As our library is only expected to be used for testing purposes, this may be fine.