Fixed
Status Update
No update yet.
Comments
pe...@gmail.com
Project: platform/frameworks/support
Branch: androidx-main
commit 7c6dacebb5dd68ddeec73e494c2d3b940db33b41
Author: Jeremy Woods <jbwoods@google.com>
Date: Thu Dec 02 16:04:03 2021
Prevent NavHost from compose the wrong entry
Treating the visible lists like sets to ensure that they never can
duplicate any entries and allow NavHost to choose the wrong entry to
compose.
We are opting to only treat it like a Set instead of making it into one
to ensure we will keep the snapshot funcationality of
mutableStateListOf().
RelNote: "Fixed potential crashed caused by fast switching between the
start destination and another destination using bottom nav menu items."
Test: all tests pass
Bug: 208887901
Change-Id: Ic89766e6f0527af0cd3e793643c38ea9e1f2a272
M navigation/navigation-compose/src/main/java/androidx/navigation/compose/NavHost.kt
https://android-review.googlesource.com/1909652
Branch: androidx-main
commit 7c6dacebb5dd68ddeec73e494c2d3b940db33b41
Author: Jeremy Woods <jbwoods@google.com>
Date: Thu Dec 02 16:04:03 2021
Prevent NavHost from compose the wrong entry
Treating the visible lists like sets to ensure that they never can
duplicate any entries and allow NavHost to choose the wrong entry to
compose.
We are opting to only treat it like a Set instead of making it into one
to ensure we will keep the snapshot funcationality of
mutableStateListOf().
RelNote: "Fixed potential crashed caused by fast switching between the
start destination and another destination using bottom nav menu items."
Test: all tests pass
Bug: 208887901
Change-Id: Ic89766e6f0527af0cd3e793643c38ea9e1f2a272
M navigation/navigation-compose/src/main/java/androidx/navigation/compose/NavHost.kt
ap...@google.com
This has been fixed internally and will be available in the Navigation 2.4.0-rc01 release.
jb...@google.com
This has been fixed internally and will be available in the Navigation 2.4.0-alpha02 release.
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit f76869ae3ec564e4c334dec53253a4a98634fb59
Author: Jeremy Woods <jbwoods@google.com>
Date: Wed May 26 17:49:41 2021
Modify safe-args plugin implementation
We are currently never actually calling the new VariantAPIs cause of an
incorrect if check. This fixes that and some other smaller
implementation details of the safe-args plugin.
Test: existing tests pass
Bug: 172824579
Change-Id: I0d80324e5f0e074a7ea4f864f1e50e6b8e68ff0c
M navigation/navigation-safe-args-gradle-plugin/src/main/kotlin/androidx/navigation/safeargs/gradle/ArgumentsGenerationTask.kt
M navigation/navigation-safe-args-gradle-plugin/src/main/kotlin/androidx/navigation/safeargs/gradle/SafeArgsPlugin.kt
https://android-review.googlesource.com/1720260
Branch: androidx-main
commit f76869ae3ec564e4c334dec53253a4a98634fb59
Author: Jeremy Woods <jbwoods@google.com>
Date: Wed May 26 17:49:41 2021
Modify safe-args plugin implementation
We are currently never actually calling the new VariantAPIs cause of an
incorrect if check. This fixes that and some other smaller
implementation details of the safe-args plugin.
Test: existing tests pass
Bug: 172824579
Change-Id: I0d80324e5f0e074a7ea4f864f1e50e6b8e68ff0c
M navigation/navigation-safe-args-gradle-plugin/src/main/kotlin/androidx/navigation/safeargs/gradle/ArgumentsGenerationTask.kt
M navigation/navigation-safe-args-gradle-plugin/src/main/kotlin/androidx/navigation/safeargs/gradle/SafeArgsPlugin.kt
Description
Android Gradle Plugin deprecated the
getApplicationIdTextResource()API on the classBaseVariantin version4.1.0(onVariantProperties) did not work properly for feature libraries, so to avoid the deprecation warning,4.2.0is stable we should update to that version and remove the reflection immediately.