Remove @Composable from interaction Modifier factories [172938345]

Fixed

Bug

Status Update

No update yet.

Description

lp...@google.com

created issue #1

Nov 10, 2020 07:44PM

Modifier.clickable
Modifier.selectable
Modifier.toggleable
Modifier.triStateToggleable

Are @Composable factory functions, which means that they cannot be created / referenced within top level Modifier declarations. For consistency with Compose API guidelines these should not be @Composable.

Comments

ma...@google.com <ma...@google.com> Dec 10, 2020 01:48PM

Accepted by ma...@google.com.

ap...@google.com <ap...@google.com> #2Jan 13, 2021 06:36PM

Marked as fixed.

+cc Siyamed and Matvei

For the context, there've been this bug b/155211005 that also proposed to have a String overload for the foundation text field. This bug is marked as fixed. So I'm wondering whether we did not provide this primitive override on purpose.
Since we're considering merging the BaseTextField and CoreTextField, do we want to have the primitive override in a single 'core' text field?

Issue 172938345

Description

Issue summary

Comments

ma...@google.com <ma...@google.com> Dec 10, 2020 01:48PM

ap...@google.com <ap...@google.com> #2Jan 13, 2021 06:36PM

Add comment

Issue metadata