StackOverflowError in ListenableWorker.stop [172946965]

Fixed

Bug

Status Update

No update yet.

Description

[Deleted User]

created issue #1

Nov 11, 2020 03:31PM

This crash is happening in our production app. I haven't been able to reproduce it locally, but looking at WorkManager's source, the cause seems pretty straightforward.

Fatal Exception: java.lang.StackOverflowError: stack size 1037KB
       at androidx.work.ListenableWorker.stop(ListenableWorker.java:245)
       at androidx.work.impl.workers.ConstraintTrackingWorker.onStopped(ConstraintTrackingWorker.java:181)
       at androidx.work.ListenableWorker.stop(ListenableWorker.java:245)
       at androidx.work.impl.workers.ConstraintTrackingWorker.onStopped(ConstraintTrackingWorker.java:181)
       at androidx.work.ListenableWorker.stop(ListenableWorker.java:245)
       at androidx.work.impl.workers.ConstraintTrackingWorker.onStopped(ConstraintTrackingWorker.java:181)
       at androidx.work.ListenableWorker.stop(ListenableWorker.java:245)
       at androidx.work.impl.workers.ConstraintTrackingWorker.onStopped(ConstraintTrackingWorker.java:181)
       at androidx.work.ListenableWorker.stop(ListenableWorker.java:245)
       at androidx.work.impl.workers.ConstraintTrackingWorker.onStopped(ConstraintTrackingWorker.java:181)
       at androidx.work.ListenableWorker.stop(ListenableWorker.java:245)
       at androidx.work.impl.workers.ConstraintTrackingWorker.onStopped(ConstraintTrackingWorker.java:181)
       at androidx.work.ListenableWorker.stop(ListenableWorker.java:245)
       at androidx.work.impl.workers.ConstraintTrackingWorker.onStopped(ConstraintTrackingWorker.java:181)
       at androidx.work.ListenableWorker.stop(ListenableWorker.java:245)
       at androidx.work.impl.workers.ConstraintTrackingWorker.onStopped(ConstraintTrackingWorker.java:181)
       at androidx.work.ListenableWorker.stop(ListenableWorker.java:245)
       at androidx.work.impl.workers.ConstraintTrackingWorker.onStopped(ConstraintTrackingWorker.java:181)
       at androidx.work.ListenableWorker.stop(ListenableWorker.java:245)
       at androidx.work.impl.workers.ConstraintTrackingWorker.onStopped(ConstraintTrackingWorker.java:181)
       at androidx.work.ListenableWorker.stop(ListenableWorker.java:245)
       at androidx.work.impl.WorkerWrapper.interrupt(WorkerWrapper.java:384)
       at androidx.work.impl.Processor.interrupt(Processor.java:328)
       at androidx.work.impl.Processor.stopWork(Processor.java:188)
       at androidx.work.impl.utils.StopWorkRunnable.run(StopWorkRunnable.java:68)
       at androidx.work.impl.utils.SerialExecutor$Task.run(SerialExecutor.java:91)
       at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1133)
       at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:607)
       at java.lang.Thread.run(Thread.java:776)

Here's the source for ListenableWorker.stop for version 2.5.0-beta01:

public final void stop() {
    mStopped = true;
    onStopped();
}

And here's the source for ConstraintTrackingWorker.onStopped for version 2.5.0-beta01:

@Override
public void onStopped() {
    super.onStopped();
    if (mDelegate != null) {
        // Stop is the method that sets the stopped and cancelled bits and invokes onStopped.
        mDelegate.stop();
    }
}

stop calls onStopped which calls stop and so on. My assumption is that one of these two methods should check if the worker has already been stopped before calling each other again.

Comments

ra...@google.com <ra...@google.com> Nov 11, 2020 05:25PM

Assigned to ra...@google.com.

ra...@google.com <ra...@google.com> #2Nov 11, 2020 07:28PM

Project: platform/frameworks/support
Branch: androidx-main

commit 53d7e9505dce7026e7c92059d42e5de784739106
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Mon Dec 06 16:26:25 2021

Avoid nullable boolean in constraint trackers

Now instead of returning null, trackers work pessimistically,
e.g. BatteryChargingTracker says that battery isn't charging.

It is done in preparation for Kotlin migration, where
this code smell is more apparent.

bug: 209145335
Test: *TrackerTest were updated
Change-Id: Ie1dcbe8961d925784d5633a297307993f3b8a43b

M work/work-runtime/src/androidTest/java/androidx/work/impl/constraints/trackers/ConstraintTrackerTest.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/ConstraintListener.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/constraints/trackers/StorageNotLowTrackerTest.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/constraints/trackers/BatteryChargingTrackerTest.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/trackers/BatteryNotLowTracker.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/controllers/ConstraintController.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/constraints/trackers/BatteryNotLowTrackerTest.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/trackers/BatteryChargingTracker.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/trackers/StorageNotLowTracker.java

https://android-review.googlesource.com/1911432

[Deleted User] <[Deleted User]> #3Nov 11, 2020 08:00PM

Project: platform/frameworks/support
Branch: androidx-main

commit 37b6a3fbb83456e319412c81f5039ffede5571c1
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Sat Dec 04 17:33:19 2021

Bump room 2.4.0-rc01

bug: 209145335
Test: refactoring
Change-Id: I29efb1b5a2e49ceddae999ed244803889723b080

M work/work-runtime/build.gradle
M work/work-runtime-ktx/build.gradle
M work/work-inspection/build.gradle
M work/work-gcm/build.gradle
M work/work-multiprocess/build.gradle
M work/work-benchmark/build.gradle
M work/work-testing/build.gradle
M work/integration-tests/testapp/build.gradle

https://android-review.googlesource.com/1910055

ra...@google.com <ra...@google.com> #4Nov 11, 2020 08:35PM

Project: platform/frameworks/support
Branch: androidx-main

commit e8d484789c3d8dc134b9ecf1d4e282f51223920c
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Sat Dec 04 22:22:39 2021

Migrate top-level androidx.work.impl.constraints to Kotlin

bug: 209145335
Test: refactoring, test passes
Change-Id: I0dc5e63898a3b2b2668059bf163a7573de8a932a

M work/work-runtime/src/main/java/androidx/work/impl/constraints/NetworkState.kt
M work/work-runtime/src/androidTest/java/androidx/work/impl/foreground/SystemForegroundDispatcherTest.kt
M work/work-runtime/src/main/java/androidx/work/impl/foreground/SystemForegroundDispatcher.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/ConstraintListener.kt
M work/work-runtime/src/androidTest/java/androidx/work/impl/constraints/WorkConstraintsTrackerTest.java
M work/work-runtime/src/main/java/androidx/work/impl/background/greedy/GreedyScheduler.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/WorkConstraintsCallback.kt
M work/work-runtime/src/main/java/androidx/work/impl/background/systemalarm/DelayMetCommandHandler.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/WorkConstraintsTracker.kt
M work/work-runtime/src/main/java/androidx/work/impl/workers/ConstraintTrackingWorker.java
M work/work-runtime/src/main/java/androidx/work/impl/background/systemalarm/ConstraintsCommandHandler.java

https://android-review.googlesource.com/1910059

ra...@google.com <ra...@google.com> #5Nov 11, 2020 08:36PM

Project: platform/frameworks/support
Branch: androidx-main

commit 2c5b5f38cc45864ee52c3475360d5a931fd5e2bb
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Sat Dec 04 18:56:38 2021

Rename top-level *.java to *.kt in androidx.work.impl.constraints

bug: 209145335
Test: NA
Change-Id: I8c9f0f410eadd940fd859512c2879b46c2bb20b0

M work/work-runtime/src/main/java/androidx/work/impl/constraints/NetworkState.kt
M work/work-runtime/src/main/java/androidx/work/impl/constraints/ConstraintListener.kt
M work/work-runtime/src/main/java/androidx/work/impl/constraints/WorkConstraintsCallback.kt
M work/work-runtime/src/main/java/androidx/work/impl/constraints/WorkConstraintsTracker.kt

https://android-review.googlesource.com/1910058

[Deleted User] <[Deleted User]> #6Nov 11, 2020 08:49PM

Project: platform/frameworks/support
Branch: androidx-main

commit 143f2871b37b9f7fefff10ea7b64637b2c3b7f71
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Sun Dec 05 15:39:07 2021

WorkManager: Migrate entities Kotlin

bug: 209145335
Test: refactoring
Change-Id: I3e112e2093d9b90712176e72087a3b4cebc374f9

M work/work-runtime/src/main/java/androidx/work/impl/model/WorkSpec.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/Dependency.kt
M work/work-runtime/src/main/java/androidx/work/impl/utils/IdGenerator.java
M work/work-runtime/src/main/java/androidx/work/impl/model/WorkName.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/SystemIdInfo.kt
M work/work-runtime/src/main/java/androidx/work/WorkRequest.java
M work/work-runtime/src/main/java/androidx/work/impl/model/Preference.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/WorkProgress.kt
M work/work-runtime/src/androidTest/java/androidx/work/WorkTest.java
M work/work-runtime/src/main/java/androidx/work/impl/model/WorkTag.kt
M work/work-runtime/src/androidTest/java/androidx/work/impl/utils/IdGeneratorTest.java

https://android-review.googlesource.com/1910061

[Deleted User] <[Deleted User]> #7Nov 11, 2020 10:32PM

Project: platform/frameworks/support
Branch: androidx-main

commit 23603ab83714ba75809e0bbeca2726f3ed006ad0
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Sun Dec 05 11:36:25 2021

WorkManager: Rename entities files from *.java to *.kt

bug: 209145335
Test: NA
Change-Id: Id7e559271895c34f21f3fb47dc1e38ce01bc30e3

M work/work-runtime/src/main/java/androidx/work/impl/model/WorkSpec.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/Dependency.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/WorkName.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/SystemIdInfo.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/Preference.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/WorkProgress.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/WorkTag.kt

https://android-review.googlesource.com/1910060

ra...@google.com <ra...@google.com> #8Nov 11, 2020 11:01PM

Project: platform/frameworks/support
Branch: androidx-main

commit 63984d1ca5096d9c67f3793f0d0dcb563e66c60a
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Sat Dec 04 18:30:04 2021

WorkManager: Migrate *Dao interfaces to Kotlin

bug: 209145335
Test: refactoring
Change-Id: Ibb1a25920e6f520d037b2605439b75ddbe57fe3f

M work/work-runtime/src/main/java/androidx/work/impl/model/WorkTagDao.kt
M work/work-multiprocess/src/androidTest/java/androidx/work/multiprocess/RemoteListenableWorkerTest.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/WorkNameDao.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/DependencyDao.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/PreferenceDao.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/WorkSpecDao.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/SystemIdInfoDao.kt
M work/work-inspection/src/main/java/androidx/work/inspection/WorkManagerInspector.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/RawWorkInfoDao.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/WorkProgressDao.kt
M work/work-multiprocess/src/androidTest/java/androidx/work/multiprocess/RemoteCoroutineWorkerTest.kt

https://android-review.googlesource.com/1910057

ap...@google.com <ap...@google.com> #9Nov 11, 2020 11:14PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 744c74c4609d854c3286264bda8a9645815073f7
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Sat Dec 04 17:07:28 2021

Rename *Dao.java to *Dao.kt

bug: 209145335
Test: NA
Change-Id: I9a712fa0c0ffbe2a09b5faed9f39737f47106d1d

M work/work-runtime/src/main/java/androidx/work/impl/model/WorkTagDao.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/WorkNameDao.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/DependencyDao.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/PreferenceDao.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/WorkSpecDao.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/SystemIdInfoDao.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/RawWorkInfoDao.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/WorkProgressDao.kt

https://android-review.googlesource.com/1910056

tb...@gmail.com <tb...@gmail.com> #10Nov 14, 2020 03:31PM

Project: platform/frameworks/support
Branch: androidx-main

commit eb75eadc68ba555ca18e1ccdf6c576dcbcdc1cfa
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Mon Dec 06 18:27:24 2021

Scope Trackers to WorkManagerImpl

It removes singleton, so we don't need
getInstance() / setInstance for testing purposes.

bug: 209145335
Test: refactoring
Change-Id: Ic9410f9679ff20d9c89bf4e01204f6c9d4de29cb

M work/work-runtime/src/main/java/androidx/work/impl/constraints/controllers/NetworkConnectedController.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/trackers/Trackers.java
M work/work-testing/src/main/java/androidx/work/testing/TestWorkManagerImpl.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/workers/ConstraintTrackingWorkerTest.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/controllers/NetworkMeteredController.java
M work/work-runtime/src/main/java/androidx/work/impl/background/systemalarm/ConstraintsCommandHandler.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/WorkManagerImplTest.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/background/systemalarm/SystemAlarmDispatcherTest.java
M work/work-runtime/src/main/java/androidx/work/impl/WorkManagerImpl.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/controllers/NetworkNotRoamingController.java
M work/work-runtime/src/main/java/androidx/work/impl/foreground/SystemForegroundDispatcher.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/controllers/BatteryChargingController.java
M work/work-runtime/src/main/java/androidx/work/impl/background/greedy/GreedyScheduler.java
M work/work-runtime/src/main/java/androidx/work/impl/background/systemalarm/DelayMetCommandHandler.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/controllers/StorageNotLowController.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/WorkManagerImplLargeExecutorTest.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/WorkConstraintsTracker.kt
M work/work-runtime/src/main/java/androidx/work/impl/workers/ConstraintTrackingWorker.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/controllers/BatteryNotLowController.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/controllers/NetworkUnmeteredController.java

https://android-review.googlesource.com/1911870