TextField Cursor Handle [173016579]

Fixed

Feature Request

Status Update

No update yet.

Description

si...@google.com

created issue #1

Nov 11, 2020 04:39PM

currently TextField does not show a cursor handle.

Implement cursor handle, and its drag.

Comments

si...@google.com <si...@google.com> Nov 25, 2020 03:38AM

Reassigned to si...@google.com.

il...@gmail.com <il...@gmail.com> #2Jan 17, 2021 04:28PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Louis Pullen-Freilich <lpf@google.com>
Link: https://android-review.googlesource.com/3328184

Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling

Expand for full commit details

Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling 
 
These APIs allow overscroll to have events dispatched to it by one component, and rendered in a separate component. 
 
Fixes: b/266550551 
Fixes: b/204650733 
Fixes: b/255554340 
Fixes: b/229537244 
Test: OverscrollTest 
Relnote: "Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling APIs - these APIs create a wrapped instance of the provided overscroll effect that doesn't draw / handle events respectively, which allows for rendering  overscroll in a separate component from the component that is dispatching events. For example, disabling drawing the overscroll inside a lazy list, and then drawing the overscroll separately on top / elsewhere." 
Change-Id: Idbb3d91546b49c1987a041f959bce4b2b09a9f61

Files:

M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/restricted_current.txt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/OverscrollDemo.kt
M compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/OverscrollSample.kt
M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/OverscrollTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Overscroll.kt

Hash: f64e25b7a473c757d080521e7dd97b3f6670f60d
Date: Fri Nov 01 18:43:56 2024

si...@google.com <si...@google.com> #3Jan 17, 2021 04:38PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.foundation:foundation:1.8.0-alpha06
androidx.compose.foundation:foundation-android:1.8.0-alpha06
androidx.compose.foundation:foundation-jvmstubs:1.8.0-alpha06
androidx.compose.foundation:foundation-linuxx64stubs:1.8.0-alpha06

si...@google.com <si...@google.com> Feb 11, 2021 01:20AM

Reassigned to an...@google.com.

si...@google.com <si...@google.com> Apr 2, 2021 05:31AM

Reassigned to qq...@google.com.

qq...@google.com <qq...@google.com> May 7, 2021 11:23PM

Accepted by qq...@google.com.

si...@google.com <si...@google.com> Jun 11, 2021 06:13PM

Reassigned to an...@google.com.

ha...@google.com <ha...@google.com> Jul 1, 2021 06:32AM

Reassigned to ha...@google.com.

ap...@google.com <ap...@google.com> #4Jul 14, 2021 05:17PM

Project: platform/frameworks/support
Branch: androidx-main

commit 1c6a17a061e7b4a70047224e8f31d3eecb66b5ef
Author: Qingqing Deng <qqd@google.com>
Date: Tue Jun 01 15:45:51 2021

Cursor Handle.

Bug:173016579
Test: ./gradlew test
Test: ./gradlew compose:foundation:foundation:connectedAndroidTest
Test: Manullay tested.

RelNote: Add Cursor Handle.
Change-Id: I07a8217c8ecbcd1c84c1a8df20c6e8b07d409148

M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/public_plus_experimental_current.txt
M compose/foundation/foundation/api/restricted_current.txt
A compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text/AndroidCursorHandle.android.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/CoreTextField.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/selection/TextFieldSelectionManager.kt
A compose/foundation/foundation/src/desktopMain/kotlin/androidx/compose/foundation/text/DesktopCursorHandle.desktop.kt
M compose/foundation/foundation/src/test/kotlin/androidx/compose/foundation/text/selection/TextFieldSelectionManagerTest.kt

https://android-review.googlesource.com/1725113

ha...@google.com <ha...@google.com> Jul 15, 2021 06:30PM

Marked as fixed.

ap...@google.com <ap...@google.com> #5Jul 15, 2021 11:22PM

Project: platform/frameworks/support
Branch: androidx-main

commit d47f1fe5b05eb9cc19c1b44dabbb4b0f34145817
Author: Haoyu Zhang <haoyuchang@google.com>
Date: Tue Jul 13 03:10:55 2021

Refactor selection handle

- Removed unnecessary parameters from SelectionHandle composable to avoid unnecessary recompose.
- Avoid using Path to draw selection handle for better performance.
- Reused the painting logic of selection handle in cursor handle.

Bug: 173016579
Test: ./gradlew test
Test: ./gradlew compose:foundation:foundation:connectedAndroidTest
Change-Id: I0a9f197913e78fd67289182b4704d69979f5b35a

M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text/selection/SelectionHandlePopupPositionTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text/selection/SelectionHandlesTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text/selection/TextSelectionColorsScreenshotTest.kt
M compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text/AndroidCursorHandle.android.kt
M compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text/selection/AndroidSelectionHandles.android.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/CoreTextField.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/selection/SelectionContainer.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/selection/SelectionHandles.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/selection/SelectionManager.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/selection/TextFieldSelectionManager.kt
M compose/foundation/foundation/src/desktopMain/kotlin/androidx/compose/foundation/text/selection/DesktopSelectionHandles.desktop.kt

https://android-review.googlesource.com/1764405

ap...@google.com <ap...@google.com> #6Jul 16, 2021 05:20PM

Project: platform/frameworks/support
Branch: androidx-main

commit 3d5628e3d8ba223533646945e5e55b3c43f514e7
Author: Haoyu Zhang <haoyuchang@google.com>
Date: Thu Jul 15 16:23:04 2021

Hide cursor when input is from physical keyboard

Also simplified the logic to hide cursor when text get changed from
software keyboard.

Bug: 173016579
Test: ./gradlew test
Change-Id: Ibe242728c8aec7cccdfc29ac137dceb0f587bc14

M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/CoreTextField.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/TextFieldKeyInput.kt

https://android-review.googlesource.com/1768979