Migrate DrawLayerModifier right inside the layout logic [173030831]

Fixed

Feature Request

Status Update

No update yet.

Description

an...@google.com

created issue #1

Nov 11, 2020 07:36PM

We want to integrate functionality currently available as DrawLayerModifeir right inside the Layout system.

Why to do so:
1) To allow custom layouts to insert the layers for the children if they need to. For example It is needed in LazyColumn as an optimization (

b/170296989

)

2) Allows to simplify the system by having less concepts. Now DrawLayerModifier is a whole separate concept. With integrating layers right inside the layout system Modifier.drawLayer() will be implemented just as a simple LayoutModifier with DrawLayerModifier class being removed. We already did the same thing with ZIndexModifier (

b/171493718

)

Comments

ap...@google.com <ap...@google.com> #2Nov 18, 2020 11:59AM

We have some support in androidx.compose.ui.autofill

Leaving this bug open in case Ralston wants to add more info

ap...@google.com <ap...@google.com> #3Nov 18, 2020 11:59AM

I found an example here. One problem is that it only works with the Google autofill service. When using any other service like Microsoft Authenticator or OneKey, the following error is shown:

D/Autofill Status: Autofill popup isn't shown because autofill is not available.
    
    Did you set up autofill?
    1. Go to Settings > System > Languages&input > Advanced > Autofill Service
    2. Pick a service
    
    Did you add an account?
    1. Go to Settings > System > Languages&input > Advanced
    2. Click on the settings icon next to the Autofill Service
    3. Add your account

Is this a bug on your side or do the app developers of these password managers need to change their implementation?

ap...@google.com <ap...@google.com> #4Nov 18, 2020 11:59AM

Another problem I am facing with autofill is that it won't save my credentials. I tried forcing to finish the context as described here, but it won't do that either although I filled in the username with the one provided by the Google autofill service.

ap...@google.com <ap...@google.com> #5Nov 23, 2020 05:11PM

deleted

an...@google.com <an...@google.com> Nov 23, 2020 05:17PM

Marked as fixed.

Issue 173030831